From patchwork Mon Jun 15 16:19:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joshua Clayton X-Patchwork-Id: 6610591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 268FBC0020 for ; Mon, 15 Jun 2015 16:23:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 523EA2071B for ; Mon, 15 Jun 2015 16:23:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 507B920719 for ; Mon, 15 Jun 2015 16:23:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4X8D-0006gB-UF; Mon, 15 Jun 2015 16:21:05 +0000 Received: from mail-pd0-x235.google.com ([2607:f8b0:400e:c02::235]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4X6s-0004v5-1m for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2015 16:19:42 +0000 Received: by pdjm12 with SMTP id m12so76067210pdj.3 for ; Mon, 15 Jun 2015 09:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sjdz5tCeraWySYY60e9T5yoUdKFSLelBI+auqYzc0Io=; b=xq/U03sXJBdDvcGralc6Sm0OjpzPRwyX8wKXn+WQnKPm5oppT1Igd6QSYZTVAU1I98 iBQD9feisfLzdKnlFUpjOXun4XQgCMe1DfBsoX383Z0B1tljxoioqXJu9OzHt5cC5JvI kJwz05OsCdb5Kf8nr2fZvPlGsX2PLl8TRZu7TrRKOhL5IcoyD3TFRIo6x24Q8u1Mhn1X +I9/3K+H62wCzoH5DjY5kKJUClf/dHshvLA517MFMPjshGH46rynhJ/6vrY/WV8bZWBl CGiuiHuWaUjIFzKaA7Nc0e+uRdXhb4J0pIAEwi6fD8zamv8w7Sp66I3i1X84TO/d1bVL Hzdw== X-Received: by 10.68.235.38 with SMTP id uj6mr50133907pbc.57.1434385160949; Mon, 15 Jun 2015 09:19:20 -0700 (PDT) Received: from localhost.localdomain (68-185-59-186.static.knwc.wa.charter.com. [68.185.59.186]) by mx.google.com with ESMTPSA id qg5sm12717637pdb.13.2015.06.15.09.19.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Jun 2015 09:19:19 -0700 (PDT) From: Joshua Clayton To: Vinod Koul Subject: [PATCH 05/10] dma: sdma-imx: print an error when context load fails. Date: Mon, 15 Jun 2015 09:19:00 -0700 Message-Id: <1434385144-4432-6-git-send-email-stillcompiling@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1434385144-4432-1-git-send-email-stillcompiling@gmail.com> References: <1434385144-4432-1-git-send-email-stillcompiling@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150615_091942_171989_317DDC53 X-CRM114-Status: GOOD ( 10.23 ) X-Spam-Score: -0.8 (/) Cc: Joshua Clayton , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Dan Williams , Shawn Guo , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Its not nice to have the context load fail silently. Signed-off-by: Joshua Clayton --- drivers/dma/imx-sdma.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index fdf88c4..8358a1a 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -827,6 +827,10 @@ static int sdma_load_context(struct sdma_channel *sdmac) spin_unlock_irqrestore(&sdma->channel_0_lock, flags); + if (ret) + dev_err(sdma->dev, "SDMA channel %d: chan0 timed out\n", + channel); + return ret; }