| Message ID | 1434548543-22949-4-git-send-email-tomeu.vizoso@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 17, 2015 at 03:42:13PM +0200, Tomeu Vizoso wrote: > Specify how the GPIOs map to the pins in Tegra SoCs, so the dependency is > explicit. Can I suggest splitting this sort of patch out of the patch series (and similarly the documentation fix you had), or putting them at the end or something? It's pretty confusing that early patches in the series are a bit tangential rather than being dependencies for the rest of it.
On 17 June 2015 at 19:25, Mark Brown <broonie@kernel.org> wrote: > On Wed, Jun 17, 2015 at 03:42:13PM +0200, Tomeu Vizoso wrote: >> Specify how the GPIOs map to the pins in Tegra SoCs, so the dependency is >> explicit. > > Can I suggest splitting this sort of patch out of the patch series (and > similarly the documentation fix you had), or putting them at the end or > something? It's pretty confusing that early patches in the series are > a bit tangential rather than being dependencies for the rest of it. Agreed, sorry about that. Thanks, Tomeu
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index f58a3d9..7e1e171 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -234,6 +234,7 @@ gpio-controller; #interrupt-cells = <2>; interrupt-controller; + gpio-ranges = <&pinmux 0 0 246>; }; apbmisc@70000800 { diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index 87318a7..4779df3 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -255,6 +255,7 @@ gpio-controller; #interrupt-cells = <2>; interrupt-controller; + gpio-ranges = <&pinmux 0 0 251>; }; apbdma: dma@0,60020000 { diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index f444b67..b44277c 100644 --- a/arch/arm/boot/dts/tegra20.dtsi +++ b/arch/arm/boot/dts/tegra20.dtsi @@ -244,6 +244,7 @@ gpio-controller; #interrupt-cells = <2>; interrupt-controller; + gpio-ranges = <&pinmux 0 0 224>; }; apbmisc@70000800 { diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index 782b11b..28c547f 100644 --- a/arch/arm/boot/dts/tegra30.dtsi +++ b/arch/arm/boot/dts/tegra30.dtsi @@ -349,6 +349,7 @@ gpio-controller; #interrupt-cells = <2>; interrupt-controller; + gpio-ranges = <&pinmux 0 0 248>; }; apbmisc@70000800 {
Specify how the GPIOs map to the pins in Tegra SoCs, so the dependency is explicit. This currently will add a duplicated entry in the map from pins to gpios in the pinmux controller but it should be harmless and will be fixed in a later commit. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- v2: * Change number of gpios to 251 to match pinctrl-tegra124.c * Add note about duplicated mapping * Add the property to all the other Tegra SoCs --- arch/arm/boot/dts/tegra114.dtsi | 1 + arch/arm/boot/dts/tegra124.dtsi | 1 + arch/arm/boot/dts/tegra20.dtsi | 1 + arch/arm/boot/dts/tegra30.dtsi | 1 + 4 files changed, 4 insertions(+)