[v6,7/9] nvmem: qfprom: Add bindings for qfprom

Commit Message

Srinivas Kandagatla June 22, 2015, 11:09 p.m. UTC

This patch adds bindings for qfprom found in QCOM SOCs. QFPROM driver
is based on simple nvmem framework.

Reviewed-by: Stephen Boyd <[e-mail]>
Signed-off-by: Srinivas Kandagatla <[e-mail]>
---
 Documentation/devicetree/bindings/nvmem/qfprom.txt | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/nvmem/qfprom.txt

Comments

Rajendra Nayak June 23, 2015, 9:25 a.m. UTC | #1

[]..

> +Example:
> +
> +	qfprom: qfprom@00700000 {
> +		compatible 	= "qcom,qfprom";
> +		reg		= <0x00700000 0x8000>;
> +		...
> +		/* Data cells */
> +		tsens_calibration: calib@404 {
> +			reg = <0x4404 0x10>;
> +		};
> +	};
> +
> +
> += Data consumers =
> +Are device nodes which consume nvmem data cells.
> +
> +For example:
> +
> +	tsens {
> +		...
> +		nvmem-cell = <&tsens_calibration>;

Shouldn't this be nvmem-cells instead?

> +		nvmem-cell-names = "calibration";
> +	};
>

Srinivas Kandagatla June 24, 2015, 9:49 a.m. UTC | #2

On 23/06/15 10:25, Rajendra Nayak wrote:
> []..
>
>> +Example:
>> +
>> +    qfprom: qfprom@00700000 {
>> +        compatible     = "qcom,qfprom";
>> +        reg        = <0x00700000 0x8000>;
>> +        ...
>> +        /* Data cells */
>> +        tsens_calibration: calib@404 {
>> +            reg = <0x4404 0x10>;
>> +        };
>> +    };
>> +
>> +
>> += Data consumers =
>> +Are device nodes which consume nvmem data cells.
>> +
>> +For example:
>> +
>> +    tsens {
>> +        ...
>> +        nvmem-cell = <&tsens_calibration>;
>
> Shouldn't this be nvmem-cells instead?
>
You are correct, Will fix it in next version.

--srini
>> +        nvmem-cell-names = "calibration";
>> +    };
>>

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/qfprom.txt b/Documentation/devicetree/bindings/nvmem/qfprom.txt
new file mode 100644
index 0000000..8a8d55f
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/qfprom.txt
@@ -0,0 +1,35 @@ 
+= Qualcomm QFPROM device tree bindings =
+
+This binding is intended to represent QFPROM which is found in most QCOM SOCs.
+
+Required properties:
+- compatible: should be "qcom,qfprom"
+- reg: Should contain registers location and length
+
+= Data cells =
+Are child nodes of qfprom, bindings of which as described in
+bindings/nvmem/nvmem.txt
+
+Example:
+
+	qfprom: qfprom@00700000 {
+		compatible 	= "qcom,qfprom";
+		reg		= <0x00700000 0x8000>;
+		...
+		/* Data cells */
+		tsens_calibration: calib@404 {
+			reg = <0x4404 0x10>;
+		};
+	};
+
+
+= Data consumers =
+Are device nodes which consume nvmem data cells.
+
+For example:
+
+	tsens {
+		...
+		nvmem-cell = <&tsens_calibration>;
+		nvmem-cell-names = "calibration";
+	};