| Message ID | 1435800787-696-1-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-07-02 10:33 GMT+09:00 Jisheng Zhang <jszhang@marvell.com>: > It is not needed after booting, this patch moves the arm_cpuidle_init() > function to the __init section. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > arch/arm64/kernel/cpuidle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This looks good but I think you can also mark the stub in arch/arm64/include/asm/cpuidle.h. Best regards, Krzysztof
Dear Krzysztof, On Thu, 2 Jul 2015 10:56:47 +0900 Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > 2015-07-02 10:33 GMT+09:00 Jisheng Zhang <jszhang@marvell.com>: > > It is not needed after booting, this patch moves the arm_cpuidle_init() > > function to the __init section. > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > --- > > arch/arm64/kernel/cpuidle.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This looks good but I think you can also mark the stub in > arch/arm64/include/asm/cpuidle.h. > Thanks for review. Has adopted your suggestion in v2. Thanks, Jisheng
On Thu, Jul 02, 2015 at 09:33:07AM +0800, Jisheng Zhang wrote: > It is not needed after booting, this patch moves the arm_cpuidle_init() > function to the __init section. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Applied. Thanks.
diff --git a/arch/arm64/kernel/cpuidle.c b/arch/arm64/kernel/cpuidle.c index 7ce589c..9047cab6 100644 --- a/arch/arm64/kernel/cpuidle.c +++ b/arch/arm64/kernel/cpuidle.c @@ -15,7 +15,7 @@ #include <asm/cpuidle.h> #include <asm/cpu_ops.h> -int arm_cpuidle_init(unsigned int cpu) +int __init arm_cpuidle_init(unsigned int cpu) { int ret = -EOPNOTSUPP;
It is not needed after booting, this patch moves the arm_cpuidle_init() function to the __init section. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- arch/arm64/kernel/cpuidle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)