From patchwork Sat Jul 4 13:01:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 6717411 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2775EC05AD for ; Sat, 4 Jul 2015 13:04:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EC56E207C8 for ; Sat, 4 Jul 2015 13:04:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 970BB207C4 for ; Sat, 4 Jul 2015 13:04:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZBN5x-0003hS-TN; Sat, 04 Jul 2015 13:03:01 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZBN5d-0003GP-JK for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2015 13:02:42 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id t64D0YpQ014388; Sat, 4 Jul 2015 06:02:09 -0700 Received: from sc-owa.marvell.com ([199.233.58.135]) by mx0a-0016f401.pphosted.com with ESMTP id 1vecug0apf-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 04 Jul 2015 06:02:08 -0700 Received: from maili.marvell.com (10.93.76.83) by SC-OWA.marvell.com (10.93.76.28) with Microsoft SMTP Server id 8.3.327.1; Sat, 4 Jul 2015 06:02:08 -0700 Received: from xhacker.marvell.com (unknown [10.37.135.134]) by maili.marvell.com (Postfix) with ESMTP id 9B51A3F703F; Sat, 4 Jul 2015 06:02:06 -0700 (PDT) From: Jisheng Zhang To: , , , , , Subject: [RFC PATCH 1/3] arm: psci: rename psci_smp.c to psci.c Date: Sat, 4 Jul 2015 21:01:48 +0800 Message-ID: <1436014910-1201-2-git-send-email-jszhang@marvell.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436014910-1201-1-git-send-email-jszhang@marvell.com> References: <1436014910-1201-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-07-04_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507040233 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150704_060241_658589_3752FEA7 X-CRM114-Status: GOOD ( 21.57 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This will prepare for next commit to enable PSCI for UP systems so that calls like cpu_suspend can be made functional on UP too. Signed-off-by: Jisheng Zhang --- arch/arm/kernel/Makefile | 2 +- arch/arm/kernel/psci.c | 130 +++++++++++++++++++++++++++++++++++++++++++++ arch/arm/kernel/psci_smp.c | 130 --------------------------------------------- 3 files changed, 131 insertions(+), 131 deletions(-) create mode 100644 arch/arm/kernel/psci.c delete mode 100644 arch/arm/kernel/psci_smp.c diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile index 3b995f5..c57b2c0 100644 --- a/arch/arm/kernel/Makefile +++ b/arch/arm/kernel/Makefile @@ -90,7 +90,7 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o ifeq ($(CONFIG_ARM_PSCI),y) obj-y += psci-call.o -obj-$(CONFIG_SMP) += psci_smp.o +obj-$(CONFIG_SMP) += psci.o endif extra-y := $(head-y) vmlinux.lds diff --git a/arch/arm/kernel/psci.c b/arch/arm/kernel/psci.c new file mode 100644 index 0000000..61c04b0 --- /dev/null +++ b/arch/arm/kernel/psci.c @@ -0,0 +1,130 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Copyright (C) 2012 ARM Limited + * + * Author: Will Deacon + */ + +#include +#include +#include +#include +#include + +#include + +#include +#include + +/* + * psci_smp assumes that the following is true about PSCI: + * + * cpu_suspend Suspend the execution on a CPU + * @state we don't currently describe affinity levels, so just pass 0. + * @entry_point the first instruction to be executed on return + * returns 0 success, < 0 on failure + * + * cpu_off Power down a CPU + * @state we don't currently describe affinity levels, so just pass 0. + * no return on successful call + * + * cpu_on Power up a CPU + * @cpuid cpuid of target CPU, as from MPIDR + * @entry_point the first instruction to be executed on return + * returns 0 success, < 0 on failure + * + * migrate Migrate the context to a different CPU + * @cpuid cpuid of target CPU, as from MPIDR + * returns 0 success, < 0 on failure + * + */ + +extern void secondary_startup(void); + +static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle) +{ + if (psci_ops.cpu_on) + return psci_ops.cpu_on(cpu_logical_map(cpu), + virt_to_idmap(&secondary_startup)); + return -ENODEV; +} + +#ifdef CONFIG_HOTPLUG_CPU +int psci_cpu_disable(unsigned int cpu) +{ + /* Fail early if we don't have CPU_OFF support */ + if (!psci_ops.cpu_off) + return -EOPNOTSUPP; + + /* Trusted OS will deny CPU_OFF */ + if (psci_tos_resident_on(cpu)) + return -EPERM; + + return 0; +} + +void __ref psci_cpu_die(unsigned int cpu) +{ + u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN << + PSCI_0_2_POWER_STATE_TYPE_SHIFT; + + if (psci_ops.cpu_off) + psci_ops.cpu_off(state); + + /* We should never return */ + panic("psci: cpu %d failed to shutdown\n", cpu); +} + +int __ref psci_cpu_kill(unsigned int cpu) +{ + int err, i; + + if (!psci_ops.affinity_info) + return 1; + /* + * cpu_kill could race with cpu_die and we can + * potentially end up declaring this cpu undead + * while it is dying. So, try again a few times. + */ + + for (i = 0; i < 10; i++) { + err = psci_ops.affinity_info(cpu_logical_map(cpu), 0); + if (err == PSCI_0_2_AFFINITY_LEVEL_OFF) { + pr_info("CPU%d killed.\n", cpu); + return 1; + } + + msleep(10); + pr_info("Retrying again to check for CPU kill\n"); + } + + pr_warn("CPU%d may not have shut down cleanly (AFFINITY_INFO reports %d)\n", + cpu, err); + /* Make platform_cpu_kill() fail. */ + return 0; +} + +#endif + +bool __init psci_smp_available(void) +{ + /* is cpu_on available at least? */ + return (psci_ops.cpu_on != NULL); +} + +struct smp_operations __initdata psci_smp_ops = { + .smp_boot_secondary = psci_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_disable = psci_cpu_disable, + .cpu_die = psci_cpu_die, + .cpu_kill = psci_cpu_kill, +#endif +}; diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c deleted file mode 100644 index 61c04b0..0000000 --- a/arch/arm/kernel/psci_smp.c +++ /dev/null @@ -1,130 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * Copyright (C) 2012 ARM Limited - * - * Author: Will Deacon - */ - -#include -#include -#include -#include -#include - -#include - -#include -#include - -/* - * psci_smp assumes that the following is true about PSCI: - * - * cpu_suspend Suspend the execution on a CPU - * @state we don't currently describe affinity levels, so just pass 0. - * @entry_point the first instruction to be executed on return - * returns 0 success, < 0 on failure - * - * cpu_off Power down a CPU - * @state we don't currently describe affinity levels, so just pass 0. - * no return on successful call - * - * cpu_on Power up a CPU - * @cpuid cpuid of target CPU, as from MPIDR - * @entry_point the first instruction to be executed on return - * returns 0 success, < 0 on failure - * - * migrate Migrate the context to a different CPU - * @cpuid cpuid of target CPU, as from MPIDR - * returns 0 success, < 0 on failure - * - */ - -extern void secondary_startup(void); - -static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle) -{ - if (psci_ops.cpu_on) - return psci_ops.cpu_on(cpu_logical_map(cpu), - virt_to_idmap(&secondary_startup)); - return -ENODEV; -} - -#ifdef CONFIG_HOTPLUG_CPU -int psci_cpu_disable(unsigned int cpu) -{ - /* Fail early if we don't have CPU_OFF support */ - if (!psci_ops.cpu_off) - return -EOPNOTSUPP; - - /* Trusted OS will deny CPU_OFF */ - if (psci_tos_resident_on(cpu)) - return -EPERM; - - return 0; -} - -void __ref psci_cpu_die(unsigned int cpu) -{ - u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN << - PSCI_0_2_POWER_STATE_TYPE_SHIFT; - - if (psci_ops.cpu_off) - psci_ops.cpu_off(state); - - /* We should never return */ - panic("psci: cpu %d failed to shutdown\n", cpu); -} - -int __ref psci_cpu_kill(unsigned int cpu) -{ - int err, i; - - if (!psci_ops.affinity_info) - return 1; - /* - * cpu_kill could race with cpu_die and we can - * potentially end up declaring this cpu undead - * while it is dying. So, try again a few times. - */ - - for (i = 0; i < 10; i++) { - err = psci_ops.affinity_info(cpu_logical_map(cpu), 0); - if (err == PSCI_0_2_AFFINITY_LEVEL_OFF) { - pr_info("CPU%d killed.\n", cpu); - return 1; - } - - msleep(10); - pr_info("Retrying again to check for CPU kill\n"); - } - - pr_warn("CPU%d may not have shut down cleanly (AFFINITY_INFO reports %d)\n", - cpu, err); - /* Make platform_cpu_kill() fail. */ - return 0; -} - -#endif - -bool __init psci_smp_available(void) -{ - /* is cpu_on available at least? */ - return (psci_ops.cpu_on != NULL); -} - -struct smp_operations __initdata psci_smp_ops = { - .smp_boot_secondary = psci_boot_secondary, -#ifdef CONFIG_HOTPLUG_CPU - .cpu_disable = psci_cpu_disable, - .cpu_die = psci_cpu_die, - .cpu_kill = psci_cpu_kill, -#endif -};