| Message ID | 1437476823-3358-3-git-send-email-vaibhav.hiremath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-07-21 20:07 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: > This patch updates the binding documentation for optional > clocks node and related information for buffered 32KHz clock. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 28 +++++++++++++++++++++++ > 1 file changed, 28 insertions(+) +Cc Stephen Boyd (clocks) We had a discussion whether clock bindings should be put in MFD bindings documentation or into separate file in bindings/clock but either way is fine for me: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On 07/22/2015 10:08 PM, Krzysztof Kozlowski wrote: > 2015-07-21 20:07 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: >> This patch updates the binding documentation for optional >> clocks node and related information for buffered 32KHz clock. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 28 +++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) > +Cc Stephen Boyd (clocks) > > We had a discussion whether clock bindings should be put in MFD > bindings documentation or into separate file in bindings/clock but > either way is fine for me: No patch? :) I think Rob has been pushing for MFDs to document everything within one file, but either way is fine from clk perspective.
On Thu, Jul 30, 2015 at 5:13 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 07/22/2015 10:08 PM, Krzysztof Kozlowski wrote: >> >> 2015-07-21 20:07 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: >>> >>> This patch updates the binding documentation for optional >>> clocks node and related information for buffered 32KHz clock. >>> >>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >>> --- >>> Documentation/devicetree/bindings/mfd/88pm800.txt | 28 >>> +++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >> >> +Cc Stephen Boyd (clocks) >> >> We had a discussion whether clock bindings should be put in MFD >> bindings documentation or into separate file in bindings/clock but >> either way is fine for me: > > > No patch? :) > > I think Rob has been pushing for MFDs to document everything within one > file, but either way is fine from clk perspective. I don't recall that exactly. I did say that child bindings need to point back to the MFD binding. So this is fine with me: Acked-by: Rob Herring <robh@kernel.org> Rob
On Friday 31 July 2015 03:51 AM, Rob Herring wrote: > On Thu, Jul 30, 2015 at 5:13 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> On 07/22/2015 10:08 PM, Krzysztof Kozlowski wrote: >>> >>> 2015-07-21 20:07 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: >>>> >>>> This patch updates the binding documentation for optional >>>> clocks node and related information for buffered 32KHz clock. >>>> >>>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/mfd/88pm800.txt | 28 >>>> +++++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>> >>> +Cc Stephen Boyd (clocks) >>> >>> We had a discussion whether clock bindings should be put in MFD >>> bindings documentation or into separate file in bindings/clock but >>> either way is fine for me: >> >> >> No patch? :) >> >> I think Rob has been pushing for MFDs to document everything within one >> file, but either way is fine from clk perspective. > > I don't recall that exactly. I did say that child bindings need to > point back to the MFD binding. So this is fine with me: > > Acked-by: Rob Herring <robh@kernel.org> > Thanks Rob for the ack. Can this be queued now (for next merge window)? Thanks, Vaibhav
diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt index dec842f..60cab78 100644 --- a/Documentation/devicetree/bindings/mfd/88pm800.txt +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt @@ -9,6 +9,27 @@ Required parent device properties: - #interrupt-cells : should be 1. The cell is the 88pm80x local IRQ number +Optional nodes: +- clocks: 88pm800 family of devices provide multiple buffered 32.768 + KHz outputs, so to register these as clocks with common clock framework + instantiate a sub-node named "clocks". It uses the common clock binding + documented in : + [Documentation/devicetree/bindings/clock/clock-bindings.txt] + + - #clock-cells: should be 1. + + - The following is the list of clocks generated by the controller. Each clock + is assigned an identifier and client nodes use this identifier to specify + the clock which they consume. + Clock ID Devices + ---------------------------------------------------------- + pm800_clk32k_1 0 88PM800 and 88PM860 + pm800_clk32k_2 1 88PM800 and 88PM860 + pm800_clk32k_3 2 88PM800 + + - compatible: Should be : "marvell,88pm800-clk" + + 88pm80x family of devices consists of varied group of sub-devices: Device Supply Names Description @@ -16,6 +37,7 @@ Device Supply Names Description 88pm80x-onkey : : On key 88pm80x-rtc : : RTC 88pm80x-regulator : : Regulators +88pm80x-clk : : 32KHz Clk provider Example: @@ -27,6 +49,12 @@ Example: interrupt-controller; #interrupt-cells = <1>; + pm800clk: clocks { + compatible = "marvell,88pm800-clk"; + #clock-cells = <1>; + clock-output-names = "xx", "yy", "zz"; + }; + regulators { compatible = "marvell,88pm80x-regulator";
This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/mfd/88pm800.txt | 28 +++++++++++++++++++++++ 1 file changed, 28 insertions(+)