From patchwork Wed Jul 22 22:10:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joachim Eastwood X-Patchwork-Id: 6847401 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56582C05AC for ; Wed, 22 Jul 2015 22:12:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 863882066A for ; Wed, 22 Jul 2015 22:12:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2C992065D for ; Wed, 22 Jul 2015 22:12:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZI2EI-0006X0-Dy; Wed, 22 Jul 2015 22:11:10 +0000 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZI2EF-0006Hk-EP for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2015 22:11:08 +0000 Received: by lahe2 with SMTP id e2so83893669lah.1 for ; Wed, 22 Jul 2015 15:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Uw1BwrqVInwGhU7GOg7lFGlE9gqzMh4qwQ18knclUQE=; b=Wqe8YZ4NB3ADJgKX4fbBUTSPGF1AR2x7g80TSSINbgKdUL/+PBM4786CPytMvnqqdq gEf+K1Pc4XOLCgVlJCavWF7vOd62HX7yGTrpemmEuxbJ46yd/T2bM4T+clecR3hCCwsq i34LXknYeHJ26+H54FtC6PZ76JXJ8K+ce/dlPyk8vCYYUw6JF+3vkohDpuUFwPi2DjsV 82r9TBEHyu29H/2nQvT+nKIRmiyHomxI0rYBOhamiVD3xxw5XDZ/p39oub+rsCNjI7bc vwoxAmpFlQt41ipc3Kt2IcVkbSivUjy2MnfbC8Vsr2FSKGl42zuYqXhlJLponssukw8P HL9g== X-Received: by 10.152.164.193 with SMTP id ys1mr4418031lab.65.1437603044316; Wed, 22 Jul 2015 15:10:44 -0700 (PDT) Received: from localhost.localdomain ([89.11.213.141]) by smtp.gmail.com with ESMTPSA id l5sm560772lal.29.2015.07.22.15.10.43 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Jul 2015 15:10:43 -0700 (PDT) From: Joachim Eastwood To: olof@lixom.net, arm@kernel.org Subject: [PATCH] memory: pl172: fix modular build Date: Thu, 23 Jul 2015 00:10:37 +0200 Message-Id: <1437603037-18395-1-git-send-email-manabian@gmail.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <20150722184345.GB11162@sirena.org.uk> References: <20150722184345.GB11162@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150722_151107_674902_27365C6F X-CRM114-Status: GOOD ( 11.47 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-kernel@lists.linaro.org, kernel-build-reports@lists.linaro.org, Joachim Eastwood , broonie@kernel.org, linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Building pl172 as a module fails with: > ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined! Because the symbol of_default_bus_match_table isn't exported by the OF core code so can't be referenced from modules. Fix this by removing the usage of of_default_bus_match_table for now. The side effect of this is that child nodes can't use "simple-bus" or "simple-mfd". Reported-by: Mark Brown Signed-off-by: Joachim Eastwood --- This should fix the allmod build failure introduces by the pl172 driver that Mark encountered. After this fix the driver should builds just fine as a module and there is no behavior change when boot my devkit either since none of children under pl172 uses "simple-bus/mfd" right now. drivers/memory/pl172.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c index 3a8e57ee96f0..b2ef6072fbf4 100644 --- a/drivers/memory/pl172.c +++ b/drivers/memory/pl172.c @@ -255,8 +255,7 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id) if (ret) continue; - of_platform_populate(child_np, of_default_bus_match_table, - NULL, dev); + of_platform_populate(child_np, NULL, NULL, dev); } return 0;