| Message ID | 1438005012-16263-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 27, 2015 at 02:50:12PM +0100, Srinivas Kandagatla wrote: <snip> > sdcc3: sdcc@12180000 { > status = "okay"; > + vmmc-supply = <&pm8921_l6>; > pinctrl-names = "default"; > pinctrl-0 = <&card_detect>; > cd-gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; > @@ -187,6 +200,8 @@ > /* WLAN */ > sdcc4: sdcc@121c0000 { > status = "okay"; > + vmmc-supply = <&ext_3p3v>; Where is ext_3p3v defined? > + vqmmc-supply = <&pm8921_lvs1>;
On 27/07/15 21:32, Andy Gross wrote: > On Mon, Jul 27, 2015 at 02:50:12PM +0100, Srinivas Kandagatla wrote: > > <snip> > >> sdcc3: sdcc@12180000 { >> status = "okay"; >> + vmmc-supply = <&pm8921_l6>; >> pinctrl-names = "default"; >> pinctrl-0 = <&card_detect>; >> cd-gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; >> @@ -187,6 +200,8 @@ >> /* WLAN */ >> sdcc4: sdcc@121c0000 { >> status = "okay"; >> + vmmc-supply = <&ext_3p3v>; > > Where is ext_3p3v defined? Oops, This is missing in this patch, I think re-ordering few other patches introduced this. I will send a these 3 patches as we discussed. --srini > >> + vqmmc-supply = <&pm8921_lvs1>; >
diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts index a7c939b..cdfcf02 100644 --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts @@ -73,6 +73,12 @@ bias-pull-down; }; + pm8921_l5: l5 { + regulator-min-microvolt = <2750000>; + regulator-max-microvolt = <3000000>; + bias-pull-down; + }; + pm8921_l6: l6 { regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; @@ -84,6 +90,10 @@ regulator-max-microvolt = <1900000>; bias-pull-down; }; + + pm8921_lvs1: lvs1 { + bias-pull-down; + }; }; }; @@ -175,11 +185,14 @@ /* eMMC */ sdcc1: sdcc@12400000 { status = "okay"; + vmmc-supply = <&pm8921_l5>; + vqmmc-supply = <&pm8921_s4>; }; /* External micro SD card */ sdcc3: sdcc@12180000 { status = "okay"; + vmmc-supply = <&pm8921_l6>; pinctrl-names = "default"; pinctrl-0 = <&card_detect>; cd-gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; @@ -187,6 +200,8 @@ /* WLAN */ sdcc4: sdcc@121c0000 { status = "okay"; + vmmc-supply = <&ext_3p3v>; + vqmmc-supply = <&pm8921_lvs1>; }; }; };
This patch adds real regulators for all the three sdcc nodes. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)