diff mbox

[RFCv3,4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER

Message ID 1438305237-18497-5-git-send-email-moritz.fischer@ettus.com (mailing list archive)
State New, archived
Headers show

Commit Message

Moritz Fischer July 31, 2015, 1:13 a.m. UTC 
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
 arch/arm/mach-zynq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Michal Simek July 31, 2015, 8:09 a.m. UTC | #1 
On 07/31/2015 03:13 AM, Moritz Fischer wrote:
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  arch/arm/mach-zynq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> index 78e5e00..77d7df7 100644
> --- a/arch/arm/mach-zynq/Kconfig
> +++ b/arch/arm/mach-zynq/Kconfig
> @@ -1,5 +1,6 @@
>  config ARCH_ZYNQ
>  	bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> +	select ARCH_HAS_RESET_CONTROLLER
>  	select ARCH_SUPPORTS_BIG_ENDIAN
>  	select ARM_AMBA
>  	select ARM_GIC
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
Soren Brinkmann July 31, 2015, 4:47 p.m. UTC | #2 
On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote:
> On 07/31/2015 03:13 AM, Moritz Fischer wrote:
> > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> > ---
> >  arch/arm/mach-zynq/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> > index 78e5e00..77d7df7 100644
> > --- a/arch/arm/mach-zynq/Kconfig
> > +++ b/arch/arm/mach-zynq/Kconfig
> > @@ -1,5 +1,6 @@
> >  config ARCH_ZYNQ
> >  	bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> > +	select ARCH_HAS_RESET_CONTROLLER
> >  	select ARCH_SUPPORTS_BIG_ENDIAN
> >  	select ARM_AMBA
> >  	select ARM_GIC
> > 
> 
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

I personally, would prefer to decouple the logical outputs of the
reset-controller from the HW. But, as Moritz pointed out, that seems
rather uncommon for reset controllers. I think this is good to go.

	Thanks,
	Sören
Philipp Zabel Aug. 4, 2015, 8:38 a.m. UTC | #3 
Hi,

Am Freitag, den 31.07.2015, 09:47 -0700 schrieb Sören Brinkmann:
> On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote:
[...]
> > Reviewed-by: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

I'll assume these apply to the whole series and queue patches 1 and 3.

best regards
Philipp
Soren Brinkmann Aug. 4, 2015, 2:11 p.m. UTC | #4 
Hi Philipp,

On Tue, 2015-08-04 at 10:38AM +0200, Philipp Zabel wrote:
> Hi,
> 
> Am Freitag, den 31.07.2015, 09:47 -0700 schrieb Sören Brinkmann:
> > On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote:
> [...]
> > > Reviewed-by: Michal Simek <michal.simek@xilinx.com>
> > Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
> 
> I'll assume these apply to the whole series and queue patches 1 and 3.

For me, yes, that was meant for the whole series. Sorry, for not making
that obvious.

	Thanks,
	Sören
diff mbox

Patch

diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
index 78e5e00..77d7df7 100644
--- a/arch/arm/mach-zynq/Kconfig
+++ b/arch/arm/mach-zynq/Kconfig
@@ -1,5 +1,6 @@ 
 config ARCH_ZYNQ
 	bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
+	select ARCH_HAS_RESET_CONTROLLER
 	select ARCH_SUPPORTS_BIG_ENDIAN
 	select ARM_AMBA
 	select ARM_GIC