From patchwork Tue Aug 4 06:09:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boichat X-Patchwork-Id: 6934221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4A4D29F373 for ; Tue, 4 Aug 2015 06:12:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7A3AD20642 for ; Tue, 4 Aug 2015 06:12:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5287720638 for ; Tue, 4 Aug 2015 06:12:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZMVQv-0008CG-HZ; Tue, 04 Aug 2015 06:10:41 +0000 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZMVQo-00086l-2J for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2015 06:10:35 +0000 Received: by pawu10 with SMTP id u10so37256paw.1 for ; Mon, 03 Aug 2015 23:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2zop3sDwB50HHRKMN7LlslwssJ6LpKeor+GcPJgHpAE=; b=bFgHA7YywMX5Vpv6gbUNinqU6wHDVXmLFlb60nSrFbnO1SVG7R4Hxnde342GX9QW81 iWFe9qgJXykSSC6Q8DrlASpBiSnCQ+aQC+TawvUYs8WCfgkvEgUrDUS0ZSPcHlJT2i+M XW8dmcCwWybdfOulRViPXtgsYBJhF6eh7GOmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2zop3sDwB50HHRKMN7LlslwssJ6LpKeor+GcPJgHpAE=; b=aBXXkqzEeze5rBLb7D8at9su0US5q8jw8mUr3L5RjTxcPtvo6vVKrkdIiBXCKJxfBO 0qFwryTW41Nq5NleBVAsWl0Y+dgUDa/ZTlJWaMLbCPbgFpEUSsCNzt0i4w3jaB6KdxGa 69bqYnmeWTxC3dYBuj8mrMHwRG8jHcAuMrLkcWqOJbF3hG6Cj26KfTNruWRPRWaFmkfS YJUMoQ1iZ4XcA64JN7LP+fSkhdwV5WRcBP5tfRc9i6O943mXjfHBUS0fSp+n2HeaqC0C d1k4h955k8rDr5bwV7Yjj9X8a0kG/bN6NvBPG5N33O5wRv98ApauDdJb7x560A4vee81 0WiQ== X-Gm-Message-State: ALoCoQk53k+zGZi+KqAwzX/eDnnduC5YFGuGWoISM90DQJ88s5joQelLWHwzKfnJAl88AKj3fHWv X-Received: by 10.66.132.98 with SMTP id ot2mr4312610pab.31.1438668613077; Mon, 03 Aug 2015 23:10:13 -0700 (PDT) Received: from drinkcat.tpe.corp.google.com ([172.30.210.53]) by smtp.gmail.com with ESMTPSA id fv2sm9916456pbd.54.2015.08.03.23.10.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 23:10:12 -0700 (PDT) From: Nicolas Boichat To: Mark Brown Subject: [PATCH 2/3] spi: ppc44x: Remove chipselect from setupxfer Date: Tue, 4 Aug 2015 14:09:57 +0800 Message-Id: <1438668598-6678-2-git-send-email-drinkcat@chromium.org> X-Mailer: git-send-email 2.5.0.rc2.392.g76e840b In-Reply-To: <1438668598-6678-1-git-send-email-drinkcat@chromium.org> References: <1438668598-6678-1-git-send-email-drinkcat@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150803_231034_340114_80563619 X-CRM114-Status: GOOD ( 11.99 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The chipselect operation is already done in spi_bitbang_transfer_one, or in spi_bitbang_setup, so there is no need to do it in setupxfer as well. Signed-off-by: Nicolas Boichat --- drivers/spi/spi-ppc4xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 54fb984..55947f6 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -210,13 +210,6 @@ static int spi_ppc4xx_setupxfer(struct spi_device *spi, struct spi_transfer *t) if (in_8(&hw->regs->cdm) != cdm) out_8(&hw->regs->cdm, cdm); - spin_lock(&hw->bitbang.lock); - if (!hw->bitbang.busy) { - hw->bitbang.chipselect(spi, BITBANG_CS_INACTIVE); - /* Need to ndelay here? */ - } - spin_unlock(&hw->bitbang.lock); - return 0; }