[v5,2/5] dt/bindings: add bindings for optee

Commit Message

Jens Wiklander Aug. 19, 2015, 8:40 a.m. UTC

Introduces optee prefix and adds bindings for ARM TrustZone based OP-TEE
implementation.

Signed-off-by: Jens Wiklander <[e-mail]>
---
 Documentation/devicetree/bindings/optee/optee.txt     | 17 +++++++++++++++++
 Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
 2 files changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/optee/optee.txt

Comments

Rob Herring (Arm) Sept. 15, 2015, 10:37 p.m. UTC | #1

On 08/19/2015 03:40 AM, Jens Wiklander wrote:
> Introduces optee prefix and adds bindings for ARM TrustZone based OP-TEE
> implementation.
> 
> Signed-off-by: Jens Wiklander <[e-mail]>
> ---
>  Documentation/devicetree/bindings/optee/optee.txt     | 17 +++++++++++++++++

How about bindings/arm/firmware/... where the *other* TZ binding is located.

>  Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
>  2 files changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/optee/optee.txt
> 
> diff --git a/Documentation/devicetree/bindings/optee/optee.txt b/Documentation/devicetree/bindings/optee/optee.txt
> new file mode 100644
> index 0000000..4a6ff10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/optee/optee.txt
> @@ -0,0 +1,17 @@
> +OP-TEE Device Tree Bindings
> +
> +OP-TEE is a piece of software using hardware features to provide a Trusted
> +Execution Environment. The security can be provided with ARM TrustZone, but
> +also by virtualization or a separate chip. As there's no single OP-TEE

I don't see how the Linux side would not need to know what the
communication channel is whether it is smc, hvc, or something else.

> +vendor we're using "optee" as the first part of compatible property,
> +indicating the OP-TEE protocol is used when communicating with the secure
> +world.
> +
> +* OP-TEE based on ARM TrustZone required properties:
> +
> +- compatible="optee,optee-tz"
> +
> +Example:
> +	optee {
> +		compatible="optee,optee-tz";
> +	};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 8033919..17c2a7e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -141,6 +141,7 @@ nvidia	NVIDIA
>  nxp	NXP Semiconductors
>  onnn	ON Semiconductor Corp.
>  opencores	OpenCores.org
> +optee	OP-TEE, Open Portable Trusted Execution Environment
>  ortustech	Ortus Technology Co., Ltd.
>  ovti	OmniVision Technologies
>  panasonic	Panasonic Corporation
>

Jens Wiklander Sept. 16, 2015, 7:13 a.m. UTC | #2

On Tue, Sep 15, 2015 at 05:37:07PM -0500, Rob Herring wrote:
> On 08/19/2015 03:40 AM, Jens Wiklander wrote:
> > Introduces optee prefix and adds bindings for ARM TrustZone based OP-TEE
> > implementation.
> > 
> > Signed-off-by: Jens Wiklander <[e-mail]>
> > ---
> >  Documentation/devicetree/bindings/optee/optee.txt     | 17 +++++++++++++++++
> 
> How about bindings/arm/firmware/... where the *other* TZ binding is located.

OK, I'll move it.

> 
> >  Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
> >  2 files changed, 18 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/optee/optee.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/optee/optee.txt b/Documentation/devicetree/bindings/optee/optee.txt
> > new file mode 100644
> > index 0000000..4a6ff10
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/optee/optee.txt
> > @@ -0,0 +1,17 @@
> > +OP-TEE Device Tree Bindings
> > +
> > +OP-TEE is a piece of software using hardware features to provide a Trusted
> > +Execution Environment. The security can be provided with ARM TrustZone, but
> > +also by virtualization or a separate chip. As there's no single OP-TEE
> 
> I don't see how the Linux side would not need to know what the
> communication channel is whether it is smc, hvc, or something else.

I assume you're missing something similar to the "method" property
defined for PSCI. I'll add that.

> 
> > +vendor we're using "optee" as the first part of compatible property,
> > +indicating the OP-TEE protocol is used when communicating with the secure
> > +world.
> > +
> > +* OP-TEE based on ARM TrustZone required properties:
> > +
> > +- compatible="optee,optee-tz"
> > +
> > +Example:
> > +	optee {
> > +		compatible="optee,optee-tz";
> > +	};
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 8033919..17c2a7e 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -141,6 +141,7 @@ nvidia	NVIDIA
> >  nxp	NXP Semiconductors
> >  onnn	ON Semiconductor Corp.
> >  opencores	OpenCores.org
> > +optee	OP-TEE, Open Portable Trusted Execution Environment
> >  ortustech	Ortus Technology Co., Ltd.
> >  ovti	OmniVision Technologies
> >  panasonic	Panasonic Corporation
> > 
> 

Thanks,
Jens

Patch

diff --git a/Documentation/devicetree/bindings/optee/optee.txt b/Documentation/devicetree/bindings/optee/optee.txt
new file mode 100644
index 0000000..4a6ff10
--- /dev/null
+++ b/Documentation/devicetree/bindings/optee/optee.txt
@@ -0,0 +1,17 @@ 
+OP-TEE Device Tree Bindings
+
+OP-TEE is a piece of software using hardware features to provide a Trusted
+Execution Environment. The security can be provided with ARM TrustZone, but
+also by virtualization or a separate chip. As there's no single OP-TEE
+vendor we're using "optee" as the first part of compatible property,
+indicating the OP-TEE protocol is used when communicating with the secure
+world.
+
+* OP-TEE based on ARM TrustZone required properties:
+
+- compatible="optee,optee-tz"
+
+Example:
+	optee {
+		compatible="optee,optee-tz";
+	};
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 8033919..17c2a7e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -141,6 +141,7 @@  nvidia	NVIDIA
 nxp	NXP Semiconductors
 onnn	ON Semiconductor Corp.
 opencores	OpenCores.org
+optee	OP-TEE, Open Portable Trusted Execution Environment
 ortustech	Ortus Technology Co., Ltd.
 ovti	OmniVision Technologies
 panasonic	Panasonic Corporation