| Message ID | 1441349872-4560-4-git-send-email-bhupesh.sharma@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 4, 2015 at 1:57 AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: > This patch adds bindings for QIXIS FPGA controller found on FSL boards. A general comment: when you are updating the device tree bindings. You should cc the devicetree@vger.kernel.org mailing list. > > Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD > connected to the IFC controller. The bindings specified in this patch > cater to those on-board FPGA/CPLD controllers. We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location. Regards, Leo
> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > Sent: Friday, September 04, 2015 10:27 PM > On Fri, Sep 4, 2015 at 1:57 AM, Bhupesh Sharma > <bhupesh.sharma@freescale.com> wrote: > > This patch adds bindings for QIXIS FPGA controller found on FSL boards. > > A general comment: when you are updating the device tree bindings. > You should cc the devicetree@vger.kernel.org mailing list. > > > > > Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board > > FPGA/CPLD connected to the IFC controller. The bindings specified in > > this patch cater to those on-board FPGA/CPLD controllers. > > We already have the binding defined in > Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably > should just move it to a more generic location. Consolidation of powerpc and ARM bindings is something that needs to be targeted by a separate patch-series, perhaps in future. There are a number of duplications that can be looked into, but I don't think this patchset should depend on that. Regards, Bhupesh
On Fri, Sep 4, 2015 at 3:16 PM, Sharma Bhupesh <bhupesh.sharma@freescale.com> wrote: >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] >> Sent: Friday, September 04, 2015 10:27 PM >> On Fri, Sep 4, 2015 at 1:57 AM, Bhupesh Sharma >> <bhupesh.sharma@freescale.com> wrote: >> > This patch adds bindings for QIXIS FPGA controller found on FSL boards. >> >> A general comment: when you are updating the device tree bindings. >> You should cc the devicetree@vger.kernel.org mailing list. >> >> > >> > Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board >> > FPGA/CPLD connected to the IFC controller. The bindings specified in >> > this patch cater to those on-board FPGA/CPLD controllers. >> >> We already have the binding defined in >> Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably >> should just move it to a more generic location. > > Consolidation of powerpc and ARM bindings is something that needs to be > targeted by a separate patch-series, perhaps in future. > > There are a number of duplications that can be looked into, but I don't > think this patchset should depend on that. There might be some duplication, but we shouldn't be adding more. :) I would rather you directly updating that file than creating a new file even though the original one was in a wrong directory. Regards, Leo
> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > Sent: Saturday, September 05, 2015 2:43 AM > On Fri, Sep 4, 2015 at 3:16 PM, Sharma Bhupesh > <bhupesh.sharma@freescale.com> wrote: > >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > >> Sent: Friday, September 04, 2015 10:27 PM On Fri, Sep 4, 2015 at 1:57 > >> AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: > >> > This patch adds bindings for QIXIS FPGA controller found on FSL > boards. > >> > >> A general comment: when you are updating the device tree bindings. > >> You should cc the devicetree@vger.kernel.org mailing list. > >> > >> > > >> > Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board > >> > FPGA/CPLD connected to the IFC controller. The bindings specified > >> > in this patch cater to those on-board FPGA/CPLD controllers. > >> > >> We already have the binding defined in > >> Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably > >> should just move it to a more generic location. > > > > Consolidation of powerpc and ARM bindings is something that needs to > > be targeted by a separate patch-series, perhaps in future. > > > > There are a number of duplications that can be looked into, but I > > don't think this patchset should depend on that. > > There might be some duplication, but we shouldn't be adding more. :) I > would rather you directly updating that file than creating a new file > even though the original one was in a wrong directory. > IMO a PowerPC binding update makes no sense in a ARM machine patchset sent on a arm specific mailing list. I would like to wait to hear what maintainers have to say on the same. Regards, Bhupesh
On Sat, Sep 5, 2015 at 3:11 AM, Sharma Bhupesh <bhupesh.sharma@freescale.com> wrote: >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] >> Sent: Saturday, September 05, 2015 2:43 AM >> On Fri, Sep 4, 2015 at 3:16 PM, Sharma Bhupesh >> <bhupesh.sharma@freescale.com> wrote: >> >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] >> >> Sent: Friday, September 04, 2015 10:27 PM On Fri, Sep 4, 2015 at 1:57 >> >> AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: >> >> > This patch adds bindings for QIXIS FPGA controller found on FSL >> boards. >> >> >> >> A general comment: when you are updating the device tree bindings. >> >> You should cc the devicetree@vger.kernel.org mailing list. >> >> >> >> > >> >> > Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board >> >> > FPGA/CPLD connected to the IFC controller. The bindings specified >> >> > in this patch cater to those on-board FPGA/CPLD controllers. >> >> >> >> We already have the binding defined in >> >> Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably >> >> should just move it to a more generic location. >> > >> > Consolidation of powerpc and ARM bindings is something that needs to >> > be targeted by a separate patch-series, perhaps in future. >> > >> > There are a number of duplications that can be looked into, but I >> > don't think this patchset should depend on that. >> >> There might be some duplication, but we shouldn't be adding more. :) I >> would rather you directly updating that file than creating a new file >> even though the original one was in a wrong directory. >> > > IMO a PowerPC binding update makes no sense in a ARM machine patchset sent > on a arm specific mailing list. So the best approach is to merge the change with the original binding and put it into a common place. Although there were a lot of non-arch specific bindings placed into the arch folder, we should stop adding more now. Regards, Leo
diff --git a/Documentation/devicetree/bindings/arm/fsl,board.txt b/Documentation/devicetree/bindings/arm/fsl,board.txt new file mode 100644 index 0000000..756b730 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/fsl,board.txt @@ -0,0 +1,31 @@ +Freescale Reference Board Bindings +---------------------------------- + +This document describes device tree bindings for various devices that +exist on some Freescale reference boards. + +* Freescale on-board FPGA connected to IFC controller + +Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD +connected to the IFC controller. + +Required properties: +- compatible: Should be a board-specific string followed by a string + indicating the type of FPGA. Example: + "fsl,ls2080a-qds-qixis", "fsl,fpga-qixis" + "fsl,ls2080a-rdb-qixis", "fsl,fpga-qixis" +- reg: The register set for the device + +Example: + &ifc { + status = "okay"; + #address-cells = <2>; + #size-cells <1>; + ranges = <0x3 0x0 0x5 0x20000000 0x00010000>; + + cpld@3,0 { + compatible = "fsl,ls2080a-qds-qixis", "fsl,fpga-qixis"; + reg = <0x3 0 0x10000>; + }; + }; +