| Message ID | 1442554881-706-1-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jisheng Zhang <jszhang@marvell.com> writes: > The cpuidle tracepoints are called within a rcu_idle_exit() section, and > must be denoted with the _rcuidle() version of the tracepoint. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Acked-by: Kevin Hilman <khilman@linaro.org>
* Kevin Hilman <khilman@kernel.org> [150923 11:03]: > Jisheng Zhang <jszhang@marvell.com> writes: > > > The cpuidle tracepoints are called within a rcu_idle_exit() section, and > > must be denoted with the _rcuidle() version of the tracepoint. > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > Acked-by: Kevin Hilman <khilman@linaro.org> Hmm is this needed as a fix for the -rc cycle or can this wait for v4.4? Regards, Tony
Dear Tony, On Wed, 23 Sep 2015 11:08:15 -0700 Tony Lindgren <tony@atomide.com> wrote: > * Kevin Hilman <khilman@kernel.org> [150923 11:03]: > > Jisheng Zhang <jszhang@marvell.com> writes: > > > > > The cpuidle tracepoints are called within a rcu_idle_exit() section, and > > > must be denoted with the _rcuidle() version of the tracepoint. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > > > Acked-by: Kevin Hilman <khilman@linaro.org> > > Hmm is this needed as a fix for the -rc cycle or can this wait > for v4.4? IMHO, this is a fix. But it can wait for v4.4 merge window. Thanks, Jisheng
* Jisheng Zhang <jszhang@marvell.com> [150923 20:26]: > Dear Tony, > > On Wed, 23 Sep 2015 11:08:15 -0700 > Tony Lindgren <tony@atomide.com> wrote: > > > * Kevin Hilman <khilman@kernel.org> [150923 11:03]: > > > Jisheng Zhang <jszhang@marvell.com> writes: > > > > > > > The cpuidle tracepoints are called within a rcu_idle_exit() section, and > > > > must be denoted with the _rcuidle() version of the tracepoint. > > > > > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > > > > > Acked-by: Kevin Hilman <khilman@linaro.org> > > > > Hmm is this needed as a fix for the -rc cycle or can this wait > > for v4.4? > > IMHO, this is a fix. But it can wait for v4.4 merge window. Applying into omap-for-v4.4/fixes thanks. Tony
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 87b98bf9..2dbd378 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -301,11 +301,11 @@ static void omap3_pm_idle(void) if (omap_irq_pending()) return; - trace_cpu_idle(1, smp_processor_id()); + trace_cpu_idle_rcuidle(1, smp_processor_id()); omap_sram_idle(); - trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id()); + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id()); } #ifdef CONFIG_SUSPEND
The cpuidle tracepoints are called within a rcu_idle_exit() section, and must be denoted with the _rcuidle() version of the tracepoint. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- arch/arm/mach-omap2/pm34xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)