From patchwork Wed Sep 30 02:25:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 7292301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CE5519F302 for ; Wed, 30 Sep 2015 02:29:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EDC7720645 for ; Wed, 30 Sep 2015 02:29:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A0DD204B5 for ; Wed, 30 Sep 2015 02:29:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zh77e-0006ag-VB; Wed, 30 Sep 2015 02:27:58 +0000 Received: from mail-bn1bon0116.outbound.protection.outlook.com ([157.56.111.116] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zh769-0005wi-JB for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2015 02:26:27 +0000 Received: from BY2PR03CA008.namprd03.prod.outlook.com (10.255.93.25) by BY1PR0301MB0855.namprd03.prod.outlook.com (10.160.193.149) with Microsoft SMTP Server (TLS) id 15.1.274.16; Wed, 30 Sep 2015 02:26:03 +0000 Received: from BN1BFFO11FD032.protection.gbl (10.255.93.4) by BY2PR03CA008.outlook.office365.com (10.255.93.25) with Microsoft SMTP Server (TLS) id 15.1.274.16 via Frontend Transport; Wed, 30 Sep 2015 02:26:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD032.mail.protection.outlook.com (10.58.144.95) with Microsoft SMTP Server (TLS) id 15.1.274.4 via Frontend Transport; Wed, 30 Sep 2015 02:26:02 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id t8U2Pq2l017073; Tue, 29 Sep 2015 19:25:59 -0700 From: Peter Chen To: Subject: [RESEND PATCH v3 2/5] ARM: dts: imx27.dtsi: change the clock information for usb Date: Wed, 30 Sep 2015 10:25:22 +0800 Message-ID: <1443579925-1330-3-git-send-email-peter.chen@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443579925-1330-1-git-send-email-peter.chen@freescale.com> References: <1443579925-1330-1-git-send-email-peter.chen@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD032; 1:nhG8DZGYP6nwmAW2g0AS8VJUxcPk4795m8ujgZDyWJCVxHuuDEoBCi30T/L0bLZMjimlMc4yAtD2rPbeMbhsnYH1fSIp8fHYnXqLasaS9VQUr9qPNnVwEdalKmZ9hJ8//m74DJz5UarTe3ZNBdrqWEHl5eJSNmdTg2LuRjkZ/eKTU/HDhWJHbZ0WgsdWUzx1g2dpFDCJ7BRclrBK14IaYjLTNMY8JldrrgKQ8YJ6dl7mwiDQU5VGQyOqJz6wgqGHPSHS6AathGxiL7UBi5pqbfSkIH0Ik3ZwLB1yQVWQr3ma3TOb++9288jN966HXjuJ99m8lMXDW5a62dGjt09oRG/ESQEAAtoxYWbF/cYndfzQVDbHWLLcXdm5UabMLnvDJFA37d61W99H4tgIcViEzSKaCns9nPWiPS54LYpVeM8= X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(6806005)(50466002)(104016004)(5003940100001)(46102003)(48376002)(77096005)(5008740100001)(47776003)(2351001)(229853001)(5001830100001)(5001860100001)(64706001)(68736005)(110136002)(50986999)(76176999)(36756003)(5001960100002)(92566002)(106466001)(189998001)(5007970100001)(62966003)(11100500001)(77156002)(50226001)(19580405001)(87936001)(19580395003)(85426001)(81156007)(86362001)(105606002)(4001540100001)(97736004)(33646002)(2950100001)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0301MB0855; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB0855; 2:cymkEQcGF88WWVd+VXIDjQ8t/WUYTtdVzxhSyuAH1criO6o5blhSVGMHhSoYNcENTtFVFi11wUudpVI6H2nztlPS6Jt1D6tbNQeAdydeJ15WgWE29WWdbcc7qH3bCYrihnLK73LC01h853g07HRf9C++GsqBII7pmYr9nC95q9A=; 3:I5e3C6E81EBaqAzUS9Lzb60nJxC72WqNJ/A6HyMJL9NPP4F8zO+ft2hg7l6VCpZdKLmS0MSPuVHA0h1LcjaxyNvb/22//sOwcEtOwaKBQpPsOhzE0iw1tXmneRV7jtu5DA0lTx6yqWJuNZMPQe3cxDdptKR54/mD0UgIOMJwbJHc6o7XLGTZL0imDcJaJbOTWkayKeen9cmdTXb63NrjU/8JbCkQAO6HPiKAVN0M1Hg=; 25:AJh1+vJvkBHo7OyuqoUbpv6IafnShnvhH7xlmySRxvfiMF1Fi8VYaoK8W/3bMGI2qTlB56rr8RsQLZrqSRVylgHntRY8+/uut8+GNyHlLASDxBzUahNmXY8L1NXeyQ/AqOHw9LHH46F7Bk48iNTD5aIO+TKZFlKyryobDrPPUnZnxbkzXqPRhXOxivJcBJuDp3HtBPZWIQ7rSpQ6apA7rsG1ukzkc9b5c4xPr6lBVj8AwI4EisGkK4pKvyRxhJcVohyfYDO7AqoAUarhv9KGLA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB0855; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB0855; 20:Dc66qyfSuxgwE1n8DzdmNVPmHWici8/h9AMe85erqhvn0uGjYW2s/i9M7HcYMFioHfroVMuTaszHSYTCNUInbJTjFLn8WkMyY9a/UtGh6c2NNyk53K5JEb+t8Y+DU6mP67DqId5wuwJckSQhOS9sFy7/rSLSK9/Vdh0dLMANzHSEzRulMQ0xwh/oMS6qqOoyz6SlrHJGvO7HDRwJSjJoL1G0OtR/Uyd6rZHwYkztw3DWhbKdPD8S2YEV7WDLsRQV253Q5kjztesdwXQ427s7I7UtE7awrQa1OtyQRgDPRrC1WFgwu3y1vqRIJAQzPzhmiPG+8KMiFlAOdblkv2gGF4chFTgOwrjzI1oAwikW2Fg=; 4:Iwib+l+x8Y9Tz733RaV3ZeC9LBJ92ULX88Ov7YDMwC2tjL2xMo1lkxPrNt3C8aAY4ilKFatOZr3L1zpsSJB2u7UYKu90Egz59nzhH0A6CXJHXRNkyRLSuQXnmq1tVPyeSHS44bHCT+Ya5o2yFH7j9FGuMvXtMeoqKDCuQh/bkA6MeK3/2xzv7C6clKW1/dCy+1fXfSVGNfj1GgIxOoAsohoD+7A4kvbrplB7Id6WqWVAIymwDpvqOjhoJfDfV/WG7LVt8ufPdKPlKGz2MD1zQx//H+IXhaV5APDQ/VNK/G02FCAv79rSdhgDygxArvRBIMoDv1q/udkNNChzovmKFxVPHvwGAl1aiB16QP+4arc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001); SRVR:BY1PR0301MB0855; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0301MB0855; X-Forefront-PRVS: 071518EF63 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0301MB0855; 23:uO/dQkAxm9CAumPuKkGEo90Sw6LuNiTR0ROD+n7?= =?us-ascii?Q?FecjkyVHE6i7BsQjMFKrSRnOLNDJ34B3kVEyRqIOUQlxBXsfr2W6IztPFyHj?= =?us-ascii?Q?5vJdNIxKg0E666SHpJbX8Mo7i9J9avXDZpQhqnkyIQKTh8xzWVLMepY+aq+C?= =?us-ascii?Q?6BLKu4rEHjGm3/Pfy3eQ1XrpHChZIkr3mio7lAlJdhsBhRT3o430omM+mu/D?= =?us-ascii?Q?CtWV9cFTPWehdtFQ1thjUVD5DhwIj912d+19OExs4I/QgSzWG/Ojfke084/b?= =?us-ascii?Q?9tzhw1v3S4OY/onDQxQ6LxehSVDoFgAJ6lkgMQUEtL/ayEJKh2Bv2WA2PMQr?= =?us-ascii?Q?NEnbXD4LdptvlcjXC94jQg1FYT5Z5C534QiXuDZ7sFBukqaveQkqlgMdsg7f?= =?us-ascii?Q?geIY8SZ2nr5r8UPPZtwwD5R8ZdYyk7SefgY6oUOyI8d9Zeh+Zqn/IUTBqcVB?= =?us-ascii?Q?7qZKjEySeeiDn7fkfnNYrTcqySkz2eKQ91LT7ZJQ/HDKdjwihkd7en2l+OPG?= =?us-ascii?Q?qUMpIDadfTJc9HOx+SOv/PKpPM4rmMxgdMS17lA6cRKzuyXlyxvLWOBwnRcP?= =?us-ascii?Q?xMoEPfMZRKI8/2jwQg0qBJveKRuGVwM9UxKg7tQXIg+3dku5UqLxuOWohKo/?= =?us-ascii?Q?gc1hRTsqNIa1fuXrYLDMI6i6x3PbKETavUO71OrP0rHcqJkLcZDHbXR0XhGs?= =?us-ascii?Q?qTkx6R05YuJE3LugaR97S3F2f4npsYoWNZsuPG2kJBXFRiPpX5LQpCrbvm1G?= =?us-ascii?Q?5k9q2JfELtnHFjJhxFDnNK7slgVvrP1eXz1Knq5SGU1mNwaQTpedmvQ7mbFO?= =?us-ascii?Q?Hv6ZPpDQI9lk4GBAh25L4CxYxyRNqGxTEGv1enQYWV6q+ByK2BgrsVN/7mCr?= =?us-ascii?Q?lsQSWMPiwgowZzbPu9ZyMgbksfiho5uzz0JVMKz9DLqGfWl9YGNkMlNtnAxV?= =?us-ascii?Q?B2Uwvyq21ReZMaKzSNxQJTyrI29OWfvZmxl04WeEJ++BivHGhjAoGw6gd7ma?= =?us-ascii?Q?jp9mLSnnNcT1Tfw3p+tr/FXV7zDoS6pZVSR3QtH872hcOAcSeDl78aFZ7mIU?= =?us-ascii?Q?q9/ZTHDN+dcgRz49a9SqGEXjNWnFI+jsPQk2rfYVSlzaqIv3Yyj/se/7jevT?= =?us-ascii?Q?Bte8lnWA6t4vi0fJPbFEoLl1sVptcM1c2xqVv/7U5H3COA5NEO8Kd+Q8fLgV?= =?us-ascii?Q?IzUgfJLLyQBz4bDuEbNnqoJJyayxG4qRuR3vrWSjjZHrQ32wA0gCj15Mg5TR?= =?us-ascii?Q?jzCH/pjedVONBi11ZeJ7OETfacRYYiEejpMthFAeC?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB0855; 5:bWXQdxCHQ27r0dycEHQwc8RhEudIvj4MDJZE5F8YHmDGdLEVrRJu1N4z6B+rhAB4zKIuisrRWGtSNJxtcbkk8UHTokIBnKViP0e4tamdX9gI7byVG4Gjd8p289X0Jlf/mO3G1haBjtnatGeX+uS20Q==; 24:YgN4hIjKtq5YEcL44tiSoX5tSp7BgqpvYpT9C05JrU5a70rUnXqP5tHoZslekasQoI5Nc+TW6eoc3+N1iwQZaQw/bjXe4IzLETgMpMXXw/4=; 20:FAk40Q64VeWuVZOtnGWLmImY+cbs09Ir0D9Bio/caIknEPYCBIAXkqsE8ZqJ5nbTiREYEqdMLNQ3hwKdeHb6Qg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2015 02:26:02.2809 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB0855 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150929_192626_401307_DB6BE666 X-CRM114-Status: GOOD ( 19.93 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, pawel.moll@arm.com, stable@vger.kernel.org, robh+dt@kernel.org, Peter Chen , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For imx27, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more. Without this patch, it will cause below data abort when accessing usbmisc registers. usbcore: registered new interface driver usb-storage Unhandled fault: external abort on non-linefetch (0x008) at 0xf4424600 pgd = c0004000 [f4424600] *pgd=10000452(bad) Internal error: : 8 [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper Not tainted 4.1.0-next-20150701-dirty #3089 Hardware name: Freescale i.MX27 (Device Tree Support) task: c7832b60 ti: c783e000 task.ti: c783e000 PC is at usbmisc_imx27_init+0x4c/0xbc LR is at usbmisc_imx27_init+0x40/0xbc pc : [] lr : [] psr: 60000093 sp : c783fe08 ip : 00000000 fp : 00000000 r10: c0576434 r9 : 0000009c r8 : c7a773a0 r7 : 01000000 r6 : 60000013 r5 : c7a776f0 r4 : c7a773f0 r3 : f4424600 r2 : 00000000 r1 : 00000001 r0 : 00000001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 00000017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc7840000) Signed-off-by: Peter Chen Reported-by: Fabio Estevam Tested-by: Fabio Estevam Cc: #v4.1+ --- arch/arm/boot/dts/imx27.dtsi | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index feb9d34..f818ea4 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -486,7 +486,10 @@ compatible = "fsl,imx27-usb"; reg = <0x10024000 0x200>; interrupts = <56>; - clocks = <&clks IMX27_CLK_USB_IPG_GATE>; + clocks = <&clks IMX27_CLK_USB_IPG_GATE>, + <&clks IMX27_CLK_USB_AHB_GATE>, + <&clks IMX27_CLK_USB_DIV>; + clock-names = "ipg", "ahb", "per"; fsl,usbmisc = <&usbmisc 0>; status = "disabled"; }; @@ -495,7 +498,10 @@ compatible = "fsl,imx27-usb"; reg = <0x10024200 0x200>; interrupts = <54>; - clocks = <&clks IMX27_CLK_USB_IPG_GATE>; + clocks = <&clks IMX27_CLK_USB_IPG_GATE>, + <&clks IMX27_CLK_USB_AHB_GATE>, + <&clks IMX27_CLK_USB_DIV>; + clock-names = "ipg", "ahb", "per"; fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; status = "disabled"; @@ -505,7 +511,10 @@ compatible = "fsl,imx27-usb"; reg = <0x10024400 0x200>; interrupts = <55>; - clocks = <&clks IMX27_CLK_USB_IPG_GATE>; + clocks = <&clks IMX27_CLK_USB_IPG_GATE>, + <&clks IMX27_CLK_USB_AHB_GATE>, + <&clks IMX27_CLK_USB_DIV>; + clock-names = "ipg", "ahb", "per"; fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; status = "disabled"; @@ -515,7 +524,6 @@ #index-cells = <1>; compatible = "fsl,imx27-usbmisc"; reg = <0x10024600 0x200>; - clocks = <&clks IMX27_CLK_USB_AHB_GATE>; }; sahara2: sahara@10025000 {