diff mbox

[v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver

Message ID 1443796077-24722-1-git-send-email-luisbg@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Luis de Bethencourt Oct. 2, 2015, 2:27 p.m. UTC 
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---

Hello,

Sending a second version to add Rafael Wysocki in the to-list as
suggested by Heiko Stübner.
https://lkml.org/lkml/2015/10/2/431

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/power/avs/rockchip-io-domain.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kevin Hilman Oct. 12, 2015, 6:25 p.m. UTC | #1 
Luis de Bethencourt <luisbg@osg.samsung.com> writes:

> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Kevin Hilman <khilman@linaro.org>

Rafael, feel free to apply directly.

Kevin
Rafael J. Wysocki Oct. 15, 2015, 12:35 a.m. UTC | #2 
On Monday, October 12, 2015 11:25:54 AM Kevin Hilman wrote:
> Luis de Bethencourt <luisbg@osg.samsung.com> writes:
> 
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> Acked-by: Kevin Hilman <khilman@linaro.org>
> 
> Rafael, feel free to apply directly.

Done.

Thanks,
Rafael
diff mbox

Patch

diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 2e30002..8099456 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -271,6 +271,7 @@  static const struct of_device_id rockchip_iodomain_match[] = {
 	},
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
 
 static int rockchip_iodomain_probe(struct platform_device *pdev)
 {