| Message ID | 1444684386-17094-28-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts b/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts index fa02a9aff05e..8d155295d528 100644 --- a/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts +++ b/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts @@ -75,7 +75,7 @@ enable-active-high; regulator-always-on; regulator-boot-on; - gpio = <&gpio0 24 GPIO_ACTIVE_LOW>; + gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>; }; sata1_power: regulator@2 { @@ -87,7 +87,7 @@ enable-active-high; regulator-always-on; regulator-boot-on; - gpio = <&gpio0 28 GPIO_ACTIVE_LOW>; + gpio = <&gpio0 28 GPIO_ACTIVE_HIGH>; }; }; };
The enable GPIOs are active high, but are flagged as active low in the gpio properties. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@free-electrons.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>