diff mbox

[v2] ARM: socfpga: dts: add fpga manager

Message ID 1444765139-2040-1-git-send-email-atull@opensource.altera.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alan Tull Oct. 13, 2015, 7:38 p.m. UTC
From: Alan Tull <atull@opensource.altera.com>

Add FPGA manager to device tree for SoCFPGA.

Signed-off-by: Alan Tull <atull@opensource.altera.com>
---
v2: Remove 0x after @
    No caps in hex numbers
    renamed hps_0_fpgamgr to fpgamgr0
    move node to be in alpha order by node name
---
 arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

dinguyen@opensource.altera.com Oct. 13, 2015, 7:51 p.m. UTC | #1
On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:

> From: Alan Tull <atull@opensource.altera.com>
> 
> Add FPGA manager to device tree for SoCFPGA.
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
> v2: Remove 0x after @
>     No caps in hex numbers
>     renamed hps_0_fpgamgr to fpgamgr0
>     move node to be in alpha order by node name
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Applied!

Thanks,
Dinh
Steffen Trumtrar Oct. 13, 2015, 8:33 p.m. UTC | #2
On Tue, Oct 13, 2015 at 02:51:28PM -0500, Dinh Nguyen wrote:
> On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:
> 
> > From: Alan Tull <atull@opensource.altera.com>
> > 
> > Add FPGA manager to device tree for SoCFPGA.
> > 
> > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > ---
> > v2: Remove 0x after @
> >     No caps in hex numbers
> >     renamed hps_0_fpgamgr to fpgamgr0
> >     move node to be in alpha order by node name
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> 
> Applied!

What about the

"Also, you need to document the "altr,socfpga-fpga-mgr"."

you mentioned in v1 ???

Regards,
Steffen
dinguyen@opensource.altera.com Oct. 13, 2015, 9:16 p.m. UTC | #3
On Tue, 13 Oct 2015, Steffen Trumtrar wrote:

> On Tue, Oct 13, 2015 at 02:51:28PM -0500, Dinh Nguyen wrote:
> > On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:
> > 
> > > From: Alan Tull <atull@opensource.altera.com>
> > > 
> > > Add FPGA manager to device tree for SoCFPGA.
> > > 
> > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > ---
> > > v2: Remove 0x after @
> > >     No caps in hex numbers
> > >     renamed hps_0_fpgamgr to fpgamgr0
> > >     move node to be in alpha order by node name
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > 
> > Applied!
> 
> What about the
> 
> "Also, you need to document the "altr,socfpga-fpga-mgr"."
> 
> you mentioned in v1 ???
>

It was my oversight. It has already been documented. 

BR,
Dinh
diff mbox

Patch

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 314e589..0f50ae8 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -513,6 +513,13 @@ 
 				};
 		};
 
+		fpgamgr0: fpgamgr@ff706000 {
+			compatible = "altr,socfpga-fpga-mgr";
+			reg = <0xff706000 0x1000
+			       0xffb90000 0x1000>;
+			interrupts = <0 175 4>;
+		};
+
 		gmac0: ethernet@ff700000 {
 			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.70a", "snps,dwmac";
 			altr,sysmgr-syscon = <&sysmgr 0x60 0>;