| Message ID | 1445339807-2351-4-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Jisheng Zhang (2015-10-20 04:16:46) > Since we have added the necessary two clks' properties in dts, we can > remove the "sdio" clk's CLK_IGNORE_UNUSED flag now. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Applied to clk-next. Regards, Mike > --- > drivers/clk/berlin/bg2q.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c > index 221f40c..243f421 100644 > --- a/drivers/clk/berlin/bg2q.c > +++ b/drivers/clk/berlin/bg2q.c > @@ -283,7 +283,7 @@ static const struct berlin2_gate_data bg2q_gates[] __initconst = { > { "usb2", "perif", 13 }, > { "usb3", "perif", 14 }, > { "pbridge", "perif", 15, CLK_IGNORE_UNUSED }, > - { "sdio", "perif", 16, CLK_IGNORE_UNUSED }, > + { "sdio", "perif", 16 }, > { "nfc", "perif", 18 }, > { "pcie", "perif", 22 }, > }; > -- > 2.6.1 >
Quoting Michael Turquette (2015-10-21 02:30:39) > Quoting Jisheng Zhang (2015-10-20 04:16:46) > > Since we have added the necessary two clks' properties in dts, we can > > remove the "sdio" clk's CLK_IGNORE_UNUSED flag now. > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > Applied to clk-next. So the sdhci change was dropped from v2. Do you want me to Ack these instead so you can send them all together? Regards, Mike > > Regards, > Mike > > > --- > > drivers/clk/berlin/bg2q.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c > > index 221f40c..243f421 100644 > > --- a/drivers/clk/berlin/bg2q.c > > +++ b/drivers/clk/berlin/bg2q.c > > @@ -283,7 +283,7 @@ static const struct berlin2_gate_data bg2q_gates[] __initconst = { > > { "usb2", "perif", 13 }, > > { "usb3", "perif", 14 }, > > { "pbridge", "perif", 15, CLK_IGNORE_UNUSED }, > > - { "sdio", "perif", 16, CLK_IGNORE_UNUSED }, > > + { "sdio", "perif", 16 }, > > { "nfc", "perif", 18 }, > > { "pcie", "perif", 22 }, > > }; > > -- > > 2.6.1 > >
Dear Michael, On Wed, 21 Oct 2015 02:54:54 -0700 Michael Turquette <mturquette@baylibre.com> wrote: > Quoting Michael Turquette (2015-10-21 02:30:39) > > Quoting Jisheng Zhang (2015-10-20 04:16:46) > > > Since we have added the necessary two clks' properties in dts, we can > > > remove the "sdio" clk's CLK_IGNORE_UNUSED flag now. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > > > Applied to clk-next. > > So the sdhci change was dropped from v2. Do you want me to Ack these > instead so you can send them all together? I'll send another patch to for the sdhci change. it doesn't matter even the sdhci change delay a merge window because no functionality changes in the sdhci commit. It's better we firstly take these clk clean ups because it saves power a bit and clean up the CLK_IGNORE_UNUSED flag. Hi Sebastian, What do you think? Thanks, Jisheng
diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c index 221f40c..243f421 100644 --- a/drivers/clk/berlin/bg2q.c +++ b/drivers/clk/berlin/bg2q.c @@ -283,7 +283,7 @@ static const struct berlin2_gate_data bg2q_gates[] __initconst = { { "usb2", "perif", 13 }, { "usb3", "perif", 14 }, { "pbridge", "perif", 15, CLK_IGNORE_UNUSED }, - { "sdio", "perif", 16, CLK_IGNORE_UNUSED }, + { "sdio", "perif", 16 }, { "nfc", "perif", 18 }, { "pcie", "perif", 22 }, };
Since we have added the necessary two clks' properties in dts, we can remove the "sdio" clk's CLK_IGNORE_UNUSED flag now. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/clk/berlin/bg2q.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)