From patchwork Thu Oct 22 02:30:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 7462031 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9B0469F1C3 for ; Thu, 22 Oct 2015 02:33:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AF6D020694 for ; Thu, 22 Oct 2015 02:33:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1ED1208C2 for ; Thu, 22 Oct 2015 02:33:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zp5fZ-0003aB-Jx; Thu, 22 Oct 2015 02:31:57 +0000 Received: from mail-pa0-f67.google.com ([209.85.220.67]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zp5fK-0003UV-Sd; Thu, 22 Oct 2015 02:31:44 +0000 Received: by pacik9 with SMTP id ik9so7591686pac.3; Wed, 21 Oct 2015 19:31:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1BYkS2xpmeMyMNd+6xAEdeEwq7GG+rttSdBdJpU0E+8=; b=h1mAHl2S+ucK8cjeb3eS+Y9+cspypV3uw8kCKAsMd5yLpNXsGySHKXS/sP91eYUOyW RwpnZ6+eCEpguSpPXaCMN8kR/+PoSoNCe0TpJwPwNuicr+Ak7bEgN7jC3e6Aoaxga0QM yQ4ngd3RsoLOqKKndIJSgw6w6qfpp08I2rpSGxYwu0zOHwCq58ld+rY19W6uNg3t+rXv kwP1XXhce6MnQLicNdhbbR2b9ubcl4VnC2XPeUGyAq3IlSYDh8vyQOak21Hw6wRETveJ Yu/QLxh9A59nHl+ZBUV7+4qenobnKZje9ztrKHqdzQXqWSkQMdu0XU1jSGJtdGAfuMNa 8bsg== X-Received: by 10.68.179.33 with SMTP id dd1mr14437550pbc.134.1445481086561; Wed, 21 Oct 2015 19:31:26 -0700 (PDT) Received: from localhost.localdomain ([103.47.144.30]) by smtp.gmail.com with ESMTPSA id sz9sm11523062pab.13.2015.10.21.19.31.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Oct 2015 19:31:25 -0700 (PDT) From: Caesar Wang To: Heiko Stuebner Subject: [RESEND PATCH v2 1/2] dt-bindings: rockchip-thermal: Add the "init" pinctrl in this document Date: Thu, 22 Oct 2015 10:30:47 +0800 Message-Id: <1445481048-20789-2-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1445481048-20789-1-git-send-email-wxt@rock-chips.com> References: <1445481048-20789-1-git-send-email-wxt@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151021_193143_192519_DA264692 X-CRM114-Status: GOOD ( 12.89 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Pawel Moll , linux-pm@vger.kernel.org, Dmitry Torokhov , dianders@chromium.org, linux-kernel@vger.kernel.org, Eduardo Valentin , linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Zhang Rui , linux-arm-kernel@lists.infradead.org, Caesar Wang MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The "init" pinctrl is defined we'll set pinctrl to this state before probe and then "default" after probe. Add the "init" pinctrl as the OTP gpio state, since we need switch the pin to gpio state before the TSADC controller is reset. As I know, the TSADC controller is reset, the tshut polarity will be a *low* signal in a short period of time for some devices. Says: The TSADC get the temperature on rockchip thermal. If T(current temperature) < (setting temperature), the OTP output the *high* signal. If T(current temperature) > (setting temperature), the OTP output the *low* Signal. In some cases, the OTP pin is connected to the PMIC, maybe the PMIC can accept the reset response time to avoid this issue. In other words, the system will be always reboot if we make the OTP pin is connected the others IC to control the power. Signed-off-by: Caesar Wang Reviewed-by: Douglas Anderson --- Changes in v2: - Add the 'init' pinctrl more decription in commit. - Fix the subject to make more obvious in PATCH[1/2] - Resend this patch v2 since fix the subject to be specific. Changes in v1: - As the Doug comments, add the 'init' property to sync document. Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index ef802de..28e84f7 100644 --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt @@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 { clock-names = "tsadc", "apb_pclk"; resets = <&cru SRST_TSADC>; reset-names = "tsadc-apb"; - pinctrl-names = "default"; - pinctrl-0 = <&otp_out>; + pinctrl-names = "init", "default"; + pinctrl-0 = <&otp_gpio>; + pinctrl-1 = <&otp_out>; #thermal-sensor-cells = <1>; rockchip,hw-tshut-temp = <95000>; rockchip,hw-tshut-mode = <0>;