diff mbox

[RFC,v1,2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform

Message ID 1447228052-4897-1-git-send-email-ykk@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yakir Yang Nov. 11, 2015, 7:47 a.m. UTC 
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
 .../display/rockchip/inno_hdmi-rockchip.txt        | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt

Comments

Rob Herring Nov. 11, 2015, 8:22 p.m. UTC | #1 
On Wed, Nov 11, 2015 at 03:47:32PM +0800, Yakir Yang wrote:
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  .../display/rockchip/inno_hdmi-rockchip.txt        | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> new file mode 100644
> index 0000000..1898408
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> @@ -0,0 +1,50 @@
> +Rockchip specific extensions to the Innosilicon HDMI
> +================================
> +
> +Required properties:
> +- compatible:
> +	"rockchip,rk3036-dw-hdmi";
> +- reg:
> +	Physical base address and length of the controller's registers.
> +- clocks, clock-names:
> +	Phandle to hdmi controller clock, name should be "pclk"
> +- interrupts:
> +	HDMI interrupt number
> +- ports:
> +	Contain one port node with endpoint definitions as defined in
> +	Documentation/devicetree/bindings/graph.txt.
> +- pinctrl-0, pinctrl-name:
> +	Switch the iomux of HPD/CEC pins to HDMI function.
> +
> +Example:
> +hdmi: hdmi@20034000 {
> +	compatible = "rockchip,rk3036-inno-hdmi";
> +	reg = <0x20034000 0x4000>;
> +	interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> +	clocks = <&cru  PCLK_HDMI>;
> +	clock-names = "pclk";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&hdmi_ctl>;
> +	status = "disabled";
> +
> +	hdmi_in: port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		hdmi_in_lcdc: endpoint@0 {
> +			reg = <0>;
> +			remote-endpoint = <&lcdc_out_hdmi>;
> +		};
> +	};
> +};
> +
> +&pinctrl {
> +	hdmi {
> +		hdmi_ctl: hdmi-ctl {
> +			rockchip,pins = <1 8  RK_FUNC_1 &pcfg_pull_none>,
> +					<1 9  RK_FUNC_1 &pcfg_pull_none>,
> +					<1 10 RK_FUNC_1 &pcfg_pull_none>,
> +					<1 11 RK_FUNC_1 &pcfg_pull_none>;
> +		};
> +	};
> +
> +};
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Yakir Yang Nov. 12, 2015, 1:07 a.m. UTC | #2 
Hi Rob,

On 11/12/2015 04:22 AM, Rob Herring wrote:
> On Wed, Nov 11, 2015 at 03:47:32PM +0800, Yakir Yang wrote:
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>

Thanks you for responding   ;)

- Yakir

>> ---
>>   .../display/rockchip/inno_hdmi-rockchip.txt        | 50 ++++++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>> new file mode 100644
>> index 0000000..1898408
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>> @@ -0,0 +1,50 @@
>> +Rockchip specific extensions to the Innosilicon HDMI
>> +================================
>> +
>> +Required properties:
>> +- compatible:
>> +	"rockchip,rk3036-dw-hdmi";
>> +- reg:
>> +	Physical base address and length of the controller's registers.
>> +- clocks, clock-names:
>> +	Phandle to hdmi controller clock, name should be "pclk"
>> +- interrupts:
>> +	HDMI interrupt number
>> +- ports:
>> +	Contain one port node with endpoint definitions as defined in
>> +	Documentation/devicetree/bindings/graph.txt.
>> +- pinctrl-0, pinctrl-name:
>> +	Switch the iomux of HPD/CEC pins to HDMI function.
>> +
>> +Example:
>> +hdmi: hdmi@20034000 {
>> +	compatible = "rockchip,rk3036-inno-hdmi";
>> +	reg = <0x20034000 0x4000>;
>> +	interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
>> +	clocks = <&cru  PCLK_HDMI>;
>> +	clock-names = "pclk";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&hdmi_ctl>;
>> +	status = "disabled";
>> +
>> +	hdmi_in: port {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		hdmi_in_lcdc: endpoint@0 {
>> +			reg = <0>;
>> +			remote-endpoint = <&lcdc_out_hdmi>;
>> +		};
>> +	};
>> +};
>> +
>> +&pinctrl {
>> +	hdmi {
>> +		hdmi_ctl: hdmi-ctl {
>> +			rockchip,pins = <1 8  RK_FUNC_1 &pcfg_pull_none>,
>> +					<1 9  RK_FUNC_1 &pcfg_pull_none>,
>> +					<1 10 RK_FUNC_1 &pcfg_pull_none>,
>> +					<1 11 RK_FUNC_1 &pcfg_pull_none>;
>> +		};
>> +	};
>> +
>> +};
>> -- 
>> 1.9.1
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
Heiko Stuebner Nov. 21, 2015, 8:14 p.m. UTC | #3 
Hi Yakir,

Am Mittwoch, 11. November 2015, 15:47:32 schrieb Yakir Yang:
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
>  .../display/rockchip/inno_hdmi-rockchip.txt        | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> new file mode 100644
> index 0000000..1898408
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
> @@ -0,0 +1,50 @@
> +Rockchip specific extensions to the Innosilicon HDMI
> +================================
> +
> +Required properties:
> +- compatible:
> +	"rockchip,rk3036-dw-hdmi";

should be "rockchip,rk3036-inno-hdmi"; instead I guess


Heiko
Yakir Yang Nov. 23, 2015, 1:26 a.m. UTC | #4 
Hi Heiko,

On 11/22/2015 04:14 AM, Heiko Stuebner wrote:
> Hi Yakir,
>
> Am Mittwoch, 11. November 2015, 15:47:32 schrieb Yakir Yang:
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>>   .../display/rockchip/inno_hdmi-rockchip.txt        | 50 ++++++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>> new file mode 100644
>> index 0000000..1898408
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
>> @@ -0,0 +1,50 @@
>> +Rockchip specific extensions to the Innosilicon HDMI
>> +================================
>> +
>> +Required properties:
>> +- compatible:
>> +	"rockchip,rk3036-dw-hdmi";
> should be "rockchip,rk3036-inno-hdmi"; instead I guess

Right, thanks

- Yakir

>
> Heiko
>
>
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
new file mode 100644
index 0000000..1898408
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt
@@ -0,0 +1,50 @@ 
+Rockchip specific extensions to the Innosilicon HDMI
+================================
+
+Required properties:
+- compatible:
+	"rockchip,rk3036-dw-hdmi";
+- reg:
+	Physical base address and length of the controller's registers.
+- clocks, clock-names:
+	Phandle to hdmi controller clock, name should be "pclk"
+- interrupts:
+	HDMI interrupt number
+- ports:
+	Contain one port node with endpoint definitions as defined in
+	Documentation/devicetree/bindings/graph.txt.
+- pinctrl-0, pinctrl-name:
+	Switch the iomux of HPD/CEC pins to HDMI function.
+
+Example:
+hdmi: hdmi@20034000 {
+	compatible = "rockchip,rk3036-inno-hdmi";
+	reg = <0x20034000 0x4000>;
+	interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+	clocks = <&cru  PCLK_HDMI>;
+	clock-names = "pclk";
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_ctl>;
+	status = "disabled";
+
+	hdmi_in: port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		hdmi_in_lcdc: endpoint@0 {
+			reg = <0>;
+			remote-endpoint = <&lcdc_out_hdmi>;
+		};
+	};
+};
+
+&pinctrl {
+	hdmi {
+		hdmi_ctl: hdmi-ctl {
+			rockchip,pins = <1 8  RK_FUNC_1 &pcfg_pull_none>,
+					<1 9  RK_FUNC_1 &pcfg_pull_none>,
+					<1 10 RK_FUNC_1 &pcfg_pull_none>,
+					<1 11 RK_FUNC_1 &pcfg_pull_none>;
+		};
+	};
+
+};