| Message ID | 1447949176-21926-5-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Stefan Wahren <stefan.wahren@i2se.com> writes: > Finally this patch assign all relevant pins to the sdhci pinctrl. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 4 ++++ > arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 4 ++++ > arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 4 ++++ > arch/arm/boot/dts/bcm2835-rpi-b.dts | 4 ++++ > 4 files changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > index 50be11d..4d562d9 100644 > --- a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > +++ b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > @@ -28,3 +28,7 @@ > brcm,function = <BCM2835_FSEL_ALT0>; > }; > }; > + > +&sdhci { > + pinctrl-0 = <&sdhci_alt3>; > +}; [...] What effect does this have? Does this change any pinmuxing at boot? If so, is it just resetting things from what the firmware has set to what we expect it to be? Does it enable card detection on the Pi B? As far as the whole series, I really like the improved description in patch 2, and patch 3 seems like a good idea, too.
diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts index 50be11d..4d562d9 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts @@ -28,3 +28,7 @@ brcm,function = <BCM2835_FSEL_ALT0>; }; }; + +&sdhci { + pinctrl-0 = <&sdhci_alt3>; +}; diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts index 43dd5ef..27a533a 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts @@ -28,3 +28,7 @@ brcm,function = <BCM2835_FSEL_ALT0>; }; }; + +&sdhci { + pinctrl-0 = <&sdhci_alt3>; +}; diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts index e5a65a8..dcc1627 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts @@ -21,3 +21,7 @@ brcm,function = <BCM2835_FSEL_ALT2>; }; }; + +&sdhci { + pinctrl-0 = <&sdhci_alt3>; +}; diff --git a/arch/arm/boot/dts/bcm2835-rpi-b.dts b/arch/arm/boot/dts/bcm2835-rpi-b.dts index 1be2220..bdb9308 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-b.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-b.dts @@ -20,3 +20,7 @@ brcm,function = <BCM2835_FSEL_GPIO_IN>; }; }; + +&sdhci { + pinctrl-0 = <&sdhci_alt3 &sdhci_cd>; +};
Finally this patch assign all relevant pins to the sdhci pinctrl. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 4 ++++ arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 4 ++++ arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 4 ++++ arch/arm/boot/dts/bcm2835-rpi-b.dts | 4 ++++ 4 files changed, 16 insertions(+)