From patchwork Thu Nov 26 18:08:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 7708391 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4AD4DBF90C for ; Thu, 26 Nov 2015 18:11:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 807612061E for ; Thu, 26 Nov 2015 18:11:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC84B2061C for ; Thu, 26 Nov 2015 18:11:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a20yq-0004JB-9t; Thu, 26 Nov 2015 18:09:16 +0000 Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a20yM-0003zV-Ds for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2015 18:08:47 +0000 Received: by lfs39 with SMTP id 39so102843244lfs.3 for ; Thu, 26 Nov 2015 10:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7MnCQYpN4iVSIZcXlqq40f0HqM5R9qT1CqOD5DGJQdA=; b=hZBb1qoAYMlfUGRMkKeW/JYyw0DbgFeFHbwxXlDIJoZSVdVUsoIZV1H4zpqr6XSlDi gy8ItjZR8jhz0kA6DejRBrMEr5Iwej+xCsHFMEthS+Ruzp9Si2hkfnuee4TmXsLpZxg4 2ZfCqkfHAQGj12sA940jS0A6NZqBXVWzZuyzDVMlCeRCUIS8ayYPqBCrZs/rkXyI5Q4M ZaBwDLyZOM87A+fVGums0MIlWLbbuT6uUBt3UtpbcyvCIATDJhdKeE8cJorQoYX72NKj 0gVtBGP/99CD6N7T6Smq1HHOYWdw1DuY4EAffwX+HJl6MnnFDcCUDDDo71GxxKD0grRu 05fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7MnCQYpN4iVSIZcXlqq40f0HqM5R9qT1CqOD5DGJQdA=; b=VLmnwTQJ9XHwkplEUelCsRjeY/EcwhlXsY8RRz9qUsizN72r4yoHXZxNbVcNCcyYuA tx5guL05uiGwBV/r11tKLSnJGOlNXms6xymjOLbYP8YO8dE81AbyJhYRIMipd95IHaoc avt5EMsxN8v7ZK1C0J4l8DOc7cWAtw/PUwd6BRkTWvoq90wvNFlJkOeq3kMILw/X5q7a KdiDXSjzm74EkKVdbyseFweRoiHTJv6IVS1yzUwXPuSscBF7FAMQ8a1VU/pzdbmQbm/0 AFKUO3TFyHnJ/x8fVuJXWxvSzCQDN8lbPQ1LvQGACbnVsBBGtC6LrevMg9g1Rd63WZeF 1caQ== X-Gm-Message-State: ALoCoQmo+QBkCc9VQ/waQysDQ6ThmwfYaLfj1/AtvG7Gj7aNi7D1GJfbEiN6B4EL4KQ2P3sjx1C3 X-Received: by 10.112.202.168 with SMTP id kj8mr17934440lbc.12.1448561305695; Thu, 26 Nov 2015 10:08:25 -0800 (PST) Received: from enkidu.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id a190sm4297654lfa.32.2015.11.26.10.08.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Nov 2015 10:08:25 -0800 (PST) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH v2 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Date: Thu, 26 Nov 2015 19:08:10 +0100 Message-Id: <1448561293-16431-4-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1448561293-16431-1-git-send-email-mw@semihalf.com> References: <1448561293-16431-1-git-send-email-mw@semihalf.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151126_100846_879211_AF3D3321 X-CRM114-Status: GOOD ( 10.91 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thomas.petazzoni@free-electrons.com, andrew@lunn.ch, linux@arm.linux.org.uk, jason@lakedaemon.net, myair@marvell.com, jaz@semihalf.com, simon.guinot@sequanux.org, xswang@marvell.com, nadavh@marvell.com, alior@marvell.com, stable@vger.kernel.org, tn@semihalf.com, gregory.clement@free-electrons.com, nitroshift@yahoo.com, mw@semihalf.com, davem@davemloft.net, sebastian.hesselbarth@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A value originally defined in the driver was inappropriate. Even though the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16] are reserved and read-only. This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to be compliant with the controller's documentation. Signed-off-by: Marcin Wojtas Cc: # v3.8+ Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index d78edbb..0c3d923 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -160,7 +160,7 @@ #define MVNETA_INTR_ENABLE 0x25b8 #define MVNETA_TXQ_INTR_ENABLE_ALL_MASK 0x0000ff00 -#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0xff000000 // note: neta says it's 0x000000FF +#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0x000000ff #define MVNETA_RXQ_CMD 0x2680 #define MVNETA_RXQ_DISABLE_SHIFT 8