diff mbox

[2/5] ARM: hisi: enable Hi3519 soc

Message ID 1448694937-31282-1-git-send-email-xuejiancheng@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jiancheng Xue Nov. 28, 2015, 7:15 a.m. UTC
Hi3519 SOC is mainly used for ip camera and sport dv
solutions.

Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
---
 arch/arm/mach-hisi/Kconfig     | 9 +++++++++
 arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
 2 files changed, 18 insertions(+)

Comments

Kevin Hilman Dec. 1, 2015, 12:02 a.m. UTC | #1
Jiancheng Xue <xuejiancheng@huawei.com> writes:

> Hi3519 SOC is mainly used for ip camera and sport dv
> solutions.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> ---
>  arch/arm/mach-hisi/Kconfig     | 9 +++++++++
>  arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>  2 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
> index 83061ad..6bb822c 100644
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -48,6 +48,15 @@ config ARCH_HIX5HD2
>  	select PINCTRL_SINGLE
>  	help
>  	  Support for Hisilicon HIX5HD2 SoC family
> +
> +config ARCH_HI3519

Please keep these sorted alphabetically.

Speaking of which, there is already an existing ARCH_HI3xxx entry.
Should this be included in that family?   If not, maybe the HI3xxx
should be renamed HI36xx ?

Kevin
Jiancheng Xue Dec. 1, 2015, 2:56 a.m. UTC | #2
Hi Kevin,
   Thank you for your suggestions.

On 2015/12/1 8:02, Kevin Hilman wrote:
> Jiancheng Xue <xuejiancheng@huawei.com> writes:
> 
>> Hi3519 SOC is mainly used for ip camera and sport dv
>> solutions.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>> ---
>>  arch/arm/mach-hisi/Kconfig     | 9 +++++++++
>>  arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
>> index 83061ad..6bb822c 100644
>> --- a/arch/arm/mach-hisi/Kconfig
>> +++ b/arch/arm/mach-hisi/Kconfig
>> @@ -48,6 +48,15 @@ config ARCH_HIX5HD2
>>  	select PINCTRL_SINGLE
>>  	help
>>  	  Support for Hisilicon HIX5HD2 SoC family
>> +
>> +config ARCH_HI3519
> 
> Please keep these sorted alphabetically.

Sorry about that. I will correct it in next version.

> 
> Speaking of which, there is already an existing ARCH_HI3xxx entry.
> Should this be included in that family?   If not, maybe the HI3xxx
> should be renamed HI36xx ?

ARCH_HI3xxx just represents Hi36xx mobile soc family. Hi3519 is not included.
It's good advice to rename HI3xxx to HI36xx.

> Kevin
> 
> .
> 

Many thanks,

Jiacheng
diff mbox

Patch

diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
index 83061ad..6bb822c 100644
--- a/arch/arm/mach-hisi/Kconfig
+++ b/arch/arm/mach-hisi/Kconfig
@@ -48,6 +48,15 @@  config ARCH_HIX5HD2
 	select PINCTRL_SINGLE
 	help
 	  Support for Hisilicon HIX5HD2 SoC family
+
+config ARCH_HI3519
+	bool "Hisilicon Hi3519 Soc" if ARCH_MULTI_V7
+	select HAVE_ARM_ARCH_TIMER
+	select ARCH_HAS_RESET_CONTROLLER
+
+	help
+	  Support for Hisilicon Hi3519 Soc
+
 endmenu
 
 endif
diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
index 8cc6215..a93ac5c 100644
--- a/arch/arm/mach-hisi/hisilicon.c
+++ b/arch/arm/mach-hisi/hisilicon.c
@@ -81,3 +81,12 @@  static const char *const hip01_compat[] __initconst = {
 DT_MACHINE_START(HIP01, "Hisilicon HIP01 (Flattened Device Tree)")
 	.dt_compat      = hip01_compat,
 MACHINE_END
+
+static const char *const hi3519_compat[] __initconst = {
+	"hisilicon,hi3519",
+	NULL,
+};
+
+DT_MACHINE_START(HI3519_DT, "Hisilicon Hi3519 (Flattened Device Tree)")
+	.dt_compat	= hi3519_compat,
+MACHINE_END