From patchwork Mon Jan 4 19:23:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 7950621 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F8889F1CC for ; Mon, 4 Jan 2016 19:25:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 96AC42020F for ; Mon, 4 Jan 2016 19:25:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A523F2012D for ; Mon, 4 Jan 2016 19:25:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aGAjb-0001Kb-Vz; Mon, 04 Jan 2016 19:24:04 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aGAjX-00016E-AE for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2016 19:24:00 +0000 Received: from paszta.hi.pengutronix.de ([2001:67c:670:100:96de:80ff:fec2:9969] helo=paszta) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1aGAjB-0003l1-Np; Mon, 04 Jan 2016 20:23:37 +0100 Message-ID: <1451935417.3884.49.camel@pengutronix.de> Subject: Re: [Regression] No display on i.MX53 after update to 4.4-rc4 From: Philipp Zabel To: Martin Fuzzey Date: Mon, 04 Jan 2016 20:23:37 +0100 In-Reply-To: <5674149C.90206@parkeon.com> References: <5674149C.90206@parkeon.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160104_112359_541050_B6F3F8B4 X-CRM114-Status: GOOD ( 16.82 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Martin, Am Freitag, den 18.12.2015, 15:13 +0100 schrieb Martin Fuzzey: > Hi Philipp, > > after updating my kernel to include: > > gpu: ipu-v3: Assign of_node of child platform devices to > corresponding ports [304e6be652e2ef2190adf9c23a2a1e5f9f39800d] > > the display initialisation fails with: > > "imx-ipuv3 18000000.ipu: missing port@0 node in /soc/ipu@18000000" > > Indeed the in tree imx53.dtsi file does not contain that node. > > Does the node need to be added (even if the camera is not being used) or > should ipu_add_client_devices() not bail out if one node is missing? The ports are marked as optional in the binding docs, so the driver should not bail out if they are not present. How about this patch: -----8<----- From d82649ac3bde511eb5977beb1080f0c6c78e391a Mon Sep 17 00:00:00 2001 From: Philipp Zabel Subject: [PATCH] gpu: ipu-v3: Do not bail out on missing optional port nodes The port nodes are documented as optional, treat them accordingly. Reported-by: Martin Fuzzey Signed-off-by: Philipp Zabel Fixes: 304e6be652e2 ("gpu: ipu-v3: Assign of_node of child platform devices to corresponding ports") --- drivers/gpu/ipu-v3/ipu-common.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) ----->8----- regards Philipp diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 8ba367b..2093de2 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1094,10 +1094,11 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) /* Associate subdevice with the corresponding port node */ pdev->dev.of_node = of_graph_get_port_by_id(dev->of_node, i); if (i < 4 && !pdev->dev.of_node) { - dev_err(dev, "missing port@%d node in %s\n", i, - dev->of_node->full_name); - ret = -ENODEV; - goto err_register; + dev_info(dev, + "no port@%d node in %s, not using %s%d\n", + i, dev->of_node->full_name, + (i / 2) ? "DI" : "CSI", i % 2); + continue; } ret = platform_device_add_data(pdev, ®->pdata,