| Message ID | 1452585915-551-3-git-send-email-wenyou.yang@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 12 Jan 2016, Wenyou Yang wrote: > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has > two subdevices: > - Regulator > - Charger > > This patch adds documentation for ACT8945A DT bindings. > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > Changes in v2: > - use more specific label in Example. > - add pmic and charger nodes in Example. > > Documentation/devicetree/bindings/mfd/act8945a.txt | 82 ++++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt > new file mode 100644 > index 0000000..e4a8aaf > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > @@ -0,0 +1,82 @@ > +Device-Tree bindings for Active-semi ACT8945A MFD driver > + > +Required properties: > + - compatible: "active-semi,act8945a". > + - reg: the I2C slave address for the ACT8945A chip > + > +The chip exposes two subdevices: > + - a regulators: see ../regulator/act8945a-regulator.txt > + - a charger: see ../power/act8945a-charger.txt > + > +Example: > + act8945a@5b { > + compatible = "active-semi,act8945a"; > + reg = <0x5b>; > + status = "okay"; > + > + pmic { > + compatible = "active-semi,act8945a-regulator"; > + active-semi,vsel-high; > + > + regulators { Your tabbing here is not correct. > + vdd_1v35_reg: DCDC_REG1 { > + regulator-name = "VDD_1V35"; > + regulator-min-microvolt = <1350000>; > + regulator-max-microvolt = <1350000>; > + regulator-always-on; > + }; > + > + vdd_1v2_reg: DCDC_REG2 { > + regulator-name = "VDD_1V2"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-always-on; > + }; > + > + vdd_3v3_reg: DCDC_REG3 { > + regulator-name = "VDD_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vdd_fuse_reg: LDO_REG1 { > + regulator-name = "VDD_FUSE"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + regulator-always-on; > + }; > + > + vdd_3v3_lp_reg: LDO_REG2 { > + regulator-name = "VDD_3V3_LP"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vdd_led_reg: LDO_REG3 { > + regulator-name = "VDD_LED"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vdd_sdhc_1v8_reg: LDO_REG4 { > + regulator-name = "VDD_SDHC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + }; > + }; > + > + charger { > + compatible = "active-semi,act8945a-charger"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger_chglev>; > + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>; > + active-semi,input_voltage_threshold = <6600>; > + active-semi,precondition_timeout = <40>; > + active-semi,total_timeout = <3>; > + }; > + };
Hi Lee, > -----Original Message----- > From: Lee Jones [mailto:lee.jones@linaro.org] > Sent: 2016?1?12? 16:52 > To: Yang, Wenyou <Wenyou.Yang@atmel.com> > Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; > Mark Rutland <mark.rutland@arm.com>; Ian Campbell > <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Javier > Martinez Canillas <javier@dowhile0.org>; Krzysztof Kozlowski > <k.kozlowski@samsung.com>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH v2 2/2] mfd: add documentation for ACT8945A DT bindings > > On Tue, 12 Jan 2016, Wenyou Yang wrote: > > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two > > subdevices: > > - Regulator > > - Charger > > > > This patch adds documentation for ACT8945A DT bindings. > > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > > --- > > > > Changes in v2: > > - use more specific label in Example. > > - add pmic and charger nodes in Example. > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 82 > ++++++++++++++++++++ > > 1 file changed, 82 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt > > b/Documentation/devicetree/bindings/mfd/act8945a.txt > > new file mode 100644 > > index 0000000..e4a8aaf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > > @@ -0,0 +1,82 @@ > > +Device-Tree bindings for Active-semi ACT8945A MFD driver > > + > > +Required properties: > > + - compatible: "active-semi,act8945a". > > + - reg: the I2C slave address for the ACT8945A chip > > + > > +The chip exposes two subdevices: > > + - a regulators: see ../regulator/act8945a-regulator.txt > > + - a charger: see ../power/act8945a-charger.txt > > + > > +Example: > > + act8945a@5b { > > + compatible = "active-semi,act8945a"; > > + reg = <0x5b>; > > + status = "okay"; > > + > > + pmic { > > + compatible = "active-semi,act8945a-regulator"; > > + active-semi,vsel-high; > > + > > + regulators { > > Your tabbing here is not correct. Oh, Yes, it is not correct, I will correct it. Thanks. > > > + vdd_1v35_reg: DCDC_REG1 { > > + regulator-name = "VDD_1V35"; > > + regulator-min-microvolt = > <1350000>; > > + regulator-max-microvolt = > <1350000>; > > + regulator-always-on; > > + }; > > + > > + vdd_1v2_reg: DCDC_REG2 { > > + regulator-name = "VDD_1V2"; > > + regulator-min-microvolt = > <1100000>; > > + regulator-max-microvolt = > <1300000>; > > + regulator-always-on; > > + }; > > + > > + vdd_3v3_reg: DCDC_REG3 { > > + regulator-name = "VDD_3V3"; > > + regulator-min-microvolt = > <3300000>; > > + regulator-max-microvolt = > <3300000>; > > + regulator-always-on; > > + }; > > + > > + vdd_fuse_reg: LDO_REG1 { > > + regulator-name = "VDD_FUSE"; > > + regulator-min-microvolt = > <2500000>; > > + regulator-max-microvolt = > <2500000>; > > + regulator-always-on; > > + }; > > + > > + vdd_3v3_lp_reg: LDO_REG2 { > > + regulator-name = "VDD_3V3_LP"; > > + regulator-min-microvolt = > <3300000>; > > + regulator-max-microvolt = > <3300000>; > > + regulator-always-on; > > + }; > > + > > + vdd_led_reg: LDO_REG3 { > > + regulator-name = "VDD_LED"; > > + regulator-min-microvolt = > <3300000>; > > + regulator-max-microvolt = > <3300000>; > > + regulator-always-on; > > + }; > > + > > + vdd_sdhc_1v8_reg: LDO_REG4 { > > + regulator-name = > "VDD_SDHC_1V8"; > > + regulator-min-microvolt = > <1800000>; > > + regulator-max-microvolt = > <1800000>; > > + regulator-always-on; > > + }; > > + }; > > + }; > > + > > + charger { > > + compatible = "active-semi,act8945a-charger"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_charger_chglev>; > > + active-semi,chglev-gpio = <&pioA 12 > GPIO_ACTIVE_HIGH>; > > + active-semi,input_voltage_threshold = <6600>; > > + active-semi,precondition_timeout = <40>; > > + active-semi,total_timeout = <3>; > > + }; > > + }; > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source > software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog Best Regards, Wenyou Yang
Hi Wenyou,
[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on v4.4 next-20160111]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Wenyou-Yang/mfd-act8945a-add-Active-semi-ACT8945A-PMIC-MFD-driver/20160112-161159
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: x86_64-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/built-in.o: In function `act8945a_i2c_probe':
>> act8945a.c:(.text+0x229476): undefined reference to `__devm_regmap_init_i2c'
drivers/built-in.o: In function `act8945a_i2c_init':
>> act8945a.c:(.init.text+0x1a536): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `act8945a_i2c_exit':
>> act8945a.c:(.exit.text+0x66f): undefined reference to `i2c_del_driver'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi > -----Original Message----- > From: kbuild test robot [mailto:lkp@intel.com] > Sent: 2016?1?12? 20:55 > To: Yang, Wenyou <Wenyou.Yang@atmel.com> > Cc: kbuild-all@01.org; Lee Jones <lee.jones@linaro.org>; Rob Herring > <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland > <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar > Gala <galak@codeaurora.org>; Javier Martinez Canillas <javier@dowhile0.org>; > Krzysztof Kozlowski <k.kozlowski@samsung.com>; Ferre, Nicolas > <Nicolas.FERRE@atmel.com>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; Yang, Wenyou > <Wenyou.Yang@atmel.com> > Subject: Re: [PATCH v2 2/2] mfd: add documentation for ACT8945A DT bindings > > Hi Wenyou, > > [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on > v4.4 next-20160111] [if your patch is applied to the wrong git tree, please drop us > a note to help improving the system] > > url: https://github.com/0day-ci/linux/commits/Wenyou-Yang/mfd-act8945a-add- > Active-semi-ACT8945A-PMIC-MFD-driver/20160112-161159 > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next > config: x86_64-allmodconfig (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > drivers/built-in.o: In function `act8945a_i2c_probe': > >> act8945a.c:(.text+0x229476): undefined reference to `__devm_regmap_init_i2c' > drivers/built-in.o: In function `act8945a_i2c_init': > >> act8945a.c:(.init.text+0x1a536): undefined reference to `i2c_register_driver' > drivers/built-in.o: In function `act8945a_i2c_exit': > >> act8945a.c:(.exit.text+0x66f): undefined reference to `i2c_del_driver' Thank you for your test, I will fix it. Best Regards, Wenyou Yang
diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt new file mode 100644 index 0000000..e4a8aaf --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt @@ -0,0 +1,82 @@ +Device-Tree bindings for Active-semi ACT8945A MFD driver + +Required properties: + - compatible: "active-semi,act8945a". + - reg: the I2C slave address for the ACT8945A chip + +The chip exposes two subdevices: + - a regulators: see ../regulator/act8945a-regulator.txt + - a charger: see ../power/act8945a-charger.txt + +Example: + act8945a@5b { + compatible = "active-semi,act8945a"; + reg = <0x5b>; + status = "okay"; + + pmic { + compatible = "active-semi,act8945a-regulator"; + active-semi,vsel-high; + + regulators { + vdd_1v35_reg: DCDC_REG1 { + regulator-name = "VDD_1V35"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + regulator-always-on; + }; + + vdd_1v2_reg: DCDC_REG2 { + regulator-name = "VDD_1V2"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1300000>; + regulator-always-on; + }; + + vdd_3v3_reg: DCDC_REG3 { + regulator-name = "VDD_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vdd_fuse_reg: LDO_REG1 { + regulator-name = "VDD_FUSE"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + }; + + vdd_3v3_lp_reg: LDO_REG2 { + regulator-name = "VDD_3V3_LP"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vdd_led_reg: LDO_REG3 { + regulator-name = "VDD_LED"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vdd_sdhc_1v8_reg: LDO_REG4 { + regulator-name = "VDD_SDHC_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + }; + }; + + charger { + compatible = "active-semi,act8945a-charger"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_charger_chglev>; + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>; + active-semi,input_voltage_threshold = <6600>; + active-semi,precondition_timeout = <40>; + active-semi,total_timeout = <3>; + }; + };
The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two subdevices: - Regulator - Charger This patch adds documentation for ACT8945A DT bindings. Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- Changes in v2: - use more specific label in Example. - add pmic and charger nodes in Example. Documentation/devicetree/bindings/mfd/act8945a.txt | 82 ++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt