From patchwork Tue Jan 12 10:11:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 8015851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1B74D9F2F4 for ; Tue, 12 Jan 2016 10:14:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 542ED203A1 for ; Tue, 12 Jan 2016 10:14:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AAC920115 for ; Tue, 12 Jan 2016 10:14:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIvvy-0001WM-K9; Tue, 12 Jan 2016 10:12:14 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIvvu-0001Og-Us for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2016 10:12:12 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O0U00Q334BO6810@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2016 19:11:48 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.116]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 35.68.04972.461D4965; Tue, 12 Jan 2016 19:11:48 +0900 (KST) X-AuditID: cbfee68e-f793c6d00000136c-03-5694d1641280 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id D9.07.09068.461D4965; Tue, 12 Jan 2016 19:11:48 +0900 (KST) Received: from samsunx.samsung ([10.113.63.54]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O0U00BOD4AUF160@mmp1.samsung.com>; Tue, 12 Jan 2016 19:11:48 +0900 (KST) From: Andi Shyti To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb Date: Tue, 12 Jan 2016 19:11:12 +0900 Message-id: <1452593472-10703-1-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.6.4 In-reply-to: <5694BABF.3070200@samsung.com> References: <5694BABF.3070200@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsWyRsSkRDfl4pQwg1NnVC22H3nGarH4x3Mm i1nb97NYvH5haLHp8TVWi8u75rBZ3L7Ma7H2yF12i1PXP7NZ/N+zg91i86apzBardv1htNh/ xcti773PjA58Hi3NPWwe375OYvG4vuQTs8fOWXfZPTat6mTzeHfuHLvHvJOBHpuX1HtcOdHE 6tG3ZRWjx4np31k8Pm+SC+CJ4rJJSc3JLEst0rdL4MpYsWMmY8EynooDKx+zNDB+5exi5OSQ EDCRuNLTyQJhi0lcuLeeDcQWEljBKDH5XQ5Mzf7v04BquIDiSxklPr2cxQ7hfGSU2H7+ODtI FZuApkTT7R9g3SICGhJTuh6DFTELbGWSaO0+zAiSEBYIl3i1aSVYEYuAqkTD3kNANgcHr4Cb xO5nPiCmhICcxKQJDiAmp4C2xIFXVhD3aElsv/ufGWSihEAjh8Sc7i/MEFMEJL5NPsQC0Sor sekAM8TNkhIHV9xgmcAovICRYRWjaGpBckFxUnqRkV5xYm5xaV66XnJ+7iZGYJSd/vesbwfj zQPWhxgFOBiVeHgz2KeECbEmlhVX5h5iNAXaMJFZSjQ5HxjLeSXxhsZmRhamJqbGRuaWZkri vAlSP4OFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MOrk7hK8ynfDonTpUaZX6ybWXT4nsuq0 2g/V6NMHpr+4nuNyKlMxeMqmVf/yLk0UZZ372y7u4JRHizl1LTn4Dm1aGcjHPaO3pNurNEfv V9qPCcd3bW/K6t2gk1ZVOM/qeI5D06WmKo8/ma1sNzaVWXmod5RvWLCD1Sudme1Xx5mVK9bf /RqerqvEUpyRaKjFXFScCACsSC92rQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jAd2Ui1PCDI7/lLHYfuQZq8XiH8+Z LGZt389i8fqFocWmx9dYLS7vmsNmcfsyr8XaI3fZLU5d/8xm8X/PDnaLzZumMlus2vWH0WL/ FS+Lvfc+MzrwebQ097B5fPs6icXj+pJPzB47Z91l99i0qpPN4925c+we804GemxeUu9x5UQT q0ffllWMHiemf2fx+LxJLoAnqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJ IS8xN9VWycUnQNctMwfoESWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1j xoodMxkLlvFUHFj5mKWB8StnFyMnh4SAicT+79NYIGwxiQv31rN1MXJxCAksZZT49HIWO4Tz kVFi+/nj7CBVbAKaEk23f7CB2CICGhJTuh6DFTELbGWSaO0+zAiSEBYIl3i1aSVYEYuAqkTD 3kNANgcHr4CbxO5nPiCmhICcxKQJDiAmp4C2xIFXViDFQgJaEtvv/meewMi7gJFhFaNEakFy QXFSeq5RXmq5XnFibnFpXrpecn7uJkZwLD+T3sF4eJf7IUYBDkYlHt4DnFPChFgTy4orcw8x SnAwK4nw2m0BCvGmJFZWpRblxxeV5qQWH2I0BbpqIrOUaHI+MM3klcQbGpuYGVkamRtaGBmb K4nz7rsUGSYkkJ5YkpqdmlqQWgTTx8TBKdXAqGcXn3Co+/36Ilabafr3U+r3PW/7OunuY7kF rncWFvu6dzd2h5lEGSwx2CQlc3CjyZHASiGl68pfjj8tEC0S5NNdYfL41WrFw0e+CVufenyH wWeN/4ypFct/dl623XXuLDtv0UF/sVrFf8smHN8Uay4QHfvl+6RFmnPv2Vp2J4m+WtGZFaK9 UImlOCPRUIu5qDgRABuh0nv7AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160112_021211_159547_1D0D2556 X-CRM114-Status: GOOD ( 14.75 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: k.kozlowski@samsung.com, linux@arm.linux.org.uk, tony@atomide.com, tomasz.figa@gmail.com, andi.shyti@samsung.com, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, andi@etezian.org, olof@lixom.net, tglx@linutronix.de, jiang.liu@linux.intel.com, m.szyprowski@samsung.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In some architectures the L2 cache controller is integrated in the processor's block itself and it doesn't use any external cache controller. This means that an entry in the board's dtb related to the l2c is not necessary. Distinguish between error codes and do not print anything in case l2x0_of_init() doesn't find any L2C DTB entry and returns -ENODEV. This patch mutes the following error message: L2C: failed to init: -19 on boards like odroid-xu4, cortex A7/A15, which don't have external cache controller. Signed-off-by: Andi Shyti Reported-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- Hi, here is a second version. An alternative would be to print with pr_dbg, but then it's a matter of taste. V1, and V2 print a message in case the l2c dtb entry is not found (the V2 has a better print rephrase suggested by Joe) V3 ignores the case of -enodev for l2c and doesn't print anything Thanks, Andi arch/arm/kernel/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c index 1d45320..ece04a4 100644 --- a/arch/arm/kernel/irq.c +++ b/arch/arm/kernel/irq.c @@ -95,7 +95,7 @@ void __init init_IRQ(void) outer_cache.write_sec = machine_desc->l2c_write_sec; ret = l2x0_of_init(machine_desc->l2c_aux_val, machine_desc->l2c_aux_mask); - if (ret) + if (ret && ret != -ENODEV) pr_err("L2C: failed to init: %d\n", ret); }