From patchwork Thu Jan 28 21:25:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 8154051 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3E966BEEE5 for ; Thu, 28 Jan 2016 21:33:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 625082020F for ; Thu, 28 Jan 2016 21:33:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 869B82013A for ; Thu, 28 Jan 2016 21:33:38 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOuAY-0000x8-Nc; Thu, 28 Jan 2016 21:31:58 +0000 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOu7T-0005u8-J7 for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2016 21:28:50 +0000 Received: by mail-pa0-x229.google.com with SMTP id ho8so29141880pac.2 for ; Thu, 28 Jan 2016 13:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6sgH5K6bHsDz6SFmwiA01gn/gMfxd7rCIIAMIUYYH9M=; b=QwURCdyqpCaYCqTxJBmMAk5c7RbXOkl3lJXm0MhlAegleswbpFAfGYcyHHYUYEmTZ8 pIj+gPvHO1PGwKeERDWct6+ZVcZEN6SJl/VCF4JSeB1oOMpvtcIw3L7sxJI+1xbmPjAc vQ1XQ1xByrk5022IqzicTYkqodzf1CtpFXRD2u/eCeQzFhBkgOx1LEmFYxhBhXTnZX4E QFBGXZs3SJsIYrQt78o7xG5A91/2NQ7iL9Ecp88kqXHQ0cMUvVOci9LAEkeGnH+pIZXG 8STGNM81RpqjIITEJcpC6m1fPLnrT12GH+kimTRV3fMpa0qOfYRj5PuRsQn9YQDU4Sin NSWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6sgH5K6bHsDz6SFmwiA01gn/gMfxd7rCIIAMIUYYH9M=; b=DKVmwgP5H6xIIYjPxIO/jY2C2o46+kPamn+917bNpFHq5UPiOc2LX2zuq4p3eeeeyW UlxbeQCqmcm0fHQPnKnrHe/PGExeblgaCUnt7548Gep4nwuDAWoEMXMq/WRCF+fW1otT 9+13I5/qGUbmm5xjsxnczk2nhlsQq96vEblkhJY9bSTs0UvqPQ2krUrPTzLBcYi4AsGK f6z8YgGnHi5oNGRhQZE0nPQk04oy7E0HIBghgkhDKVHHI9AzaE9Wv4/SnUF1o2TBTw7M dqKebbA5MBrGEC6kxzZxhy6n2iwsA2EVIiAlw+0jmOQyOL7PESsEb0n56hv6i6o7ptGf YDMA== X-Gm-Message-State: AG10YORm643WkR0esXVQjKYbPhMqms3iRcgs+jaEGH5qHqI95/JoAxB1I6ZMx4bv0SRbwQ== X-Received: by 10.66.54.78 with SMTP id h14mr7935405pap.59.1454016512083; Thu, 28 Jan 2016 13:28:32 -0800 (PST) Received: from localhost.localdomain (wsip-70-184-93-199.ph.ph.cox.net. [70.184.93.199]) by smtp.googlemail.com with ESMTPSA id c90sm18583190pfd.31.2016.01.28.13.28.30 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jan 2016 13:28:31 -0800 (PST) From: Troy Kisky To: netdev@vger.kernel.org, davem@davemloft.net, B38611@freescale.com Subject: [PATCH net-next 14/40] net: fec: don't clear all rx queue bits when just one is being checked Date: Thu, 28 Jan 2016 14:25:38 -0700 Message-Id: <1454016364-30985-15-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1454016364-30985-1-git-send-email-troy.kisky@boundarydevices.com> References: <1454016364-30985-1-git-send-email-troy.kisky@boundarydevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160128_132848_020357_BFEAB1E7 X-CRM114-Status: GOOD ( 11.37 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fabio.estevam@freescale.com, andrew@lunn.ch, linux@arm.linux.org.uk, Troy Kisky , laci@boundarydevices.com, l.stach@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, tremyfr@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since this is now done in the napi routine and not the interrupt, it is not needed. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 04b1fb7..a7af1ac 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1330,8 +1330,6 @@ static int fec_rxq(struct net_device *ndev, struct fec_enet_private *fep, break; pkt_received++; - writel(FEC_ENET_RXF, fep->hwp + FEC_IEVENT); - /* Check for errors. */ status ^= BD_ENET_RX_LAST; if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO |