From patchwork Thu Jan 28 21:25:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 8154491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7B6EBBEEE5 for ; Thu, 28 Jan 2016 21:56:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9FA582021B for ; Thu, 28 Jan 2016 21:56:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3E0320218 for ; Thu, 28 Jan 2016 21:56:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOuWy-000816-Vs; Thu, 28 Jan 2016 21:55:09 +0000 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOu7z-000655-Qg for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2016 21:29:20 +0000 Received: by mail-pf0-x234.google.com with SMTP id n128so29537856pfn.3 for ; Thu, 28 Jan 2016 13:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rto7aeZNKRypcSyU4b2kYdgaDeJffeWcplAZ/wOitWQ=; b=cFNYUHIn+x3mNbTtQAFplt3kaF64lwQHqsjEiHZTLSgvBC/iu8dMnIG9YmiJOF5mzu HHi2HS7oTqY6B+ebIzCnWelVOx43wFG2dGCaNsHgFxDh0/nFYdT06AzJ4lFrc/GVt2n6 931ghRNn0jEtCPwQBQkwBzsUVb0vCKpRcVBYBqNI+0XP4EXLJaaMSsV1ew+KZPhuqu4J TqITIVgOesU6zxdHo4ESwgBcSu1sf5+kMIbqcxunEG29spYertM5kfIPIUY5tBAxUqfi c3biUdesnI/45XD0ZJRZqLzKQpZE7uDuMqUA6ctRrZ9Z03yYJFkbZ4A2cY5S2HfZqDlc YRLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rto7aeZNKRypcSyU4b2kYdgaDeJffeWcplAZ/wOitWQ=; b=dJ3kE0Ldp2A85PMYNYohGvSBPs369EZmtrDH43N5Gpnlrsmqk64lMmD6gqWaLZOZlv yJo2/8lS+s2OwCAiz7KnfjiSz1/QZglvFKe2yrOW5K7qg/uSF/Ir9QFYUyoDp59RC4d0 7do3fLfoiFLa8q1tDS3Lk2Y9qmq2dZp50kDhRx2SSBySl7iwL7P1a3msJyF6gdBF5jy0 Fxc6LvzzzS7T0RxOGML88jD+8fCpp2qtjFASf7aXSjlcVYpfrx7qNuztHJvqJvNH+wri ESuwOpnsmNrusb9BZ2AHve6N7aJN0LhLk5YSC7v0GtUB6gsfzmIW9W6ZAB9nJj//lkNc NlgQ== X-Gm-Message-State: AG10YOSoa75i3tnvuhSJrPaUQED53RxdccmZQeUNIlBU972P9O6B2bBSRHQL8hEZwrnxmA== X-Received: by 10.98.73.29 with SMTP id w29mr7939641pfa.106.1454016539154; Thu, 28 Jan 2016 13:28:59 -0800 (PST) Received: from localhost.localdomain (wsip-70-184-93-199.ph.ph.cox.net. [70.184.93.199]) by smtp.googlemail.com with ESMTPSA id c90sm18583190pfd.31.2016.01.28.13.28.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jan 2016 13:28:58 -0800 (PST) From: Troy Kisky To: netdev@vger.kernel.org, davem@davemloft.net, B38611@freescale.com Subject: [PATCH net-next 30/40] net: fec: move last_bdp assignment for symmetry Date: Thu, 28 Jan 2016 14:25:54 -0700 Message-Id: <1454016364-30985-31-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1454016364-30985-1-git-send-email-troy.kisky@boundarydevices.com> References: <1454016364-30985-1-git-send-email-troy.kisky@boundarydevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160128_132919_978116_3EE43DDA X-CRM114-Status: GOOD ( 10.38 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fabio.estevam@freescale.com, andrew@lunn.ch, linux@arm.linux.org.uk, Troy Kisky , laci@boundarydevices.com, l.stach@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, tremyfr@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This way both if clauses assign last_bdp instead of only one clause overriding the default. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 3a82bfe..b829c29 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -436,7 +436,6 @@ static int fec_enet_txq_submit_skb(struct fec_enet_priv_tx_q *txq, /* Fill in a Tx ring entry */ bdp = txq->bd.cur; - last_bdp = bdp; /* Set buffer length and buffer pointer */ bufaddr = skb->data; @@ -472,6 +471,7 @@ static int fec_enet_txq_submit_skb(struct fec_enet_priv_tx_q *txq, return NETDEV_TX_OK; } } else { + last_bdp = bdp; status |= (BD_ENET_TX_INTR | BD_ENET_TX_LAST); if (fep->bufdesc_ex) { estatus = BD_ENET_TX_INT;