From patchwork Thu Feb 4 09:58:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Behme X-Patchwork-Id: 8216491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C5A139F6DA for ; Thu, 4 Feb 2016 10:01:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DC23120357 for ; Thu, 4 Feb 2016 10:01:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41CB32022D for ; Thu, 4 Feb 2016 10:01:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aRGh6-0000BT-0v; Thu, 04 Feb 2016 09:59:20 +0000 Received: from smtp6-v.fe.bosch.de ([2a03:cc00:ff0:100::2]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aRGh1-00009j-QP for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2016 09:59:17 +0000 Received: from vsmta14.fe.internet.bosch.com (unknown [10.4.98.54]) by imta23.fe.bosch.de (Postfix) with ESMTP id C8BE415801B4 for ; Thu, 4 Feb 2016 10:58:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=de.bosch.com; s=2015-01-21; t=1454579930; bh=wEVzH4HqBcEkaaFASWQQphh9u0rQm+Ct0bnn++UfcFM=; l=10; h=From:From:Reply-To:Sender; b=A/Ry7ty1RN+swk889zZIBjhaQOiz3Pb+ijnmq+n7B6BYyB7n/GXs2v4yHBHMlIqLc JhGqo5OS/Z54hIRtfKOsNiKJLiDUZCnYje5jxVeuxf1evIxYCbgabpfCk7qHVRHqDr MXKuBv8SefKHlbY3P+y1d2WtcARek12hWvpJ0J5w= Received: from SI-HUB1001.de.bosch.com (vsgw23.fe.internet.bosch.com [10.4.98.23]) by vsmta14.fe.internet.bosch.com (Postfix) with ESMTP id 91A29A40525 for ; Thu, 4 Feb 2016 10:58:50 +0100 (CET) Received: from hi-z5661.hi.de.bosch.com (10.34.211.2) by SI-HUB1001.de.bosch.com (10.4.103.108) with Microsoft SMTP Server id 14.3.195.1; Thu, 4 Feb 2016 10:58:50 +0100 Received: from hi-z5661.hi.de.bosch.com (localhost [127.0.0.1]) by hi-z5661.hi.de.bosch.com (Postfix) with ESMTP id E9687415B2; Thu, 4 Feb 2016 10:58:49 +0100 (CET) From: Dirk Behme To: , , Subject: [PATCH v2] drivers/perf: arm_pmu: make info messages more verbose Date: Thu, 4 Feb 2016 10:58:48 +0100 Message-ID: <1454579928-20231-1-git-send-email-dirk.behme@de.bosch.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-TM-AS-MML: disable X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.0.0.1202-22108.006 X-TMASE-MatchedRID: DtxO0SOuBrt3jIl30qTQg8nUT+eskUQPWLk7KHjvnCRXPwnnY5XL5E/3 ZkXeY1OAn1+BzcqI0qSNcFFFkbIL2MFeWQ9rEC3VyeVujmXuYYVMkOX0UoduubEz/84sct8s0c8 aNDRHFani8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvv5KOHJOD8qdeYdMOwro4bsBX6AHRfaOnUUdA UH90i2JkuMr076ZUQuiolXu+XH+OV6vTjdqWycUCQOZMHzWOoKyswCmTqmatpcKRK3DM/KmiQGd l1tQI7t0/5HQxvVB1U0+aGhUx8J2j4fwUoXsAKYftwZ3X11IV0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160204_015916_447981_738993AD X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.0 (-------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dirk Behme , sudeep.holla@arm.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores are online at PMU probe time we might get hw perfevents: failed to probe PMU! hw perfevents: failed to register PMU devices! making it unclear which cores failed, here. Add the device tree full name which failed and the error value resulting in a more verbose and helpful message like hw perfevents: /soc/pmu_a53: failed to probe PMU! Error -6 hw perfevents: /soc/pmu_a53: failed to register PMU devices! Error -6 Signed-off-by: Dirk Behme --- Changes in v2: Use the full node name from DT instead of pmu->name, as if we fail to find anything in the match table, that'll be NULL. Additionally, add the error value to get an idea why it failed. drivers/perf/arm_pmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index 166637f..6fb63a3 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -898,7 +898,8 @@ int arm_pmu_device_probe(struct platform_device *pdev, } if (ret) { - pr_info("failed to probe PMU!\n"); + pr_info("%s: failed to probe PMU! Error %i\n", + node->full_name, ret); goto out_free; } @@ -918,7 +919,8 @@ int arm_pmu_device_probe(struct platform_device *pdev, out_destroy: cpu_pmu_destroy(pmu); out_free: - pr_info("failed to register PMU devices!\n"); + pr_info("%s: failed to register PMU devices! Error %i\n", + node->full_name, ret); kfree(pmu); return ret; }