From patchwork Thu Feb 4 17:06:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Behme X-Patchwork-Id: 8225531 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D8F36BEEE5 for ; Thu, 4 Feb 2016 17:08:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D5B1120397 for ; Thu, 4 Feb 2016 17:08:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC6FF20392 for ; Thu, 4 Feb 2016 17:08:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aRNMe-0002Rq-Ni; Thu, 04 Feb 2016 17:06:40 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aRNMc-0002OG-2O for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2016 17:06:38 +0000 Received: by mail-wm0-x243.google.com with SMTP id g62so1308813wme.2 for ; Thu, 04 Feb 2016 09:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=+XUs6ql1w5sk1vdU4I0Z9cfkMLfeRGWwIPFAYumEgRM=; b=JfsBZphdK1I7kC+cIrU5BCYHTFFTzInqrjHVLBK3r7+rjcPxtFc1zRt5LFpbcjM6ER qkTpuCfE5fQjOl4ScO0O+oZZSlKxotz0ZkFsVPsNSCCk5v+5SKxw0lWn4XiSO7E3i7WQ uBnrhELe3p6DqPP158dOicHl8PSJjRBpdLovQKvNQlNF6ug2geDAjVAx3wISjhIItwtp I6/9AQqwRutj7cbPZ7b2S9rQIqvQx5VmrBMh+PuVf2cKlQOkBEGHFL78LZuz5KJfg9hn G8Y940h/MwFrYniD9F2fdlMox2JyCFgJMS0/oKgrF2tQBZ3XYKPjOsTZQyWwVbzHTUeV ppMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+XUs6ql1w5sk1vdU4I0Z9cfkMLfeRGWwIPFAYumEgRM=; b=cOXIb4bZ0JmCJtJmfS6oa1/N8wmL4c5aAB9rf7uexsTjoAVttCseocc4EbcHSdlGFM ZoyJ6YtpGxdfj96LDRGTdxRPMqvuPNbRL/FO1Xx6VDHjrf/6EgUc/aPqjMSjzeRwmjnd z7PCFdh6c7ytwp+bfgC/TSlZ+SMS7kgM6R4Tskz19y2DkO1mglImDHjs77eTyvuejdoj JYYDiE5s+LIwqgUe0wUcIhKvoI+Jb9+p0VKjU+uCkzZlE7jJMOjcbtk+Cqzyb0fayly3 okLxlOQCp0DzvXcXGLdDS63B46CuaatBldQxRjfRci0tWMV6Qj2mtOWhH3eK/jEU2jxk wuRA== X-Gm-Message-State: AG10YOScyPESEBj0XtwdRV94pwG22DAI8b+jz9FTHe7oEKT7dAkKe6UEij4I1FlCwc+Nrw== X-Received: by 10.194.82.199 with SMTP id k7mr10382219wjy.65.1454605575433; Thu, 04 Feb 2016 09:06:15 -0800 (PST) Received: from localhost.localdomain (p4FEE18AD.dip0.t-ipconnect.de. [79.238.24.173]) by smtp.gmail.com with ESMTPSA id z65sm3278372wmg.1.2016.02.04.09.06.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 09:06:14 -0800 (PST) From: Dirk Behme To: will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] drivers/perf: arm_pmu: make info messages more verbose Date: Thu, 4 Feb 2016 18:06:10 +0100 Message-Id: <1454605570-4725-1-git-send-email-dirk.behme@gmail.com> X-Mailer: git-send-email 2.7.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160204_090638_319249_7E7E91A5 X-CRM114-Status: GOOD ( 11.24 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Dirk Behme , sudeep.holla@arm.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dirk Behme On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores are online at PMU probe time we might get hw perfevents: failed to probe PMU! hw perfevents: failed to register PMU devices! making it unclear which cores failed, here. Add the device tree full name which failed and the error value resulting in a more verbose and helpful message like hw perfevents: /soc/pmu_a53: failed to probe PMU! Error -6 hw perfevents: /soc/pmu_a53: failed to register PMU devices! Error -6 Signed-off-by: Dirk Behme --- Changes in v3: Rebase against Will's perf/updates (8d1a0ae72) Changes in v2: Use the full node name from DT instead of pmu->name, as if we fail to find anything in the match table, that'll be NULL. Additionally, add the error value to get an idea why it failed. drivers/perf/arm_pmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index eb5bee0..ca63a45 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -907,7 +907,8 @@ int arm_pmu_device_probe(struct platform_device *pdev, } if (ret) { - pr_info("failed to probe PMU!\n"); + pr_info("%s: failed to probe PMU! Error %i\n", + node->full_name, ret); goto out_free; } @@ -927,7 +928,8 @@ int arm_pmu_device_probe(struct platform_device *pdev, out_destroy: cpu_pmu_destroy(pmu); out_free: - pr_info("failed to register PMU devices!\n"); + pr_info("%s: failed to register PMU devices! Error %i\n", + node->full_name, ret); kfree(pmu); return ret; }