From patchwork Tue Feb 16 06:20:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 8321781 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E75B39F372 for ; Tue, 16 Feb 2016 06:23:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 04870202F0 for ; Tue, 16 Feb 2016 06:23:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13176202E6 for ; Tue, 16 Feb 2016 06:23:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVZ1I-0001cW-B4; Tue, 16 Feb 2016 06:21:56 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVZ0q-00018t-Tl for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2016 06:21:32 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2M00JGAMZ5LK20@mailout2.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2016 06:21:05 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-d4-56c2bfd123ae Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 11.0E.16778.1DFB2C65; Tue, 16 Feb 2016 06:21:05 +0000 (GMT) Received: from localhost.localdomain ([10.113.63.52]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2M007D6MYI9U10@eusync4.samsung.com>; Tue, 16 Feb 2016 06:21:05 +0000 (GMT) From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v5 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Date: Tue, 16 Feb 2016 15:20:31 +0900 Message-id: <1455603632-11158-3-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 2.5.0 In-reply-to: <1455603632-11158-1-git-send-email-k.kozlowski@samsung.com> References: <1455603632-11158-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xa7oX9x8KMzg6X9DiwbxtbBZ/Jx1j t3i/rIfR4vqX56wW84+cY7V4/cLQov/xa2aLp5sfM1lsenyN1eJjzz1Wi8u75rBZzDi/j8ni 4ilXi1PXP7NZLNr6hd3i8Jt2VosfZ7pZLFbt+sNo8fLjCRYHYY8189Ywevz+NYnR4/2NVnaP y329TB47Z91l99i0qpPNY/OSeo8rJ5pYPfq2rGL0+LxJLoArissmJTUnsyy1SN8ugSuj65NM wQTZiq1nVRsYb0l0MXJwSAiYSCyYHdbFyAlkiklcuLeerYuRi0NIYCmjxOWOecwQzn9GieuL 5zGBVLEJGEtsXr6EDcQWEfjALPF5vjmIzSxwn1Hi70x1EFtYwE9i84IOsBoWAVWJe0+PMYPY vALuEgvuf2WEWCwnseBCOojJKeAhseuNIkiFEFBF+52z7BMYeRcwMqxiFE0tTS4oTkrPNdQr TswtLs1L10vOz93ECAn4LzsYFx+zOsQowMGoxMPL4XEoTIg1say4MvcQowQHs5IIb8IioBBv SmJlVWpRfnxRaU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4pRoYWYqV311re/P9 jRiT7FKtN78C1z7ZUnvwrZe6zbeobz+OxwbNi05duGvy1ZJYW7uX6S5rvRks47wNa6tvnk3/ wWBRqnn4x7KJ+6ZofYmznn1Ur8TzeoSV6FrTuVK34/cXKXUkKn2MffLyvbDzxdDdhzWfe80X OdVnrDKF+UnNjfLZJ816PItblViKMxINtZiLihMBsRm35nQCAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160215_222129_366539_E11D65B6 X-CRM114-Status: GOOD ( 18.87 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Kevin Hilman , Pankaj Dubey , Chanwoo Choi , Alim Akhtar , Olof Johansson MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS so it is built also on ARMv7. This does not bring any kind of benefit. There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like multi_v7 for ARMv7). Instead build clock drivers only for respective SoC's architecture. Signed-off-by: Krzysztof Kozlowski Acked-by: Sylwester Nawrocki --- Changes since v4: 1. Move ARM64 clock entry just before COMMON_CLK_SAMSUNG to make it more consistent with selecting behavior. Newer platforms just select COMMON_CLK_SAMSUNG. Only S3C24XX select specific clock symbols. 2. Re-work behaviour on COMPILE_TEST=y to fix ignored compilation when COMPILE_TEST=y but COMMON_CLK_SAMSUNG=n. The COMMON_CLK_SAMSUNG=y is necessary always to compile ARM64 clocks. 3. I received reviews and tests (Chanwoo, Javier, Andi, Stephen - thank you guys!)... but the patch is now different so I decided to drop them. I am kindly asking for review/testing (again...). Changes since v3: 1. Rebase on next-20160127. Changes since v2: 1. Follow Arnd's advice making EXYNOS_ARM64_COMMON_CLK user-visible when COMPILE_TEST is enabled. 2. Dropped accumulated tags because the logic is now different. Changes since v1: 1. Use one Kconfig symbol for clocks of all ARM64 SoCs (after discussion): EXYNOS_ARM64_COMMON_CLK. 2. Minor cleanups after Tomasz's comments. 3. Added tags: Chanwoo's, Sylwester's, Alim's and Tomasz's (the tags were given for v1 but assuming that change from 1. is not major enough to require re-tagging). --- drivers/clk/samsung/Kconfig | 10 +++++++++- drivers/clk/samsung/Makefile | 4 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index dd6093a33f84..20c5fe92ab4a 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -1,6 +1,15 @@ +# Recent Exynos platforms should just select COMMON_CLK_SAMSUNG: config COMMON_CLK_SAMSUNG bool "Samsung Exynos clock controller support" if COMPILE_TEST + # Clocks on ARM64 SoCs (e.g. Exynos5433, Exynos7) are chosen by + # EXYNOS_ARM64_COMMON_CLK to avoid building them on ARMv7: + select EXYNOS_ARM64_COMMON_CLK if ARM64 && ARCH_EXYNOS +config EXYNOS_ARM64_COMMON_CLK + bool "Samsung Exynos ARMv8-family clock controller support" if COMPILE_TEST + depends on COMMON_CLK_SAMSUNG + +# For S3C24XX platforms, select following symbols: config S3C2410_COMMON_CLK bool "Samsung S3C2410 clock controller support" if COMPILE_TEST select COMMON_CLK_SAMSUNG @@ -22,4 +31,3 @@ config S3C2412_COMMON_CLK config S3C2443_COMMON_CLK bool "Samsung S3C2443 clock controller support" if COMPILE_TEST select COMMON_CLK_SAMSUNG - diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index 5f6833ea355d..fc367d4b2902 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o -obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o