| Message ID | 1455668317-15728-2-git-send-email-stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner <stefan@agner.ch> wrote: > + reg_module_3v3: regulator-module-3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "+V3.3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; This 'regulator-always-on' property can be removed. > + }; > + > + reg_module_3v3_avdd: regulator-module-3v3-avdd { > + compatible = "regulator-fixed"; > + regulator-name = "+V3.3_AVDD_AUDIO"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; Same here.
On 2016-02-16 16:28, Fabio Estevam wrote: > On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner <stefan@agner.ch> wrote: > >> + reg_module_3v3: regulator-module-3v3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > This 'regulator-always-on' property can be removed. > >> + }; >> + >> + reg_module_3v3_avdd: regulator-module-3v3-avdd { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3_AVDD_AUDIO"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > Same here. Hm, should I remove them also in Patch 1/3? It's a fixed regulator too, hence I guess regulator-always-on is pointless there too...? -- Stefan
On Wed, Feb 17, 2016 at 7:52 PM, Stefan Agner <stefan@agner.ch> wrote: > Hm, should I remove them also in Patch 1/3? It's a fixed regulator too, > hence I guess regulator-always-on is pointless there too...? That's correct. And from 3/3 too.
diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi index ff6f58e..dcc73b7 100644 --- a/arch/arm/boot/dts/vf-colibri.dtsi +++ b/arch/arm/boot/dts/vf-colibri.dtsi @@ -48,14 +48,32 @@ enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>; status = "disabled"; }; + + reg_module_3v3: regulator-module-3v3 { + compatible = "regulator-fixed"; + regulator-name = "+V3.3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + reg_module_3v3_avdd: regulator-module-3v3-avdd { + compatible = "regulator-fixed"; + regulator-name = "+V3.3_AVDD_AUDIO"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; }; &adc0 { status = "okay"; + vref-supply = <®_module_3v3_avdd>; }; &adc1 { status = "okay"; + vref-supply = <®_module_3v3_avdd>; }; &can0 { @@ -96,6 +114,7 @@ &fec1 { phy-mode = "rmii"; + phy-supply = <®_module_3v3>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; };
Colibri modules need to be powered using the power pins 3V3 and AVDD_AUDIO. Add fixed regulators which represent this power rails. Potentially, those power rails could be switched on a carrier board. A carrier board device tree could add a own regulator with a GPIO, and reference that regulator in a vin-supply property of those new module level system regulators. Signed-off-by: Stefan Agner <stefan@agner.ch> --- Changes since v1: - Add module prefix to avoid namespace issue with Carrier Board regulators - Name the regulators according to schematics arch/arm/boot/dts/vf-colibri.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)