From patchwork Thu Feb 18 10:21:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 8348371 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3188FC0553 for ; Thu, 18 Feb 2016 10:23:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E6FBB2037F for ; Thu, 18 Feb 2016 10:23:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 348ED20375 for ; Thu, 18 Feb 2016 10:23:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aWLij-0003jv-OR; Thu, 18 Feb 2016 10:22:01 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aWLig-0003gq-0h for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2016 10:21:58 +0000 Received: by mail-wm0-x231.google.com with SMTP id a4so17934724wme.1 for ; Thu, 18 Feb 2016 02:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=PGJl2ow1SE6b+YphO7tedYxhU93fZ1owR+8cQOkFcy0=; b=yXZk/wvwK0jzVLp5YCc52fSd0EfLTJxi94j0TAI+41opQsd6Kg+fTgFtwves48oz/H cNYqcitRYg03nRc8YXZLGUmK2sYdXRDydMGiMtaO8Qzcl7ugxwey5DtrR3UbuJcFjEsp Oom97MSwUnjV+bFdCLD29JBeIqtcccmyCjpJqECYF96mFtDB7X+3s9sCZ4bXRNO2oGQ+ wNir344hL4Kg5CuPJZJ4WnG1N7kR+0KRCLIrua/Pf2uG3/c4QVPRRu9pN4gV1/NRDcTG DJRTlOrhLEth+FmhH7GIVfHweOQ0WsUUd06ZgUw0T8qJdt8PNxmWC2xlWaHAhltDlcP5 3xgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=PGJl2ow1SE6b+YphO7tedYxhU93fZ1owR+8cQOkFcy0=; b=fhtekP33jRewXFPt4XEGxIQR6wyumQF62l43XPWzZDzTlIaNq6jO2rxBqqUCeWloZV SjVY8+czVL/jhAtrq9WmCrlcCF0UKH4jhc3U1S11LwsewaxZpoLVvT4lBcpmxgVVVRcI RL57tElyOjBPimu5u42zBkEOf5fI4mgJb5ni/e+nEa2GlCMZhn3zrknEtRijj2OF6WJD dMH62BDeAxTJ2m26MyIiYR8xLRk/cm12a5QSTiaqC+0uga3O9A1QAYuR9s3eAxOw4K4l IvvJY/ti3022F/47DeuHuLvPcFQfp134iCa87gTt0VKski74AwDeeTq6QYU1hTRgmdPD DyKQ== X-Gm-Message-State: AG10YORetrA0zMGwakxWTxT7y3AFwcOfCpVN5lOz+HQMkG15LcqzNiO2jLHvjCr3F1NXoQ== X-Received: by 10.194.7.195 with SMTP id l3mr6576383wja.43.1455790896043; Thu, 18 Feb 2016 02:21:36 -0800 (PST) Received: from localhost.localdomain (146.187.3.109.rev.sfr.net. [109.3.187.146]) by smtp.gmail.com with ESMTPSA id s2sm5805660wjs.39.2016.02.18.02.21.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Feb 2016 02:21:35 -0800 (PST) From: Romain Izard To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Nicolas Ferre Subject: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node Date: Thu, 18 Feb 2016 11:21:06 +0100 Message-Id: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160218_022158_245000_39310289 X-CRM114-Status: GOOD ( 11.85 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux GPIO List , Linus Walleij , Alexandre Belloni , Romain Izard Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All pinctrl nodes for the Atmel pinctrl controller need to have their bias configuration explicitly defined. Otherwise, the pinctrl mapping is not valid. It works for now as the pinctrl driver proceeds even with invalid mappings, but this can become an issue, if the pinctrl driver starts to require valid mappings. Additionally, the pin is not protected from being remapped later by an other driver. There is an external 1k? pull-up to 3.3V, so no bias is required on the Ethernet PHY's interrupt line. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index e683856c507c..75341eec2dfd 100644 --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts @@ -308,6 +308,7 @@ pinctrl_macb0_phy_irq: macb0_phy_irq { pinmux = ; + bias-disable; }; pinctrl_pdmic_default: pdmic_default {