diff mbox

[1/4] ARM: dts: imx6ul: Add flexcan1 and flexcan2 support

Message ID 1455963652-24618-2-git-send-email-michael@amarulasolutions.com (mailing list archive)
State New, archived
Headers show

Commit Message

Michael Nazzareno Trimarchi Feb. 20, 2016, 10:20 a.m. UTC 
Add support for FLEXCAN1 and FLEXCAN2.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 arch/arm/boot/dts/imx6ul.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

Comments

Fabio Estevam Feb. 20, 2016, 2:02 p.m. UTC | #1 
On Sat, Feb 20, 2016 at 8:20 AM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:

> +
> +                               flexcan1: can@02090000 {
> +                                       compatible = "fsl,imx6ul-flexcan", "fsl,imx6q-flexcan";
> +                                       reg = <0x02090000 0x4000>;
> +                                       interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> +                                       clocks = <&clks IMX6UL_CLK_CAN1_IPG>,
> +                                                <&clks IMX6UL_CLK_CAN1_SERIAL>;
> +                                       clock-names = "ipg", "per";
> +                                       stop-mode = <&gpr 0x10 1 0x10 17>;

This 'stop-mode' property is not handled in mainline, only in NXP
kernel, so I suggest to drop this.
Michael Nazzareno Trimarchi Feb. 20, 2016, 5:18 p.m. UTC | #2 
Hi Fabio

On Sat, Feb 20, 2016 at 12:02:51PM -0200, Fabio Estevam wrote:
> On Sat, Feb 20, 2016 at 8:20 AM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> 
> > +
> > +                               flexcan1: can@02090000 {
> > +                                       compatible = "fsl,imx6ul-flexcan", "fsl,imx6q-flexcan";
> > +                                       reg = <0x02090000 0x4000>;
> > +                                       interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> > +                                       clocks = <&clks IMX6UL_CLK_CAN1_IPG>,
> > +                                                <&clks IMX6UL_CLK_CAN1_SERIAL>;
> > +                                       clock-names = "ipg", "per";
> > +                                       stop-mode = <&gpr 0x10 1 0x10 17>;
> 
> This 'stop-mode' property is not handled in mainline, only in NXP
> kernel, so I suggest to drop this.

ok. Can you point me out to a driver in freescale source that use it?

Michael
Fabio Estevam Feb. 20, 2016, 5:29 p.m. UTC | #3 
On Sat, Feb 20, 2016 at 3:18 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:

> ok. Can you point me out to a driver in freescale source that use it?

http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/net/can/flexcan.c?h=imx_3.14.52_1.1.0_ga#n1146
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 99b6465..cd32d1d 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -14,6 +14,8 @@ 
 
 / {
 	aliases {
+		can0 = &flexcan1;
+		can1 = &flexcan2;
 		ethernet0 = &fec1;
 		ethernet1 = &fec2;
 		gpio0 = &gpio1;
@@ -234,6 +236,28 @@ 
 					clock-names = "ipg", "per";
 					status = "disabled";
 				};
+
+				flexcan1: can@02090000 {
+					compatible = "fsl,imx6ul-flexcan", "fsl,imx6q-flexcan";
+					reg = <0x02090000 0x4000>;
+					interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clks IMX6UL_CLK_CAN1_IPG>,
+						 <&clks IMX6UL_CLK_CAN1_SERIAL>;
+					clock-names = "ipg", "per";
+					stop-mode = <&gpr 0x10 1 0x10 17>;
+					status = "disabled";
+				};
+
+				flexcan2: can@02094000 {
+					compatible = "fsl,imx6ul-flexcan", "fsl,imx6q-flexcan";
+					reg = <0x02094000 0x4000>;
+					interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clks IMX6UL_CLK_CAN2_IPG>,
+						 <&clks IMX6UL_CLK_CAN2_SERIAL>;
+					clock-names = "ipg", "per";
+					stop-mode = <&gpr 0x10 2 0x10 18>;
+					status = "disabled";
+				};
 			};
 
 			gpt1: gpt@02098000 {