| Message ID | 1456393568-28363-1-git-send-email-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Philipp, On Thu, Feb 25, 2016 at 10:46:08AM +0100, Philipp Zabel wrote: > The pmu_reset_ops structure is never modified. Make it const. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked > the ops pointer in struct reset_controller_dev as const, this struct can > be made const, too. The commit is currently sitting in the > arm-soc/for-next branch. Please include this in the commit body. All except the last sentence. > --- > drivers/soc/dove/pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) With that, Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason.
diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c index 039374e..95d77ec 100644 --- a/drivers/soc/dove/pmu.c +++ b/drivers/soc/dove/pmu.c @@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id) return 0; } -static struct reset_control_ops pmu_reset_ops = { +static const struct reset_control_ops pmu_reset_ops = { .reset = pmu_reset_reset, .assert = pmu_reset_assert, .deassert = pmu_reset_deassert,
The pmu_reset_ops structure is never modified. Make it const. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- Since commit 203d4f347d86 ("reset: Make reset_control_ops const") marked the ops pointer in struct reset_controller_dev as const, this struct can be made const, too. The commit is currently sitting in the arm-soc/for-next branch. --- drivers/soc/dove/pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)