From patchwork Fri Mar 11 07:49:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 8562901 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 494229F46A for ; Fri, 11 Mar 2016 07:51:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8586620361 for ; Fri, 11 Mar 2016 07:51:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A60EF2026D for ; Fri, 11 Mar 2016 07:51:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aeHpv-0001Ba-K8; Fri, 11 Mar 2016 07:50:15 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aeHpi-0000Qt-Ge for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2016 07:50:02 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3V00B9F72QHJ60@mailout2.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2016 07:49:38 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-5e-56e27892ebfe Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 9A.5F.21385.29872E65; Fri, 11 Mar 2016 07:49:38 +0000 (GMT) Received: from localhost.localdomain ([10.113.63.52]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O3V00KWE72HYU40@eusync2.samsung.com>; Fri, 11 Mar 2016 07:49:38 +0000 (GMT) From: Krzysztof Kozlowski To: Matt Mackall , Herbert Xu , Kukjin Kim , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] hwrng: exynos - Runtime suspend device after init Date: Fri, 11 Mar 2016 16:49:19 +0900 Message-id: <1457682562-21219-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 2.5.0 In-reply-to: <1457682562-21219-1-git-send-email-k.kozlowski@samsung.com> References: <1457682562-21219-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFLMWRmVeSWpSXmKPExsVy+t/xK7qTKh6FGZz7J2/R/UrG4vULQ4v+ x6+ZLTY9vsZqcf/eTyaLy7vmsFnMOL+PyWLBtj5GBw6PbQdUPTat6mTz2Lyk3qNvyypGj76X Gxg9Pm+SC2CL4rJJSc3JLEst0rdL4MqYs+EOY8EtjopXe44yNzDuYO9i5OSQEDCR+L10OhOE LSZx4d56ti5GLg4hgaWMEg9vXGWHcP4zSvT/PsoGUsUmYCyxefkSsCoRgW+MEj8enmMESTAL GEr8fPcHbKywgJvE2XVTweIsAqoSG9dtZAaxeQXcJdY++gxUwwG0Tk5iwYV0kDCngIdE45ZP YPOFgEpW3jzKNoGRdwEjwypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkBD7uoNx6TGrQ4wC HIxKPLwfrj0ME2JNLCuuzD3EKMHBrCTCm1n8KEyINyWxsiq1KD++qDQntfgQozQHi5I478xd 70OEBNITS1KzU1MLUotgskwcnFINjEUafrET1HUftOjJxbfEcZQkdd50eDPBNufJs++FfUG9 s7Z7vX6vcGRfwKdFK44kKSVsmMRxbadStfjO2OOCBts9Hm+57VhpuDib7Vbwopl7bWcYOGyw K2b+fTppv4b1NE/VQwetZnN+n6chKeM+OUT63OrLTP87Mq6x5dzSfcrCF79QJPh7thJLcUai oRZzUXEiAGdlB/AtAgAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160310_235002_729882_B9D112FA X-CRM114-Status: GOOD ( 16.66 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver uses pm_runtime_put_noidle() after initialization so the device might remain in active state if the core does not read from it (the read callback contains regular runtime put). The put_noidle() was chosen probably to avoid unneeded suspend and resume cycle after the initialization. However for this purpose autosuspend is enabled so it is safe to runtime put just after the initialization. Signed-off-by: Krzysztof Kozlowski --- drivers/char/hw_random/exynos-rng.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c index ada081232528..d1fd21e99368 100644 --- a/drivers/char/hw_random/exynos-rng.c +++ b/drivers/char/hw_random/exynos-rng.c @@ -77,7 +77,8 @@ static int exynos_init(struct hwrng *rng) pm_runtime_get_sync(exynos_rng->dev); ret = exynos_rng_configure(exynos_rng); - pm_runtime_put_noidle(exynos_rng->dev); + pm_runtime_mark_last_busy(exynos_rng->dev); + pm_runtime_put_autosuspend(exynos_rng->dev); return ret; }