diff mbox

[v2,1/9] ARM: dts: imx7d: add lcdif support

Message ID 1458050668-26748-2-git-send-email-gary.bisson@boundarydevices.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gary Bisson March 15, 2016, 2:04 p.m. UTC 
Add the device node for the i.MX7 eLCDIF interface.

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---

Changelog v1 -> v2:
- none

---
 arch/arm/boot/dts/imx7d.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Shawn Guo April 2, 2016, 1:29 a.m. UTC | #1 
On Tue, Mar 15, 2016 at 03:04:20PM +0100, Gary Bisson wrote:
> Add the device node for the i.MX7 eLCDIF interface.
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> 
> Changelog v1 -> v2:
> - none
> 
> ---
>  arch/arm/boot/dts/imx7d.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index b5a50e0..a768716 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -608,6 +608,17 @@
>  				status = "disabled";
>  			};
>  
> +			lcdif: lcdif@30730000 {

Please add the node in order of unit-address.

Shawn

> +				compatible = "fsl,imx7d-lcdif", "fsl,imx28-lcdif";
> +				reg = <0x30730000 0x10000>;
> +				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_LCDIF_PIXEL_ROOT_CLK>,
> +					<&clks IMX7D_CLK_DUMMY>,
> +					<&clks IMX7D_CLK_DUMMY>;
> +				clock-names = "pix", "axi", "disp_axi";
> +				status = "disabled";
> +			};
> +
>  			pwm1: pwm@30660000 {
>  				compatible = "fsl,imx7d-pwm", "fsl,imx27-pwm";
>  				reg = <0x30660000 0x10000>;
> -- 
> 2.7.0
> 
>
Gary Bisson April 2, 2016, 4:08 p.m. UTC | #2 
Shawn, All,

On Sat, Apr 2, 2016 at 3:29 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Tue, Mar 15, 2016 at 03:04:20PM +0100, Gary Bisson wrote:
>> Add the device node for the i.MX7 eLCDIF interface.
>>
>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>> ---
>>
>> Changelog v1 -> v2:
>> - none
>>
>> ---
>>  arch/arm/boot/dts/imx7d.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
>> index b5a50e0..a768716 100644
>> --- a/arch/arm/boot/dts/imx7d.dtsi
>> +++ b/arch/arm/boot/dts/imx7d.dtsi
>> @@ -608,6 +608,17 @@
>>                               status = "disabled";
>>                       };
>>
>> +                     lcdif: lcdif@30730000 {
>
> Please add the node in order of unit-address.

Sorry I did it alphabetically for some reason, I'll submit a v3 today.

Regards,
Gary
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index b5a50e0..a768716 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -608,6 +608,17 @@ 
 				status = "disabled";
 			};
 
+			lcdif: lcdif@30730000 {
+				compatible = "fsl,imx7d-lcdif", "fsl,imx28-lcdif";
+				reg = <0x30730000 0x10000>;
+				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_LCDIF_PIXEL_ROOT_CLK>,
+					<&clks IMX7D_CLK_DUMMY>,
+					<&clks IMX7D_CLK_DUMMY>;
+				clock-names = "pix", "axi", "disp_axi";
+				status = "disabled";
+			};
+
 			pwm1: pwm@30660000 {
 				compatible = "fsl,imx7d-pwm", "fsl,imx27-pwm";
 				reg = <0x30660000 0x10000>;