From patchwork Thu Mar 24 05:07:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 8658051 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F1B749FEE9 for ; Thu, 24 Mar 2016 05:13:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B7B020364 for ; Thu, 24 Mar 2016 05:13:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40F112035B for ; Thu, 24 Mar 2016 05:13:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aixYW-00012N-P2; Thu, 24 Mar 2016 05:11:36 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aixYQ-00010d-T0 for linux-arm-kernel@lists.infradead.org; Thu, 24 Mar 2016 05:11:32 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u2O59Cta027788; Wed, 23 Mar 2016 22:11:06 -0700 Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 21s44mkkjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Mar 2016 22:11:06 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 23 Mar 2016 22:11:05 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server id 15.0.1104.5 via Frontend Transport; Wed, 23 Mar 2016 22:11:04 -0700 Received: from xhacker.marvell.com (unknown [10.37.135.134]) by maili.marvell.com (Postfix) with ESMTP id 0ADEB3F7043; Wed, 23 Mar 2016 22:11:03 -0700 (PDT) From: Jisheng Zhang To: , Subject: [PATCH] cpuidle: arm: make enter idle operation a bit more efficient Date: Thu, 24 Mar 2016 13:07:18 +0800 Message-ID: <1458796038-6062-1-git-send-email-jszhang@marvell.com> X-Mailer: git-send-email 2.8.0.rc3 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-03-24_02:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603240077 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160323_221130_960954_3E4E0BA0 X-CRM114-Status: GOOD ( 11.48 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, entering idle need to check the idx every time to choose the real entering idle routine. But this check could be avoided by pointing the idle enter function pointer of each idle states to the routines suitable for each states directly. Signed-off-by: Jisheng Zhang --- drivers/cpuidle/cpuidle-arm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index 545069d..48a620f 100644 --- a/drivers/cpuidle/cpuidle-arm.c +++ b/drivers/cpuidle/cpuidle-arm.c @@ -23,6 +23,13 @@ #include "dt_idle_states.h" +static int arm_enter_wfi_state(struct cpuidle_device *dev, + struct cpuidle_driver *drv, int idx) +{ + cpu_do_idle(); + return 0; +} + /* * arm_enter_idle_state - Programs CPU to enter the specified state * @@ -38,11 +45,6 @@ static int arm_enter_idle_state(struct cpuidle_device *dev, { int ret; - if (!idx) { - cpu_do_idle(); - return idx; - } - ret = cpu_pm_enter(); if (!ret) { /* @@ -69,7 +71,7 @@ static struct cpuidle_driver arm_idle_driver = { * handler for idle state index 0. */ .states[0] = { - .enter = arm_enter_idle_state, + .enter = arm_enter_wfi_state, .exit_latency = 1, .target_residency = 1, .power_usage = UINT_MAX,