From patchwork Wed Apr 6 02:25:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 8757601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 252759F336 for ; Wed, 6 Apr 2016 02:32:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 58E1A202A1 for ; Wed, 6 Apr 2016 02:32:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9352420295 for ; Wed, 6 Apr 2016 02:32:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1andEY-00014b-SO; Wed, 06 Apr 2016 02:30:18 +0000 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1andCz-0007jP-4l for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2016 02:28:42 +0000 Received: by mail-pa0-x22c.google.com with SMTP id bx7so6607966pad.3 for ; Tue, 05 Apr 2016 19:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CuKEmUdWQl1WQGrftsu7eWbV9DOKqpP8oCeqPIFudSU=; b=n0dwVdGRhQv8CZINFnfK/r22ME3yJAI5YMLBsC1JyLTXRBwxKae4h7fyD0EWhBmviI KTmM5bPjruWQHIVcli38cJS1lRTy+S7hvuN6XkpWJkeEmSRR1kNsEnB8ZCtaakMz6Rjt redJBgZjs64XolDmYm248jSmGOneJlLRhTxiw8aa6xqMXsLcaaJ1TdvLGWE/lS6dUOwb mZBFjGJQCah8vJR/PZPNg2qHwodB1ii3k+NuKjXlJPWMzYABHUl64lEE8afM8qPKhnrZ 3WH2wBmO+IDKBafxcHRwQ7icMm3oq2ywPJgJ1hclijTIjBevCU7C7mC8N7A8dh9omCya lbUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CuKEmUdWQl1WQGrftsu7eWbV9DOKqpP8oCeqPIFudSU=; b=LtBF9HPa9W0srSbCdfjDU9NBW/Y6cghSqucjVPQDZSdXiU3GOm4up4S5NBLK4xZuQC KOUAlFAB0ES3LNxa4Smg5Nj9uvCSSpTFWVuw1O1GZc/EBvOIkzaYGDjdZ1nhzXWKdPQk f/bpRNxOkRfNsJwHMKGEuduG1yI6sRoZIBqN5kOzH/nqfebtPNZd2ngqy/sYRlnSfNbZ fub+8fEdjJq6Sl4SkOHozqM4Q4KWQOTgNDCKQpyYOILqKj8NAC6/LqYM8gaKUbPnR7Id PqrKqp+hlWYgt0e1K6YR3eFVLviqCsROCUYO4LzGwkQHJyuAjod+oLG8Rna+jeVuQGFd Ixrg== X-Gm-Message-State: AD7BkJIJZdhaNQIw2/eSDuv8lMJ/h3U5MhqiV3XFFrFB15QUBZBk4OvIcb2X/otoC/Gdfw== X-Received: by 10.66.122.100 with SMTP id lr4mr64995352pab.99.1459909700347; Tue, 05 Apr 2016 19:28:20 -0700 (PDT) Received: from localhost.localdomain (wsip-70-184-93-199.ph.ph.cox.net. [70.184.93.199]) by smtp.googlemail.com with ESMTPSA id l14sm528682pfi.23.2016.04.05.19.28.18 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2016 19:28:19 -0700 (PDT) From: Troy Kisky To: netdev@vger.kernel.org, davem@davemloft.net, fugang.duan@nxp.com, lznuaa@gmail.com Subject: [PATCH net-next V3 07/16] net: fec: don't clear all rx queue bits when just one is being checked Date: Tue, 5 Apr 2016 19:25:53 -0700 Message-Id: <1459909562-22865-8-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1459909562-22865-1-git-send-email-troy.kisky@boundarydevices.com> References: <1459909562-22865-1-git-send-email-troy.kisky@boundarydevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160405_192841_530060_7C1E6028 X-CRM114-Status: GOOD ( 11.45 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, stillcompiling@gmail.com, arnd@arndb.de, sergei.shtylyov@cogentembedded.com, Troy Kisky , gerg@uclinux.org, fabio.estevam@nxp.com, johannes@sipsolutions.net, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, tremyfr@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since tx/rx interrupts are now cleared in the napi routine and not the interrupt, it is not needed here any longer. Signed-off-by: Troy Kisky --- v3: change commit message --- drivers/net/ethernet/freescale/fec_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 17140ea..3cd0cdf 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1339,8 +1339,6 @@ static int fec_rxq(struct net_device *ndev, struct fec_enet_priv_rx_q *rxq, break; pkt_received++; - writel(FEC_ENET_RXF, fep->hwp + FEC_IEVENT); - /* Check for errors. */ status ^= BD_ENET_RX_LAST; if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO |