| Message ID | 1460636437-21764-2-git-send-email-slemieux.tyco@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Vladimir, On Mon, 2016-04-18 at 05:39 +0300, Vladimir Zapolskiy wrote: > Hi Sylvain, > > On 14.04.2016 15:20, slemieux.tyco@gmail.com wrote: > > From: Sylvain Lemieux <slemieux@tycoint.com> > > > > The change adds clock properties to spi peripheral devices, > > clock ids are taken from dt-bindings/clock/lpc32xx-clock.h > > > > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com> > > --- > > arch/arm/boot/dts/lpc32xx.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi > > index c58d8da..0b6a643 100644 > > --- a/arch/arm/boot/dts/lpc32xx.dtsi > > +++ b/arch/arm/boot/dts/lpc32xx.dtsi > > @@ -173,6 +173,8 @@ > > spi1: spi@20088000 { > > compatible = "nxp,lpc3220-spi"; > > reg = <0x20088000 0x1000>; > > + clocks = <&clk LPC32XX_CLK_SPI1>; > > + clock-names = "apb_pclk"; > > I'm not sure that here is a correct clock name, and it looks like it > is copied from some PrimeCell device node, may be "arm,pl022" SPI. > > Reasons to NOT add clock-names property: > * the name is one in one PrimeCell clock name, which may be confusing, > * there is no "nxp,lpc3220-spi" SPI controller driver in the mainline, > * there is no documented description of controller's properties, > * the controller has only one clock, so I believe "clock-names" > is redundant here. > I will try without the clock name, and, update the patch accordingly. > I don't object against adding "clocks" property, but no public driver > means no testing, unfortunately. > > FWIW there was an attempt to add the driver of pretty bad quality, We are currently using our own SPI driver with limited functionality; the driver support polling mode only. We did not submit the driver, because of the limited support. > and it does not define a "clock-names" property [1]. > > > }; > > > > ssp1: ssp@2008c000 { > > @@ -186,6 +188,8 @@ > > spi2: spi@20090000 { > > compatible = "nxp,lpc3220-spi"; > > reg = <0x20090000 0x1000>; > > + clocks = <&clk LPC32XX_CLK_SPI2>; > > + clock-names = "apb_pclk"; > > Same as above. > > > }; > > > > i2s0: i2s@20094000 { > > > > [1] https://lkml.org/lkml/2015/7/12/61 > > -- > With best wishes, > Vladimir
diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi index c58d8da..0b6a643 100644 --- a/arch/arm/boot/dts/lpc32xx.dtsi +++ b/arch/arm/boot/dts/lpc32xx.dtsi @@ -173,6 +173,8 @@ spi1: spi@20088000 { compatible = "nxp,lpc3220-spi"; reg = <0x20088000 0x1000>; + clocks = <&clk LPC32XX_CLK_SPI1>; + clock-names = "apb_pclk"; }; ssp1: ssp@2008c000 { @@ -186,6 +188,8 @@ spi2: spi@20090000 { compatible = "nxp,lpc3220-spi"; reg = <0x20090000 0x1000>; + clocks = <&clk LPC32XX_CLK_SPI2>; + clock-names = "apb_pclk"; }; i2s0: i2s@20094000 {