| Message ID | 1461666272-10107-1-git-send-email-nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
From: Nicolas Ferre <nicolas.ferre@atmel.com> Date: Tue, 26 Apr 2016 12:24:32 +0200 > I plan to queue this patch through arm-soc for 4.7. Ok.
Hello. On 04/26/2016 01:24 PM, Nicolas Ferre wrote: > Fix gpio active flag for the phy reset-gpios property. The line is > active low instead of active high. > Actually, this flags was never used by the macb driver. > > Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: David Miller <davem@davemloft.net> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > Hi, > > Thanks for having reported this bug to me. And thank you for beating me to it and doing the patch. I'm still busy with other stuff. :-( > I hope that we will be able to move forward for changing the phy > reset code in the macb driver. I meant to delete it entirely. > I plan to queue this patch through arm-soc for 4.7. Hm, that way we get that board broken if my phylib/macb patches get merged before your patch. Perhaps it would be better to merge this patch thru DaveM's tree (before my patches) to keep the kernel bisectable? > Thanks, best regards, > Nicolas MBR, Sergei
On 04/26/2016 08:17 PM, David Miller wrote: >> I plan to queue this patch through arm-soc for 4.7. > > Ok. How about this patch going thru your net-next repo instead? I'd like to keep the kernel bisectable... if my phylib/macb patches get merged earlier than this one, that board would be broken... MBR, Sergei
Le 26/04/2016 20:27, Sergei Shtylyov a écrit : > On 04/26/2016 08:17 PM, David Miller wrote: > >>> I plan to queue this patch through arm-soc for 4.7. >> >> Ok. > > How about this patch going thru your net-next repo instead? > I'd like to keep the kernel bisectable... if my phylib/macb patches get merged > earlier than this one, that board would be broken... Sergei, David, I don't think that there is a big risk for this board to be tested in the meantime as it's not widely deployed yet. And as I'm aware of the issue and basically maintaining this DT file, I think that I'll be informed if people try an unlikely arrangement of patches on this board. So either way, I'm okay. But I do think it's not worth thinking too much about this case. Bye,
diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts index 79aec55e1ebc..6a366ee952a8 100644 --- a/arch/arm/boot/dts/at91-vinco.dts +++ b/arch/arm/boot/dts/at91-vinco.dts @@ -118,7 +118,7 @@ ethernet-phy@1 { reg = <0x1>; - reset-gpios = <&pioE 8 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pioE 8 GPIO_ACTIVE_LOW>; interrupt-parent = <&pioB>; interrupts = <15 IRQ_TYPE_EDGE_FALLING>; }; @@ -162,7 +162,7 @@ reg = <0x1>; interrupt-parent = <&pioB>; interrupts = <31 IRQ_TYPE_EDGE_FALLING>; - reset-gpios = <&pioE 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pioE 6 GPIO_ACTIVE_LOW>; }; };
Fix gpio active flag for the phy reset-gpios property. The line is active low instead of active high. Actually, this flags was never used by the macb driver. Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: Andrew Lunn <andrew@lunn.ch> Cc: David Miller <davem@davemloft.net> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- Hi, Thanks for having reported this bug to me. I hope that we will be able to move forward for changing the phy reset code in the macb driver. I plan to queue this patch through arm-soc for 4.7. Thanks, best regards, Nicolas arch/arm/boot/dts/at91-vinco.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)