From patchwork Tue Apr 26 12:57:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 8938521 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8E887BF29F for ; Tue, 26 Apr 2016 13:04:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A4B9F20148 for ; Tue, 26 Apr 2016 13:04:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EF8D2015A for ; Tue, 26 Apr 2016 13:04:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1av2dZ-0000nn-3e; Tue, 26 Apr 2016 13:02:45 +0000 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1av2cs-0000EG-JI for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2016 13:02:03 +0000 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u3QCubZa022163; Tue, 26 Apr 2016 06:01:41 -0700 Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 22g8jfqsqb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 26 Apr 2016 06:01:41 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Tue, 26 Apr 2016 06:01:39 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server id 15.0.1104.5 via Frontend Transport; Tue, 26 Apr 2016 06:01:39 -0700 Received: from xhacker.marvell.com (unknown [10.37.130.134]) by maili.marvell.com (Postfix) with ESMTP id 6A51E3F7040; Tue, 26 Apr 2016 06:01:38 -0700 (PDT) From: Jisheng Zhang To: , Subject: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Date: Tue, 26 Apr 2016 20:57:39 +0800 Message-ID: <1461675460-2295-7-git-send-email-jszhang@marvell.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1461675460-2295-1-git-send-email-jszhang@marvell.com> References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-04-26_07:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1604260210 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160426_060202_898728_D67F8307 X-CRM114-Status: GOOD ( 14.11 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , yendapally.reddy@broadcom.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Marvell BG4CT SoC needs two phy: one for usb2 and another for usb3. Add the calls to retrieve generic PHY to xhci plat in order to support this. Signed-off-by: Jisheng Zhang --- drivers/usb/host/xhci-plat.c | 87 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 75 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 83669d0..d7f4f3c 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -134,6 +135,37 @@ static const struct of_device_id usb_xhci_of_match[] = { MODULE_DEVICE_TABLE(of, usb_xhci_of_match); #endif +static int xhci_plat_phy_init(struct usb_hcd *hcd) +{ + int ret; + + if (hcd->phy) { + ret = phy_init(hcd->phy); + if (ret) + return ret; + + ret = phy_power_on(hcd->phy); + if (ret) { + phy_exit(hcd->phy); + return ret; + } + } else { + ret = usb_phy_init(hcd->usb_phy); + } + + return ret; +} + +static void xhci_plat_phy_exit(struct usb_hcd *hcd) +{ + if (hcd->phy) { + phy_power_off(hcd->phy); + phy_exit(hcd->phy); + } else { + usb_phy_shutdown(hcd->usb_phy); + } +} + static int xhci_plat_probe(struct platform_device *pdev) { struct device_node *node = pdev->dev.of_node; @@ -145,6 +177,7 @@ static int xhci_plat_probe(struct platform_device *pdev) struct usb_hcd *hcd; struct clk *clk; struct usb_phy *usb_phy; + struct phy *phy; int ret; int irq; @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev) if (HCC_MAX_PSA(xhci->hcc_params) >= 4) xhci->shared_hcd->can_do_streams = 1; + hcd->phy = devm_phy_get(&pdev->dev, "usb2-phy"); + if (IS_ERR(hcd->phy)) { + ret = PTR_ERR(hcd->phy); + if (ret == -EPROBE_DEFER) + goto put_usb3_hcd; + hcd->phy = NULL; + } + + phy = devm_phy_get(&pdev->dev, "usb-phy"); + if (IS_ERR(phy)) { + ret = PTR_ERR(phy); + if (ret == -EPROBE_DEFER) + goto put_usb3_hcd; + phy = NULL; + } + usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); if (IS_ERR(usb_phy)) { ret = PTR_ERR(usb_phy); if (ret == -EPROBE_DEFER) goto put_usb3_hcd; usb_phy = NULL; - } else { - ret = usb_phy_init(usb_phy); - if (ret) - goto put_usb3_hcd; } + xhci->shared_hcd->usb_phy = usb_phy; + xhci->shared_hcd->phy = phy; + + ret = xhci_plat_phy_init(hcd); + if (ret) + goto put_usb3_hcd; + + ret = xhci_plat_phy_init(xhci->shared_hcd); + if (ret) + goto disable_usb2_phy; ret = usb_add_hcd(hcd, irq, IRQF_SHARED); if (ret) - goto disable_usb_phy; + goto disable_usb3_phy; ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED); if (ret) @@ -259,8 +314,11 @@ static int xhci_plat_probe(struct platform_device *pdev) dealloc_usb2_hcd: usb_remove_hcd(hcd); -disable_usb_phy: - usb_phy_shutdown(usb_phy); +disable_usb3_phy: + xhci_plat_phy_exit(xhci->shared_hcd); + +disable_usb2_phy: + xhci_plat_phy_exit(hcd); put_usb3_hcd: usb_put_hcd(xhci->shared_hcd); @@ -281,11 +339,11 @@ static int xhci_plat_remove(struct platform_device *dev) struct clk *clk = xhci->clk; usb_remove_hcd(xhci->shared_hcd); - usb_phy_shutdown(xhci->shared_hcd->usb_phy); - - usb_remove_hcd(hcd); + xhci_plat_phy_exit(xhci->shared_hcd); usb_put_hcd(xhci->shared_hcd); + usb_remove_hcd(hcd); + xhci_plat_phy_exit(hcd); clk_disable_unprepare(clk); usb_put_hcd(hcd); @@ -311,7 +369,8 @@ static int xhci_plat_suspend(struct device *dev) if (ret) return ret; - usb_phy_shutdown(xhci->shared_hcd->usb_phy); + xhci_plat_phy_exit(xhci->shared_hcd); + xhci_plat_phy_exit(hcd); clk_disable_unprepare(xhci->clk); return ret; @@ -327,7 +386,11 @@ static int xhci_plat_resume(struct device *dev) if (ret) return ret; - ret = usb_phy_init(xhci->shared_hcd->usb_phy); + ret = xhci_plat_phy_init(hcd); + if (ret) + return ret; + + ret = xhci_plat_phy_init(xhci->shared_hcd); if (ret) return ret;