| Message ID | 1461831730-5575-6-git-send-email-eric.auger@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28/04/16 09:22, Eric Auger wrote: > The purpose is to be able to retrieve the MSI doorbells of an irqchip. > This is now needed since on some platforms those doorbells must be > iommu mapped (in case the MSIs transit through an IOMMU that do not > bypass those transactions). > > The assumption is there is a maximum of one doorbell region per cpu. > > A doorbell region is characterized by its physical address base, size and > IOMMU protection flag. Those 2 last characteristics are shared among all > doorbells. > > irq_chip msi_doorbell_info callback enables to retrieve the doorbells of > the irqchip. > > Signed-off-by: Eric Auger <eric.auger@linaro.org> > > --- > v7 -> v8: > - size and prot now are shared among all doorbells > - doorbells now directly points to a percpu phys_addr_t > > v7: creation > --- > include/linux/irq.h | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/include/linux/irq.h b/include/linux/irq.h > index c4de623..5dbb26d 100644 > --- a/include/linux/irq.h > +++ b/include/linux/irq.h > @@ -312,6 +312,19 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d) > return d->hwirq; > } > > +/* > + * Describe all the MSI doorbell regions for an irqchip. > + * A single doorbell region per cpu is assumed. > + * In case a single doorbell is supported for the whole irqchip, > + * the region is described in as cpu #0's one > + */ > +struct irq_chip_msi_doorbell_info { > + phys_addr_t __percpu *percpu_doorbells; /* per cpu base address */ Here's an idea: you could turn this field into a union: union { phys_addr_t __percpu *percpu_doorbells; phys_addr_t global_doorbell; }; > + size_t size; /* size of a each doorbell */ > + int prot; /* iommu protection flag */ > + int nb_doorbells; And this can be turned into a boolean: bool doorbell_is_percpu; This allows you to avoid allocating a bunch of percpu doorbells for a MSI controller that only has a global one. And the number of doorbells is always either 1 or the number of CPUs anyway. Thanks, M.
diff --git a/include/linux/irq.h b/include/linux/irq.h index c4de623..5dbb26d 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -312,6 +312,19 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d) return d->hwirq; } +/* + * Describe all the MSI doorbell regions for an irqchip. + * A single doorbell region per cpu is assumed. + * In case a single doorbell is supported for the whole irqchip, + * the region is described in as cpu #0's one + */ +struct irq_chip_msi_doorbell_info { + phys_addr_t __percpu *percpu_doorbells; /* per cpu base address */ + size_t size; /* size of a each doorbell */ + int prot; /* iommu protection flag */ + int nb_doorbells; +}; + /** * struct irq_chip - hardware interrupt chip descriptor * @@ -349,6 +362,7 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d) * @irq_get_irqchip_state: return the internal state of an interrupt * @irq_set_irqchip_state: set the internal state of a interrupt * @irq_set_vcpu_affinity: optional to target a vCPU in a virtual machine + * @msi_doorbell_info: return the MSI doorbell info * @ipi_send_single: send a single IPI to destination cpus * @ipi_send_mask: send an IPI to destination cpus in cpumask * @flags: chip specific flags @@ -394,7 +408,8 @@ struct irq_chip { int (*irq_set_irqchip_state)(struct irq_data *data, enum irqchip_irq_state which, bool state); int (*irq_set_vcpu_affinity)(struct irq_data *data, void *vcpu_info); - + struct irq_chip_msi_doorbell_info *(*msi_doorbell_info)( + struct irq_data *data); void (*ipi_send_single)(struct irq_data *data, unsigned int cpu); void (*ipi_send_mask)(struct irq_data *data, const struct cpumask *dest);
The purpose is to be able to retrieve the MSI doorbells of an irqchip. This is now needed since on some platforms those doorbells must be iommu mapped (in case the MSIs transit through an IOMMU that do not bypass those transactions). The assumption is there is a maximum of one doorbell region per cpu. A doorbell region is characterized by its physical address base, size and IOMMU protection flag. Those 2 last characteristics are shared among all doorbells. irq_chip msi_doorbell_info callback enables to retrieve the doorbells of the irqchip. Signed-off-by: Eric Auger <eric.auger@linaro.org> --- v7 -> v8: - size and prot now are shared among all doorbells - doorbells now directly points to a percpu phys_addr_t v7: creation --- include/linux/irq.h | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)