| Message ID | 1465403758-2173-1-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ben, On 6/8/2016 9:35 AM, Ben Dooks wrote: > Fix a warning of kona_l2_cache_init() not being declared by > including the header file kona_l2_cache.h which defines it > thus fixing: > > arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol 'kona_l2_cache_init' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/mach-bcm/kona_l2_cache.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-bcm/kona_l2_cache.c b/arch/arm/mach-bcm/kona_l2_cache.c > index b319703..59ad863 100644 > --- a/arch/arm/mach-bcm/kona_l2_cache.c > +++ b/arch/arm/mach-bcm/kona_l2_cache.c > @@ -17,6 +17,7 @@ > #include <asm/hardware/cache-l2x0.h> > > #include "bcm_kona_smc.h" > +#include "kona_l2_cache.h" > > void __init kona_l2_cache_init(void) > { > Thanks for fixing all these. Acked-by: Ray Jui <ray.jui@broadcom.com>
On 06/08/2016 09:40 AM, Ray Jui wrote: > Hi Ben, > > On 6/8/2016 9:35 AM, Ben Dooks wrote: >> Fix a warning of kona_l2_cache_init() not being declared by >> including the header file kona_l2_cache.h which defines it >> thus fixing: >> >> arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol >> 'kona_l2_cache_init' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > Acked-by: Ray Jui <ray.jui@broadcom.com> Applied, thanks!
diff --git a/arch/arm/mach-bcm/kona_l2_cache.c b/arch/arm/mach-bcm/kona_l2_cache.c index b319703..59ad863 100644 --- a/arch/arm/mach-bcm/kona_l2_cache.c +++ b/arch/arm/mach-bcm/kona_l2_cache.c @@ -17,6 +17,7 @@ #include <asm/hardware/cache-l2x0.h> #include "bcm_kona_smc.h" +#include "kona_l2_cache.h" void __init kona_l2_cache_init(void) {
Fix a warning of kona_l2_cache_init() not being declared by including the header file kona_l2_cache.h which defines it thus fixing: arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol 'kona_l2_cache_init' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/mach-bcm/kona_l2_cache.c | 1 + 1 file changed, 1 insertion(+)