From patchwork Thu Jun 9 01:35:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 9166121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B111F60572 for ; Thu, 9 Jun 2016 01:36:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A14CC28294 for ; Thu, 9 Jun 2016 01:36:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9352028307; Thu, 9 Jun 2016 01:36:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2823428294 for ; Thu, 9 Jun 2016 01:36:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAosl-0004Mr-S6; Thu, 09 Jun 2016 01:35:39 +0000 Received: from resqmta-po-04v.sys.comcast.net ([2001:558:fe16:19:96:114:154:163]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAosk-0004Je-4C for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2016 01:35:38 +0000 Received: from resomta-po-13v.sys.comcast.net ([96.114.154.237]) by resqmta-po-04v.sys.comcast.net with SMTP id AosMbcYL2wN2qAosPbrSxY; Thu, 09 Jun 2016 01:35:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1465436117; bh=Sh9eVo4m4wg84S0ID80ModVgk6qSAdxRVM1AJCJae/Y=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=WhRxaEW4hu7M7hI5Y2IBCRIyECNM00QathZp1eYFxb9IhGpFMhQPmTIPa9QtFNT/5 sKcjdPQ1D4CJwTMMTdLQ66xAeiIgM7mMh7km7mOnHVo0L+0RPC9/9VO+IVY+3kHPtC ZSTl82wO+umJei6rnNEJ9v3cnxc5XQR29p8idwRChcvPAanpGot+OvCK/rHKzWNLMK QyFKb4Pl9hPu6EqAO5h40ze+JDXaOlFSxe1UUso38yaFrb705PvJZX2dMtYfb49NLK gZW+zxywhqLDlclCEkDzoY6pSuDEifWRGtWKN8niHJuz8Twyg33eAz+c9NszeDrDnN TAD2Bk6LEk8Jg== Received: from mail.gonehiking.org ([73.181.52.62]) by resomta-po-13v.sys.comcast.net with comcast id 4RbG1t00D1LXgTt01RbGKK; Thu, 09 Jun 2016 01:35:16 +0000 Received: from shuah-XPS-13-9350.sisa.samsung.com (shuah-xps.internal [192.168.1.87]) by mail.gonehiking.org (Postfix) with ESMTP id 1C7999F301; Wed, 8 Jun 2016 19:35:16 -0600 (MDT) From: Shuah Khan To: kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@osg.samsung.com Subject: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove() Date: Wed, 8 Jun 2016 19:35:15 -0600 Message-Id: <1465436115-13880-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160608_183538_227795_C9F7886A X-CRM114-Status: UNSURE ( 5.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP s5p_mfc_remove() fails to release encoder and decoder video devices. Signed-off-by: Shuah Khan Reviewed-by: Javier Martinez Canillas --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 274b4f1..af61f54 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1317,7 +1317,9 @@ static int s5p_mfc_remove(struct platform_device *pdev) destroy_workqueue(dev->watchdog_workqueue); video_unregister_device(dev->vfd_enc); + video_device_release(dev->vfd_enc); video_unregister_device(dev->vfd_dec); + video_device_release(dev->vfd_dec); v4l2_device_unregister(&dev->v4l2_dev); s5p_mfc_release_firmware(dev); vb2_dma_contig_cleanup_ctx(dev->alloc_ctx[0]);