From patchwork Mon Jun 27 03:06:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Long X-Patchwork-Id: 9199847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A5DB460754 for ; Mon, 27 Jun 2016 03:10:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B67B28555 for ; Mon, 27 Jun 2016 03:10:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9019028564; Mon, 27 Jun 2016 03:10:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2913D28555 for ; Mon, 27 Jun 2016 03:10:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bHMun-0001rd-CD; Mon, 27 Jun 2016 03:08:49 +0000 Received: from mail-qt0-x22a.google.com ([2607:f8b0:400d:c0d::22a]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bHMtX-0000oQ-Pu for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2016 03:07:32 +0000 Received: by mail-qt0-x22a.google.com with SMTP id w59so16533324qtd.3 for ; Sun, 26 Jun 2016 20:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5lzpFvzGLtHCd0LYd29w6cCS2HZ9Rq6xrOxOC3zSf+w=; b=euxHb3XsEVhkcnAXjSsHYA8ysQv68eMCKGr9CMid2QZbcUuNb4FygZuKeIE1ZAN2QI XSCDrSk0/obLxUQB1dWIZsxWgKvjgaA2MTkTx9unBfLo+YU+mKUT0iyNSfJ1BdYDsTB9 D7+pXzbnOnXyfuwx/uzDfFJf1kX2MSs2AV+M0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5lzpFvzGLtHCd0LYd29w6cCS2HZ9Rq6xrOxOC3zSf+w=; b=gdek2GEFAcCnckM+5uIKqBU29f+zpfFjdePRE6nEv8yCMWVdB11w0AlPue0/0V4n5w AZF5JylMeswQl6QgoaDfIcq0e5yze7fqcHmMPudRd0kbEYHnfEz2CivOAIbqf/vNi59C tlHwEtlglnon0HnschQUkDpHyPo2cZKSUMs/zBGX9XJRsPClb2/iiaL9pKGZ8HAtcqd9 8AnRybs/X1sPOj2Dbakru7MTO4guBMcdmLDboTMmthX1zeUXmVPIbdYJluBSOVmgTC7t MzJDUpxQsELSs/Qv+2uTpV2+TbF5sTa4Zz36NjrCrep0AiJAKx3qR7pvV2VvsnRY7lOQ Vsog== X-Gm-Message-State: ALyK8tL2uYRpTMxYmdnIMSUiVPXbv7IdYXq1rlw10Tx9MVe0fEbWfuo1qVvyGHCVeMNtoJHK X-Received: by 10.237.57.41 with SMTP id l38mr20045835qte.74.1466996830623; Sun, 26 Jun 2016 20:07:10 -0700 (PDT) Received: from localhost.localdomain (pool-72-71-243-181.cncdnh.fast00.myfairpoint.net. [72.71.243.181]) by smtp.googlemail.com with ESMTPSA id e187sm262769qkf.35.2016.06.26.20.07.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 26 Jun 2016 20:07:10 -0700 (PDT) From: David Long To: Catalin Marinas , Huang Shijie , James Morse , Marc Zyngier , Pratyush Anand , Sandeepa Prabhu , Will Deacon , William Cohen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Steve Capper , Masami Hiramatsu , Li Bin Subject: [PATCH v14 08/10] arm64: Add trampoline code for kretprobes Date: Sun, 26 Jun 2016 23:06:51 -0400 Message-Id: <1466996813-23295-9-git-send-email-dave.long@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1466996813-23295-1-git-send-email-dave.long@linaro.org> References: <1466996813-23295-1-git-send-email-dave.long@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160626_200731_989682_AD37F41C X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , Mark Rutland , Daniel Thompson , Vladimir Murzin , Petr Mladek , Ard Biesheuvel , Jens Wiklander , Robin Murphy , Mark Brown , Suzuki K Poulose , Dave P Martin , Andrey Ryabinin , yalin wang , Yang Shi , Zi Shen Lim , John Blackwood , Andrew Morton , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Adam Buchbinder , Christoffer Dall MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: William Cohen The trampoline code is used by kretprobes to capture a return from a probed function. This is done by saving the registers, calling the handler, and restoring the registers. The code then returns to the original saved caller return address. It is necessary to do this directly instead of using a software breakpoint because the code used in processing that breakpoint could itself be kprobe'd and cause a problematic reentry into the debug exception handler. Signed-off-by: William Cohen Signed-off-by: David A. Long Acked-by: Masami Hiramatsu --- arch/arm64/include/asm/kprobes.h | 2 + arch/arm64/kernel/asm-offsets.c | 11 ++++ arch/arm64/kernel/kprobes/Makefile | 1 + arch/arm64/kernel/kprobes/kprobes.c | 5 ++ arch/arm64/kernel/kprobes/kprobes_trampoline.S | 85 ++++++++++++++++++++++++++ 5 files changed, 104 insertions(+) create mode 100644 arch/arm64/kernel/kprobes/kprobes_trampoline.S diff --git a/arch/arm64/include/asm/kprobes.h b/arch/arm64/include/asm/kprobes.h index 79c9511..61b4915 100644 --- a/arch/arm64/include/asm/kprobes.h +++ b/arch/arm64/include/asm/kprobes.h @@ -56,5 +56,7 @@ int kprobe_exceptions_notify(struct notifier_block *self, unsigned long val, void *data); int kprobe_breakpoint_handler(struct pt_regs *regs, unsigned int esr); int kprobe_single_step_handler(struct pt_regs *regs, unsigned int esr); +void kretprobe_trampoline(void); +void __kprobes *trampoline_probe_handler(struct pt_regs *regs); #endif /* _ARM_KPROBES_H */ diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c index f8e5d47..03dfa27 100644 --- a/arch/arm64/kernel/asm-offsets.c +++ b/arch/arm64/kernel/asm-offsets.c @@ -51,6 +51,17 @@ int main(void) DEFINE(S_X5, offsetof(struct pt_regs, regs[5])); DEFINE(S_X6, offsetof(struct pt_regs, regs[6])); DEFINE(S_X7, offsetof(struct pt_regs, regs[7])); + DEFINE(S_X8, offsetof(struct pt_regs, regs[8])); + DEFINE(S_X10, offsetof(struct pt_regs, regs[10])); + DEFINE(S_X12, offsetof(struct pt_regs, regs[12])); + DEFINE(S_X14, offsetof(struct pt_regs, regs[14])); + DEFINE(S_X16, offsetof(struct pt_regs, regs[16])); + DEFINE(S_X18, offsetof(struct pt_regs, regs[18])); + DEFINE(S_X20, offsetof(struct pt_regs, regs[20])); + DEFINE(S_X22, offsetof(struct pt_regs, regs[22])); + DEFINE(S_X24, offsetof(struct pt_regs, regs[24])); + DEFINE(S_X26, offsetof(struct pt_regs, regs[26])); + DEFINE(S_X28, offsetof(struct pt_regs, regs[28])); DEFINE(S_LR, offsetof(struct pt_regs, regs[30])); DEFINE(S_SP, offsetof(struct pt_regs, sp)); #ifdef CONFIG_COMPAT diff --git a/arch/arm64/kernel/kprobes/Makefile b/arch/arm64/kernel/kprobes/Makefile index e184d00..ce06312 100644 --- a/arch/arm64/kernel/kprobes/Makefile +++ b/arch/arm64/kernel/kprobes/Makefile @@ -1,2 +1,3 @@ obj-$(CONFIG_KPROBES) += kprobes.o decode-insn.o \ + kprobes_trampoline.o \ simulate-insn.o diff --git a/arch/arm64/kernel/kprobes/kprobes.c b/arch/arm64/kernel/kprobes/kprobes.c index 4dca25b..89936d2 100644 --- a/arch/arm64/kernel/kprobes/kprobes.c +++ b/arch/arm64/kernel/kprobes/kprobes.c @@ -576,6 +576,11 @@ bool arch_within_kprobe_blacklist(unsigned long addr) return false; } +void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs) +{ + return NULL; +} + int __init arch_init_kprobes(void) { return 0; diff --git a/arch/arm64/kernel/kprobes/kprobes_trampoline.S b/arch/arm64/kernel/kprobes/kprobes_trampoline.S new file mode 100644 index 0000000..ba37d85 --- /dev/null +++ b/arch/arm64/kernel/kprobes/kprobes_trampoline.S @@ -0,0 +1,85 @@ +/* + * trampoline entry and return code for kretprobes. + */ + +#include +#include +#include + + .text + +.macro save_all_base_regs + stp x0, x1, [sp, #S_X0] + stp x2, x3, [sp, #S_X2] + stp x4, x5, [sp, #S_X4] + stp x6, x7, [sp, #S_X6] + stp x8, x9, [sp, #S_X8] + stp x10, x11, [sp, #S_X10] + stp x12, x13, [sp, #S_X12] + stp x14, x15, [sp, #S_X14] + stp x16, x17, [sp, #S_X16] + stp x18, x19, [sp, #S_X18] + stp x20, x21, [sp, #S_X20] + stp x22, x23, [sp, #S_X22] + stp x24, x25, [sp, #S_X24] + stp x26, x27, [sp, #S_X26] + stp x28, x29, [sp, #S_X28] + add x0, sp, #S_FRAME_SIZE + stp lr, x0, [sp, #S_LR] +/* + * Construct a useful saved PSTATE + */ + mrs x0, nzcv + and x0, x0, #(PSR_N_BIT | PSR_Z_BIT | PSR_C_BIT | PSR_V_BIT) + mrs x1, daif + and x1, x1, #(PSR_D_BIT | PSR_A_BIT | PSR_I_BIT | PSR_F_BIT) + orr x0, x0, x1 + mrs x1, CurrentEL + and x1, x1, #(3 << 2) + orr x0, x1, x0 + mrs x1, SPSel + and x1, x1, #1 + orr x0, x1, x0 + str x0, [sp, #S_PSTATE] +.endm + +.macro restore_all_base_regs + ldr x0, [sp, #S_PSTATE] + and x0, x0, #(PSR_N_BIT | PSR_Z_BIT | PSR_C_BIT | PSR_V_BIT) + msr nzcv, x0 + ldp x0, x1, [sp, #S_X0] + ldp x2, x3, [sp, #S_X2] + ldp x4, x5, [sp, #S_X4] + ldp x6, x7, [sp, #S_X6] + ldp x8, x9, [sp, #S_X8] + ldp x10, x11, [sp, #S_X10] + ldp x12, x13, [sp, #S_X12] + ldp x14, x15, [sp, #S_X14] + ldp x16, x17, [sp, #S_X16] + ldp x18, x19, [sp, #S_X18] + ldp x20, x21, [sp, #S_X20] + ldp x22, x23, [sp, #S_X22] + ldp x24, x25, [sp, #S_X24] + ldp x26, x27, [sp, #S_X26] + ldp x28, x29, [sp, #S_X28] +.endm + +ENTRY(kretprobe_trampoline) + + sub sp, sp, #S_FRAME_SIZE + + save_all_base_regs + + mov x0, sp + bl trampoline_probe_handler + /* Replace trampoline address in lr with actual + orig_ret_addr return address. */ + mov lr, x0 + + restore_all_base_regs + + add sp, sp, #S_FRAME_SIZE + + ret + +ENDPROC(kretprobe_trampoline)