| Message ID | 1467112869-30488-2-git-send-email-b.zolnierkie@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2016-06-28 20:21 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>: > In case of exynos_bus_parse_of() failure the code shouldn't > try to remove the OPP table and disable+unprepare bus->clk > as it has been already handled in exynos_bus_parse_of(). > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/devfreq/exynos-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c > index 2363d0a..e946f8f 100644 > --- a/drivers/devfreq/exynos-bus.c > +++ b/drivers/devfreq/exynos-bus.c > @@ -407,7 +407,7 @@ static int exynos_bus_probe(struct platform_device *pdev) > /* Parse the device-tree to get the resource information */ > ret = exynos_bus_parse_of(np, bus); > if (ret < 0) > - goto err; > + return ret; > > profile = devm_kzalloc(dev, sizeof(*profile), GFP_KERNEL); > if (!profile) { > -- > 1.9.1 Acked-by: Chanwoo Choi <cw00.choi@samsung.com> And, this patch fixes the bug. It should be included in v4.7-rc version. Thanks, Chanwoo Choi
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 2363d0a..e946f8f 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -407,7 +407,7 @@ static int exynos_bus_probe(struct platform_device *pdev) /* Parse the device-tree to get the resource information */ ret = exynos_bus_parse_of(np, bus); if (ret < 0) - goto err; + return ret; profile = devm_kzalloc(dev, sizeof(*profile), GFP_KERNEL); if (!profile) {
In case of exynos_bus_parse_of() failure the code shouldn't try to remove the OPP table and disable+unprepare bus->clk as it has been already handled in exynos_bus_parse_of(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/devfreq/exynos-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)