From patchwork Mon Jul 4 09:27:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 9212075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6B0F60572 for ; Mon, 4 Jul 2016 09:36:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4BE628572 for ; Mon, 4 Jul 2016 09:36:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A97BE28581; Mon, 4 Jul 2016 09:36:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 13F24285F4 for ; Mon, 4 Jul 2016 09:36:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bK0Gz-0001DE-2s; Mon, 04 Jul 2016 09:34:37 +0000 Received: from mail-cys01nam02on0082.outbound.protection.outlook.com ([104.47.37.82] helo=NAM02-CY1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bK0Gv-00019H-VO for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2016 09:34:34 +0000 Received: from DM2PR03CA0038.namprd03.prod.outlook.com (10.141.96.37) by DM2PR03MB590.namprd03.prod.outlook.com (10.141.85.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.517.8; Mon, 4 Jul 2016 09:34:12 +0000 Received: from BY2FFO11OLC015.protection.gbl (2a01:111:f400:7c0c::192) by DM2PR03CA0038.outlook.office365.com (2a01:111:e400:2428::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.528.16 via Frontend Transport; Mon, 4 Jul 2016 09:34:12 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC015.mail.protection.outlook.com (10.1.15.59) with Microsoft SMTP Server (TLS) id 15.1.523.9 via Frontend Transport; Mon, 4 Jul 2016 09:34:11 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u649Y8pT015788; Mon, 4 Jul 2016 02:34:09 -0700 From: Peter Chen To: , Subject: [PATCH v2 1/1] bus: arm-cci: add missing of_node_put after calling of_parse_phandle Date: Mon, 4 Jul 2016 17:27:01 +0800 Message-ID: <1467624421-2541-1-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131120984520298507; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(5003940100001)(586003)(8676002)(19580395003)(19580405001)(47776003)(69596002)(81156014)(87936001)(97736004)(33646002)(86362001)(50986999)(5001770100001)(85426001)(104016004)(189998001)(81166006)(229853001)(356003)(6806005)(106466001)(105606002)(68736007)(2906002)(92566002)(8936002)(77096005)(50466002)(4326007)(305945005)(7846002)(48376002)(8666005)(50226002)(11100500001)(36756003)(7059030)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR03MB590; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; CAT:NONE; LANG:en; CAT:NONE; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC015; 1:WnTyS3+es6UlpsQZg2fe7zU7VPWQI7KLi1NN+s4U3100V+4n350DNclM97BGg6dzT6szh4Fl3ZTn7trOkJ8plrfsVzfsJfsRpTbEdoEXZ1cNeA98KLqBWSpRkrUQ9horXuUUnkJNCJo8EDTyAb1tnnFjeYo7s9oe53THIfBi2DtCnjlK/tIvVk6moWWJuTRdJkFZPgPQoYyFU/Qen/8mgbO/peNPtWN6ZMHMC5166dd2VWLOkI0MKquAMRPpHH50W8CxaqshxSvnCmUTdYQM5l3YNtWmAEpLyc0lxE3zKu6c3PQEtT133mN+m9wlnaIEon2w+Bk6djZj7nyEJAYEiGfv3qLStIsN7RvavVGX2CFLe6T+cUkpuQ3Vi1XG7qsfo2Aja3UZph2fDqfWb4/G0yUwPB2RXLBAl+74hGh/vXH5m6fUu3ylODHlVjLCTDMx3dz6ElxF5xwEXzmCaQRP1iqcdWGrw6mzHRrN9jvbC8oZMCsQExqavk5K9W08th8L2q9aWQBBDfCwLZvegy872VDPOwzdN13JTeeXXXlQjPDdQPjNQJ69ocsIpNeunro19duuNXAhia4wM2P0JAwhbRB4XoaKlhIvNnfW6SDJtj16HF5eHvU6peGuzdd1fvVQB0pdmqe0nPWFNatkwDvDmQ== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 311c0677-13da-4290-851b-08d3a3ee5b52 X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB590; 2:3EWGQILGt1p/x5lTfKdolWbbFL+OU1EAIAD2rEB7aHPsCgr69wJZ0F1xBpyLxUdmx0etYeljCOxF9NNZCiSNsSnTVGOj0sksxm+zpEsGyFHYpc1pFlfJUFm/resJzuL2L05ed9bT0jFiv29PsG4dmiWgkwtdy/VoqWtNbYNeXp2mfR4dA+1JpboCPHR7ur6U; 3:YCoJKQDzWcwlGTL+XGlrvz24yf/C3zV3WFieEIG8SAqoSGcnWlQs6XS/2CGEyoY49hXFK5Q4XyOFEOiwfptYi3J1ILOtn5sbUBfpnKmCoIw3x1HXJR7bZDvLo+EDagRNfdLuHtBIBXZ6oeOx7ck7lK5tp2lkgv4lzLhvxcPuDQbMFrzvx8qLYdX5yEpl7D+NqcEz4ZmNnqWvfqTxg+lHdKaspH0rBzeAyAY2gmBy5yQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB590; X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB590; 25:XF4X04xkT7KUzBsj3DGS0Q1KFV1Fvs9GdYsO6dz+3G0dCBmWW1YXXxTfeJqqMnes0fYZ3vYGrfF4RCVAvwXb9PBD3m1g7CWQBedv5fB4k4RKUUzyodLT/wIoW7UMPwHlSUkOwwEzg0Y3juLRpWEQ2XfAzM8oqjstE44UD7lh5AyG7TnUTuCsXQmJkQs+fLYooXWjqlkwsIIcXBQFxR5kuk6ltNeXvVb241v4/k2i/8r+6wX8+agFs+IF41/CVrtMve5aAothlShYbfBVjPbX+whw6Sbd/5+HnwdEiHnAuTaL8aHdrkXwuo6fyIbDlRQELajfN+hkaPPUNAN/2/7ajaF/DZNbJCno03l7kVIK50LpawdyB2SJZDH9rQ+o6fDFmvGJ/gzqhA3pu8OlI4NN6O/iA4S13SOsR4/F/lQjd59Mt6hFm/QhxiBaIDorlLeuv5LSdeZcjTt/la9vBIuU/1Vva4LdAT50I+x+GKZw2m9iHEYHkDxrn4oqk/wiCz0nEMiPgxPPIHSSV4VBYA9QHja4ls1RS/2+Nae/N+a0YQrlqgrkCYaiJrotABmakaz57g6hRP8gdoa3cCm0u3UysymOAZ87qqpal/H8CyI3MAzgtTgVq6hG2LnLSQxfVNEP7MhtDsqRtfOovmXm4kO0lxwYp3H8onkmQMMplF0hkzHb3MIaXYC+Oecjnem2GjbFWvv40OyufsLgtru1DMXMTQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(13015025)(8121501046)(13018025)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026); SRVR:DM2PR03MB590; BCL:0; PCL:0; RULEID:(400006); SRVR:DM2PR03MB590; X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB590; 4:MznRHmVW5pj2yNnJkoCazTkEUfZib0YVJ3HIqIjtXQOQQtfmz8ITjR2oLPnsHMFFaq2sfJU/3yFmmaIRaRz9GXiDG6MmtkbcoikMVsiTrBGKYfg2WajDc1c+a21GL8tQGhHlpj+tFqfa4tUxy1lFce/9ge5NH86e/0V9rekLcES6f1sE5/7mFxjiPu2k4eD/yxV39mQUve6FuAfqNdGgirI9m0jrgLUpqq9/mjJLV/tuAjFn1+WAMbk2gJPGdDWITEekp0ail49SOMJrBlnHzdax7TzK/OjawjtZujpoND8r1t4Qq+yC0Ga8o6vAdopfJZaKeXHW/tBhhoUH3BzXExwkhMAKZpNLNK6Uz7lKadJncRfzt49zGYkmc6qywEWkoq1oTzdhL0r9ZbJXss2d5OCNTbB/c/VMYunM5v/T+xKghoSC4TTbAJTg4GX/zhUHIYwpHoobs+nx66iWMAA/fzkuvEDDjYZUBccuOVsJW7cDw1iqpraR1w0ftVffGiPN4T4f7Q8TnzVRF/xkHaQmFhnIR6pLWgLk5IaPC7AG1UYs3+FvzTXO1RVHgHmcdJEx X-Forefront-PRVS: 0993689CD1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR03MB590; 23:nET9nhFdxtc5nBvgfdFgR5xPn9DCjcDRr6nLo6qv3d?= =?us-ascii?Q?r59tcptMuu+snvbrHzDhnx34rvjeIjNLYZiU5JVQc1D3KkbIFu/Sn0Q73cym?= =?us-ascii?Q?D5pm9aPI4y4t0EyMFz58m4tg8TPGrThX8YSStwEqIiMpHkrSs08ln0VsRHEM?= =?us-ascii?Q?bw0Kw/xOHYh1XATGDG9og4bFSx7Sx/1+W+pmvJ5+dCFJNtznZOXbRVkkElih?= =?us-ascii?Q?MEqLu+BXCruFVOtv4AYSE16qcXsvwyhdC2tVVRnQVUqJvRwHQQuW4YMoj4K8?= =?us-ascii?Q?Sw1INpQNj69CrP9p9x7Who2lennpymG3ZloEdQq9eS8ttTQn3RkJ3ZKZj1qc?= =?us-ascii?Q?Ghls+A8T3ODseH6GQ8nCvDVx/eJn9oFRkyevoFV+hwaCEvSw5Yl9gMKkSzGi?= =?us-ascii?Q?OQ9+l1pu0hYWpBZm5CM5vbynZAQLP65Y+YDgER5uNJVHybxYNPEl7NIqvAQY?= =?us-ascii?Q?BTbIPEdS8O6c7xBJtdoTtZZSxRZk5cV7L4qDGG8cEDErMpepXa0LNNlwFyXV?= =?us-ascii?Q?RXvcabGldR461JSBhmNmizgUo8dO4dmc89Tm19IRFk0HcBHz1VAMg9KxQiIp?= =?us-ascii?Q?tUWktJLy1FYwlvS+K+rXDh+q1A3SI7DT0OTlmPwjZBdWwEXEMG2tFtoR1qYq?= =?us-ascii?Q?ZSjbCupMkGzBdyc98KTh0uF1/S9tLQFnqB8XxcWQR2mz6SM9uSqRqs0kMo1x?= =?us-ascii?Q?qv7qIH1Qe8H4kjgz3N7HC+PXwhoKMp2f5fY83zBLiuQbIeHEAPyyrhqO+bX8?= =?us-ascii?Q?6Z1rQrK4Gbj6CvxqtQiFSGsGcLE3DOn4nzVpm3eUcxcHO0KyPxCi/3RQSWkz?= =?us-ascii?Q?R5yCLhJ3FLObdEgZJ7Hu1aQgdR2lw42dbHlqakS2E+hN86rGJ6fLezQhO9Gj?= =?us-ascii?Q?COvvrTIlcv+Fu8nNuXMy2MYFNtja6XeG5Nz6StK/zkFflsObzs4In13ND2ar?= =?us-ascii?Q?ToXQ81sPd/lZYcEXkK1crX8oHj/cyNekASHjaLBK7KWZMv5jKTnWat5D1WHK?= =?us-ascii?Q?THYFFZALWFrwL8wHMbpUjRsDQoNV86silhAJDFqAspX284ZnHjOZpqa31wjb?= =?us-ascii?Q?InuRUGlV9LJ/9dlENQTnleBmoWk6QrDhW5VoqNlNxty2Hg/8zVo1M18B33lG?= =?us-ascii?Q?bIZhaZXIntebsm1+f2sYkqz7dKdfuCS5T7jNByAOVv4gWGBFcruLxRO9Cbtj?= =?us-ascii?Q?tzo8l/t3qeKg6XU4oO2XnoqCEhrIwqwCy/VqO33yvfwECGvFT+mtzifRHO8x?= =?us-ascii?Q?NzfW2xt45vmCMRAXQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB590; 6:aYpF/n11miNEY3KGHNsLWXYS8z0vYEl5wz38oKSJ6sZ7PVH6jTLEkagf4yqYiaLT3PxAS7+rLrBWbNup1fCIM34ysMb8vllLld5Thy4HOM1iZWOMSbnchPogqq4r6R1SWQRVdfmjBzSOitqUdxag4KsSjfvF+mHMqbmPNRCfbJ6SGXGN3ar6knomzk4WHC6QqMrxZpq86VvXORAT8vFhtOcg0xn2MUSRJLbrwvcfskt7wqJ9gcuXY4qRfj8QT2r7tKf5IAiTj9tVJmsE4WjTionmEAVGbHbZbT2ZGeAGVakNxkBnY3QwTR7Of68HROrj; 5:1qTmkmw/5rDrw1dATeqi5gMba2rPVSRSsDsorfMvf9g5qfDMBI2il192tnmI/b5drgh26tZaitew4B1zk6yTqRO3UNSYkO+qoRF4mrg06tP/fcAA8DJk1SkWcEh2hegLruzpznCE/rO7cG5nlXPALlcESzhIutN4OsPZDTg/T98=; 24:PWfbIsRpaTiq92GVTnNY4ozvK6AueAvxb0Ue8q6ZtpTvBBsdOK9dZZyxAJWdKPsxnSFxAdWlabNUp8zvRJi+L0lwu2zp47CIBuTm8VWRY7E=; 7:10k+HaiYdL2+viDagZ7rHOgz0czvPR+Thepair7OTKtAwztNTpEwescv1PC/uMhyiYntQVBsfmbHdJssakgBlAF4MTKifsJWXR8iLH92hDzZjAVB8FfThvGQdI01u6rZK+XuMO/4vaY2Dl2uHC5hqSrmt8KI3pIXPof+EFtnjiRSTa/aMcVkO2CcrPvyv4GExVJ4Nu8m6IS9l2qOHBsqtrqm0CdmgsAn7uZcrm0kX7XF7BrbqzsFRai8Fj/nmxxR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2016 09:34:11.7802 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB590 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160704_023434_139525_0A4C32A1 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: olof@lixom.net, Peter Chen , arm@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: arm@kernel.org Cc: Will Deacon Signed-off-by: Peter Chen Reviewed-by: Suzuki K Poulose --- Changes for v2: - Address suzuki's comments that calling of_node_put one time for both error and corrent code path. drivers/bus/arm-cci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index a49b283..648d130 100644 --- a/drivers/bus/arm-cci.c +++ b/drivers/bus/arm-cci.c @@ -1913,9 +1913,10 @@ static int __cci_ace_get_port(struct device_node *dn, int type) for (i = 0; i < nb_cci_ports; i++) { ace_match = ports[i].type == type; if (ace_match && cci_portn == ports[i].dn) - return i; + break; } - return -ENODEV; + of_node_put(cci_portn); + return (i < nb_cci_ports) ? i : -ENODEV; } int cci_ace_get_port(struct device_node *dn)