From patchwork Thu Jul 7 00:06:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Turquette X-Patchwork-Id: 9217439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AAD8160467 for ; Thu, 7 Jul 2016 00:07:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C2E62856E for ; Thu, 7 Jul 2016 00:07:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9070A28570; Thu, 7 Jul 2016 00:07:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4B0632856E for ; Thu, 7 Jul 2016 00:07:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bKwpt-0000ux-BG; Thu, 07 Jul 2016 00:06:33 +0000 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bKwpq-0000pZ-Do for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2016 00:06:31 +0000 Received: by mail-pa0-x22d.google.com with SMTP id uj8so802024pab.3 for ; Wed, 06 Jul 2016 17:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:content-transfer-encoding:to:from:in-reply-to:cc :references:message-id:user-agent:subject:date; bh=jR33Ap4nlWnA57oFtuc3ImdQudMTs5WOtvRh0YElQ1M=; b=Iq/xLDyNspL0nU8L//OhiA9s9iR6PRxLxxncECAwnoUBnFzDFvEGLzuwyk92WcR6tb U7pi1+uXiiqRNe7707IAVJgdd7ukKpCVjkbPsR3LDS5nvcPtF8pzko5kBCfldVQTDlzH FqKnNbXtFSILK1mNLyUOnY2IP9WoLPKZ/gLREvCSx0ua6LSfzGu4vB29U0R+i0aLeRMU 5NvGUqFJvHFbmc4bbyUXu6B+yiKI5yA3UoMeCEjebnQ5kAOoMEDeCdJvnfJuTYF5agIZ 2fqO2JwZ8UD6+crr5+uizdk9HOwY5/Y9recPvvXYKTgiZA13vJl2yv/zLnTXPrT/O3xs ogPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date; bh=jR33Ap4nlWnA57oFtuc3ImdQudMTs5WOtvRh0YElQ1M=; b=cYkkYQktM449+EjRASMP/yjH9Sqt/4ekBd6Iyz69I0sWTGvd/rqoMRt56u4Ke1vk2b 2QS2XCusUbF8HmeuXTbhIFJkC3PP4C/p8k6RWSyD4BhWmLjajDdgZjw9JwJGrrXBLyej yPeNOaRy8ZlaCzqh4m5GjExpyu4FbY41kCju7XTwQdORLG7COcS/KrrXAoKj0Lma9q0W HzejDYOoG/7TtJ69mDsTKJN1vM1erPwqIrAvht5CyWwIM5jVHBDk9Gko12nduCwWLNon RGwk1CNWWJaJr4IhURBdCB0fxwMLUwHlzQmAVG1kPOs6VxH07FhUlgHscRPGluNo+9Yg ZELw== X-Gm-Message-State: ALyK8tLgLHngXnbnAQY4n5jDyHLd9sEYHM0ITvHIhCGy8OtVsQtXHt6Fgug8AT6qZxvLFOfL X-Received: by 10.67.6.161 with SMTP id cv1mr30919115pad.32.1467849968547; Wed, 06 Jul 2016 17:06:08 -0700 (PDT) Received: from localhost (cpe-172-248-200-249.socal.res.rr.com. [172.248.200.249]) by smtp.gmail.com with ESMTPSA id br6sm5908614pac.0.2016.07.06.17.06.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 17:06:07 -0700 (PDT) MIME-Version: 1.0 To: Kevin Hilman , "Stephen Boyd" From: Michael Turquette In-Reply-To: <20160706230749.9620-1-khilman@baylibre.com> References: <20160706230749.9620-1-khilman@baylibre.com> Message-ID: <146784996534.73491.14217049599437131929@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH] clk: gxbb: expose CLKID_MMC_PCLK Date: Wed, 06 Jul 2016 17:06:05 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160706_170630_549392_9E6151A9 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Kevin, Quoting Kevin Hilman (2016-07-06 16:07:49) > The MMC_PCLK is needed for the SD/eMMC driver. > > Signed-off-by: Kevin Hilman > --- > include/dt-bindings/clock/gxbb-clkc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt-bindings/clock/gxbb-clkc.h > index f889d80246cb..5eb69ec74f6b 100644 > --- a/include/dt-bindings/clock/gxbb-clkc.h > +++ b/include/dt-bindings/clock/gxbb-clkc.h > @@ -8,5 +8,6 @@ > #define CLKID_CPUCLK 1 > #define CLKID_CLK81 12 > #define CLKID_ETH 36 > +#define CLKID_MMC_PCLK 66 I think you're missing removal of the duplicate macro as well: Regards, Mike diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h index a2adf3448b59..f0fab2286c18 100644 --- a/drivers/clk/meson/gxbb.h +++ b/drivers/clk/meson/gxbb.h @@ -234,7 +234,7 @@ #define CLKID_HDMI_PCLK 63 #define CLKID_USB1_DDR_BRIDGE 64 #define CLKID_USB0_DDR_BRIDGE 65 -#define CLKID_MMC_PCLK 66 +/* CLKID_MMC_PCLK */ #define CLKID_DVIN 67 #define CLKID_UART2 68 #define CLKID_SANA 69