From patchwork Tue Jul 12 06:54:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 9224687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 045DA60868 for ; Tue, 12 Jul 2016 06:56:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E88C027EED for ; Tue, 12 Jul 2016 06:56:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB02127F94; Tue, 12 Jul 2016 06:56:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6EE5527EED for ; Tue, 12 Jul 2016 06:56:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bMraX-0005gu-J6; Tue, 12 Jul 2016 06:54:37 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bMraU-0005fi-EI for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2016 06:54:35 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OA601LWZWIAB220@mailout1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2016 15:54:10 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.113]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 44.06.05160.21494875; Tue, 12 Jul 2016 15:54:10 +0900 (KST) X-AuditID: cbfee68e-f79266d000001428-49-57849412146c Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 08.C8.02101.21494875; Tue, 12 Jul 2016 15:54:10 +0900 (KST) Received: from samsunx.samsung ([10.113.63.54]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OA600K94WI7HO30@mmp2.samsung.com>; Tue, 12 Jul 2016 15:54:09 +0900 (KST) From: Andi Shyti To: Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , Mark Brown , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd Subject: [PATCH v3 6/7] spi: s3c64xx: restore removed comments Date: Tue, 12 Jul 2016 15:54:04 +0900 Message-id: <1468306444-18512-1-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 In-reply-to: <57837606.8050906@samsung.com> References: <57837606.8050906@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWyRsSkUFdoSku4wYvLyhbbjzxjtVj84zmT xdSHT9gsrn95zmox/8g5Vosbv9pYLV6/MLTof/ya2WLT42usFh977rFazDi/j8mi8eNNdoul 1y8yWVw85WrRuvcIu8XhN+2sFj/OdLNYrNr1h9FByGPNvDWMHu9vtLJ7XO7rZfK4vuQTs8fO WXfZPTat6mTz2Lyk3qNvyypGj8+b5AI4o7hsUlJzMstSi/TtErgy1nw8yFpwlrNi6+xVjA2M 39i7GDk5JARMJH7f6mWDsMUkLtxbD2RzcQgJrGCUuLVyCVARB1jR8eNyIDVCArMYJd5vlISo +cgosfbIPrBmNgFNiabbP8CaRQSeMUl8aHjNCOIwC2xnkjj2dC0rSJWwgJ3E3gtnwGwWAVWJ OaeuMoPYvAJuEhOPXGCCOENO4vL0B2BTOQW0JS69+80EsVpLYsa+VWBDJQR6OYBu3cQGMUhA 4tvkQywQp8pKbDrADDFHUuLgihssExiFFzAyrGIUTS1ILihOSi8y0itOzC0uzUvXS87P3cQI jLzT/5717WC8ecD6EKMAB6MSD2/Cx+ZwIdbEsuLK3EOMpkAbJjJLiSbnA+M7ryTe0NjMyMLU xNTYyNzSTEmcN0HqZ7CQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxrL1552uT9hUtXn19n4r uf6a2PyrS+eu+1Yasm1bVMC89cLTD/ZOu814OqV/68ozl49orU54M1FcbUPWzMtrbrxQOxGp cFE1nofxjnye4IoZH09qsrd7hJze0tgtl7OmfNXMZY4/rHoPzom4uVX62j6ZfzaTl80yc2/t u9o13cGtS4JNY3rP5QtKLMUZiYZazEXFiQDmHAZltwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t9jQV2hKS3hBnMfyFhsP/KM1WLxj+dM FlMfPmGzuP7lOavF/CPnWC1u/GpjtXj9wtCi//FrZotNj6+xWnzsucdqMeP8PiaLxo832S2W Xr/IZHHxlKtF694j7BaH37SzWvw4081isWrXH0YHIY8189Ywery/0crucbmvl8nj+pJPzB47 Z91l99i0qpPNY/OSeo++LasYPT5vkgvgjGpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw 1DW0tDBXUshLzE21VXLxCdB1y8wB+kdJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyP kQEaSFjDmLHm40HWgrOcFVtnr2JsYPzG3sXIwSEhYCJx/LhcFyMnkCkmceHeejYQW0hgFqPE +42SXYxcQPZHRom1R/aBJdgENCWabv9gA0mICDxjkvjQ8JoRxGEW2M4kcezpWlaQKmEBO4m9 F86A2SwCqhJzTl1lBrF5BdwkJh65wASxTk7i8vQHYFM5BbQlLr37zQSxWktixr5VjBMYeRcw MqxilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECI7uZ1I7GA/ucj/EKMDBqMTDu6CkJVyI NbGsuDL3EKMEB7OSCG9sK1CINyWxsiq1KD++qDQntfgQoynQYROZpUST84GJJ68k3tDYxMzI 0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxSDYx8z4pMLjOGyq+NaZO32OW6yLJ1 0o2kUp5Jysm1bMHzOX9mTb5kHfvDXvRHb15T8v5bejymnydpBU6ZfG7yI/3+5WaTbDtcvAV3 rjQoN6j6vMv5g/jfJym/nisq9U2/KvFSjXnb6fIStlMclYLHpGxvXpVPPJfPbvjpc/7uZO91 K4Nv9N00NFdiKc5INNRiLipOBADESDCVBAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160711_235434_635740_7816872C X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , linux-spi@vger.kernel.org, Jaehoon Chung , Chanwoo Choi , Andi Shyti , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Patch a9e93e8 has erroneously removed some comments which are important to understand why the bus frequency is multiplied by two during the spi transfer. Reword the previous comment to a more appropriate message. Suggested-by: Sylwester Nawrocki Signed-off-by: Andi Shyti Reviewed-by: Michael Turquette --- Hi, despite Mike's comments I'm sending the patch as it was originally meant. I think that fixing the exact clk where to set the rate should anyway go in a different patch. V2->V3 The comment has been reworded as Sylwester recommended. Thanks, Andi drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 6da663f..5bedafc 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) writel(val, regs + S3C64XX_SPI_MODE_CFG); if (sdd->port_conf->clk_from_cmu) { + /* The src_clk clock is divided internally by 2 */ clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); } else { /* Configure Clock */